-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZAP] Ordering of EmberAfAttributeMetadata can save 4 bytes padding per attribute #23720
Labels
Comments
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Jan 10, 2023
bzbarsky-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Jan 10, 2023
andy31415
pushed a commit
that referenced
this issue
Jan 10, 2023
) Fixes #23720 Co-authored-by: Timothy Maes <timothy.maes@qorvo.com>
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this issue
Mar 15, 2023
…336) Fixes project-chip/connectedhomeip#23720 Co-authored-by: Timothy Maes <timothy.maes@qorvo.com>
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this issue
Mar 15, 2023
…336) Fixes project-chip/connectedhomeip#23720 Co-authored-by: Timothy Maes <timothy.maes@qorvo.com>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this issue
Mar 22, 2023
…ject-chip#24336) Fixes project-chip#23720 Co-authored-by: Timothy Maes <timothy.maes@qorvo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction steps / Feature
-- done for qpg - ARM GCC compiler
Re-ordering to avoid padding in a typical best-effort way - largest members first, fitting into native boundaries - 32-bit in this case.
As this can be different on other native typed platforms, the current situation was always bloated:
Ordering of 1 bytes - 2 byte - 1 byte introduces padding for virtually any platform.
As the content is generated from ZAP out, a header update is not enough.
The template in src/app/zap-templates/templates/app/endpoint_config.zapt takes the content straight from a variable, not populated in the connectedhomeip repo - presumeably from ZAP ?
#define GENERATED_ATTRIBUTES {{ endpoint_attribute_list }}
Re-ordering:
Current:
Platform
other
Platform Version(s)
all
Type
Manually tested with SDK
(Optional) If manually tested please explain why this is only manually tested
Build time checked
Anything else?
No response
The text was updated successfully, but these errors were encountered: