Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order members of EmberAfAttributeMetadata to improve packing. #24336

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Re-order members of EmberAfAttributeMetadata to improve packing. #24336

merged 1 commit into from
Jan 10, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Jan 10, 2023 •
edited
Loading

Fixes #23720

@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 10, 2023
Merged
@bzbarsky-apple bzbarsky-apple force-pushed the reorder-attribute-metadata branch from f404a03 to e769c46 Compare January 10, 2023 03:08
@github-actions github-actions bot added the app label Jan 10, 2023
@bzbarsky-apple bzbarsky-apple force-pushed the reorder-attribute-metadata branch from e769c46 to aa1f1ca Compare January 10, 2023 03:12
@github-actions
Copy link

github-actions bot commented Jan 10, 2023 •
edited
Loading

PR #24336: Size comparison from d08e56e to aa1f1ca

Increases above 0.2%:

platform target config section d08e56e aa1f1ca change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171508 174404 2896 1.7
lock-ftd LP_CC2652R7 (read/write) 173440 174496 1056 0.6
lock-mtd LP_CC2652R7 (read/write) 183660 184708 1048 0.6
pump-app LP_CC2652R7 (read/write) 160872 161528 656 0.4
shell LP_CC2652R7 (read/write) 182612 185508 2896 1.6
Increases (23 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section d08e56e aa1f1ca change % change
bl602 lighting-app bl602 .text 1016644 1016646 2 0.0
bl602+rpc .text 1047376 1047632 256 0.0
bl702 lighting-app bl702 .debug_line 5222871 5222879 8 0.0
bl702+rpc .debug_info 44289728 44289729 1 0.0
.debug_line 5620418 5620426 8 0.0
.text 1033764 1033766 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171508 174404 2896 1.7
lock-ftd LP_CC2652R7 (read/write) 173440 174496 1056 0.6
lock-mtd LP_CC2652R7 (read/write) 183660 184708 1048 0.6
.text 556624 556640 16 0.0
pump-app LP_CC2652R7 (read/write) 160872 161528 656 0.4
.text 597284 597300 16 0.0
pump-controller-app LP_CC2652R7 (read/write) 177188 177612 424 0.2
.text 585592 585616 24 0.0
shell LP_CC2652R7 (read/write) 182612 185508 2896 1.6
esp32 all-clusters-app c3devkit (read only) 1221496 1221506 10 0.0
.flash.text 1221496 1221506 10 0.0
m5stack (read only) 1235127 1235147 20 0.0
.flash.text 1229743 1229763 20 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27346723 27346731 8 0.0
.debug_line 3747988 3747993 5 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26907923 26907932 9 0.0
.debug_line 3756903 3756908 5 0.0
light cy8ckit_062s2_43012 .debug_info 22369313 22369321 8 0.0
.debug_line 3323259 3323264 5 0.0
lock cy8ckit_062s2_43012 .debug_info 22587978 22587984 6 0.0
.debug_line 3324359 3324364 5 0.0
telink all-clusters-app tlsr9518adk80d text 689086 689096 10 0.0
all-clusters-minimal-app tlsr9518adk80d text 652378 652386 8 0.0
contact-sensor-app tlsr9518adk80d text 581562 581572 10 0.0
light-switch-app tlsr9518adk80d text 596030 596038 8 0.0
lighting-app tlsr9518adk80d text 661880 661888 8 0.0
ota-requestor-app tlsr9518adk80d text 607280 607290 10 0.0
thermostat tlsr9518adk80d text 596806 596816 10 0.0
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section d08e56e aa1f1ca change % change
bl602 lighting-app bl602 (read/write) 1330486 1329406 -1080 -0.1
bl602+rpc (read/write) 1375726 1374894 -832 -0.1
bl702 lighting-app bl702 (read/write) 1195823 1194735 -1088 -0.1
.debug_loc 3394535 3394501 -34 -0.0
.rodata 116400 115312 -1088 -0.9
bl702+rpc (read/write) 1287987 1286899 -1088 -0.1
.debug_loc 3590542 3590508 -34 -0.0
.rodata 130864 129776 -1088 -0.8
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679971 677075 -2896 -0.4
.rodata 90195 87299 -2896 -3.2
all-clusters-minimal-app LP_CC2652R7 (read only) 642443 640691 -1752 -0.3
.rodata 79139 77387 -1752 -2.2
lock-ftd LP_CC2652R7 (read only) 675567 674511 -1056 -0.2
.rodata 77415 76359 -1056 -1.4
lock-mtd LP_CC2652R7 (read only) 660611 659563 -1048 -0.2
.rodata 103507 102443 -1064 -1.0
pump-app LP_CC2652R7 (read only) 688871 688215 -656 -0.1
.rodata 91103 90431 -672 -0.7
pump-controller-app LP_CC2652R7 (read only) 672659 672235 -424 -0.1
.rodata 86587 86139 -448 -0.5
shell LP_CC2652R7 (read only) 671194 668298 -2896 -0.4
.rodata 86930 84034 -2896 -3.3
cyw30739 light cyw930739m2evb_01 (read/write) 586754 585666 -1088 -0.2
.app_xip_area 463100 462012 -1088 -0.2
lock cyw930739m2evb_01 (read/write) 590454 589398 -1056 -0.2
.app_xip_area 461504 460448 -1056 -0.2
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550558 550022 -536 -0.1
.app_xip_area 432392 431856 -536 -0.1
efr32 lighting-app BRD4161A+rpc (read/write) 975172 974108 -1064 -0.1
.text 820812 819748 -1064 -0.1
BRD4161A+rs911x (read/write) 1038320 1037256 -1064 -0.1
.text 849640 848576 -1064 -0.1
BRD4187C (read/write) 1149004 1147924 -1080 -0.1
.text 983324 982244 -1080 -0.1
lock-app BRD4161A+wf200 (read/write) 1067840 1066792 -1048 -0.1
.text 907612 906564 -1048 -0.1
window-app BRD4187C (read/write) 1141808 1140600 -1208 -0.1
.text 974688 973480 -1208 -0.1
esp32 all-clusters-app c3devkit (read/write) 1791290 1788402 -2888 -0.2
.flash.rodata 248680 245792 -2888 -1.2
m5stack (read/write) 564511 561611 -2900 -0.5
.flash.rodata 314464 311564 -2900 -0.9
k32w contact k32w0+release (read/write) 661196 660316 -880 -0.1
.text 562948 562068 -880 -0.2
light k32w0+release (read/write) 672072 671408 -664 -0.1
.text 592460 591796 -664 -0.1
lock k32w0+release (read/write) 632740 631700 -1040 -0.2
.text 552348 551308 -1040 -0.2
linux chip-tool-ipv6only arm64 (read only) 10686620 10686588 -32 -0.0
.text 8497716 8497684 -32 -0.0
thermostat-no-ble arm64 (read only) 2478436 2478404 -32 -0.0
(read/write) 145016 143016 -2000 -1.4
.data.rel.ro 78640 76632 -2008 -2.6
.text 2068144 2068112 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2462912 2461848 -1064 -0.0
.text 1425556 1424492 -1064 -0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1751612 1748716 -2896 -0.2
.debug_frame 373236 373232 -4 -0.0
.debug_loc 3643197 3643136 -61 -0.0
.text 1551904 1549008 -2896 -0.2
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1691908 1690156 -1752 -0.1
.debug_frame 375680 375676 -4 -0.0
.debug_loc 3626597 3626536 -61 -0.0
.text 1492960 1491208 -1752 -0.1
light cy8ckit_062s2_43012 (read/write) 1609916 1608844 -1072 -0.1
.debug_frame 346012 346008 -4 -0.0
.debug_loc 3326778 3326717 -61 -0.0
.text 1419160 1418088 -1072 -0.1
lock cy8ckit_062s2_43012 (read/write) 1643932 1642876 -1056 -0.1
.debug_frame 347812 347808 -4 -0.0
.debug_loc 3348366 3348305 -61 -0.0
.text 1448184 1447128 -1056 -0.1
qpg lighting-app qpg6105+debug (read/write) 1149452 1148388 -1064 -0.1
.text 596552 595488 -1064 -0.2
lock-app qpg6105+debug (read/write) 1115884 1114836 -1048 -0.1
.text 562980 561932 -1048 -0.2
telink all-clusters-app tlsr9518adk80d (read/write) 1029176 1026288 -2888 -0.3
all-clusters-minimal-app tlsr9518adk80d (read/write) 966368 964628 -1740 -0.2
contact-sensor-app tlsr9518adk80d (read/write) 868456 867572 -884 -0.1
light-switch-app tlsr9518adk80d (read/write) 884820 883888 -932 -0.1
lighting-app tlsr9518adk80d (read/write) 962936 961860 -1076 -0.1
ota-requestor-app tlsr9518adk80d (read/write) 898408 897868 -540 -0.1
thermostat tlsr9518adk80d (read/write) 888124 887128 -996 -0.1
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
platform target config section d08e56e aa1f1ca change % change
bl602 lighting-app bl602 (read/write) 1330486 1329406 -1080 -0.1
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016644 1016646 2 0.0
bl602+rpc (read/write) 1375726 1374894 -832 -0.1
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047376 1047632 256 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195823 1194735 -1088 -0.1
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1538391 1538391 0 0.0
.debug_aranges 132656 132656 0 0.0
.debug_frame 486996 486996 0 0.0
.debug_info 39903960 39903960 0 0.0
.debug_line 5222871 5222879 8 0.0
.debug_loc 3394535 3394501 -34 -0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3507940 3507940 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 115312 -1088 -0.9
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569337 569337 0 0.0
.symtab 172016 172016 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956872 956872 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1287987 1286899 -1088 -0.1
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1686826 1686826 0 0.0
.debug_aranges 140880 140880 0 0.0
.debug_frame 514708 514708 0 0.0
.debug_info 44289728 44289729 1 0.0
.debug_line 5620418 5620426 8 0.0
.debug_loc 3590542 3590508 -34 -0.0
.debug_ranges 395896 395896 0 0.0
.debug_str 3910550 3910550 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130864 129776 -1088 -0.8
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629852 629852 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033764 1033766 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679971 677075 -2896 -0.4
(read/write) 171508 174404 2896 1.7
.bss 81172 81172 0 0.0
.data 3380 3380 0 0.0
.rodata 90195 87299 -2896 -3.2
.text 589460 589460 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642443 640691 -1752 -0.3
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 77387 -1752 -2.2
.text 562984 562984 0 0.0
lock-ftd LP_CC2652R7 (read only) 675567 674511 -1056 -0.2
(read/write) 173440 174496 1056 0.6
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 76359 -1056 -1.4
.text 597672 597672 0 0.0
lock-mtd LP_CC2652R7 (read only) 660611 659563 -1048 -0.2
(read/write) 183660 184708 1048 0.6
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 102443 -1064 -1.0
.text 556624 556640 16 0.0
pump-app LP_CC2652R7 (read only) 688871 688215 -656 -0.1
(read/write) 160872 161528 656 0.4
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 91103 90431 -672 -0.7
.text 597284 597300 16 0.0
pump-controller-app LP_CC2652R7 (read only) 672659 672235 -424 -0.1
(read/write) 177188 177612 424 0.2
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86139 -448 -0.5
.text 585592 585616 24 0.0
shell LP_CC2652R7 (read only) 671194 668298 -2896 -0.4
(read/write) 182612 185508 2896 1.6
.bss 83500 83500 0 0.0
.data 3376 3376 0 0.0
.rodata 86930 84034 -2896 -3.3
.text 583952 583952 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586754 585666 -1088 -0.2
.app_xip_area 463100 462012 -1088 -0.2
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590454 589398 -1056 -0.2
.app_xip_area 461504 460448 -1056 -0.2
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550558 550022 -536 -0.1
.app_xip_area 432392 431856 -536 -0.1
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975172 974108 -1064 -0.1
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 820812 819748 -1064 -0.1
BRD4161A+rs911x (read/write) 1038320 1037256 -1064 -0.1
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 849640 848576 -1064 -0.1
BRD4187C (read/write) 1149004 1147924 -1080 -0.1
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 983324 982244 -1080 -0.1
lock-app BRD4161A+wf200 (read/write) 1067840 1066792 -1048 -0.1
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 907612 906564 -1048 -0.1
window-app BRD4187C (read/write) 1141808 1140600 -1208 -0.1
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 974688 973480 -1208 -0.1
esp32 all-clusters-app c3devkit (read only) 1221496 1221506 10 0.0
(read/write) 1791290 1788402 -2888 -0.2
.dram0.bss 76952 76952 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248680 245792 -2888 -1.2
.flash.text 1221496 1221506 10 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1235127 1235147 20 0.0
(read/write) 564511 561611 -2900 -0.5
.dram0.bss 82104 82104 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314464 311564 -2900 -0.9
.flash.text 1229743 1229763 20 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 661196 660316 -880 -0.1
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 562948 562068 -880 -0.2
light k32w0+release (read/write) 672072 671408 -664 -0.1
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 592460 591796 -664 -0.1
lock k32w0+release (read/write) 632740 631700 -1040 -0.2
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552348 551308 -1040 -0.2
linux chip-tool-ipv6only arm64 (read only) 10686620 10686588 -32 -0.0
(read/write) 691752 691752 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 636088 636088 0 0.0
.dynamic 560 560 0 0.0
.got 13936 13936 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 550860 550860 0 0.0
.text 8497716 8497684 -32 -0.0
thermostat-no-ble arm64 (read only) 2478436 2478404 -32 -0.0
(read/write) 145016 143016 -2000 -1.4
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 76632 -2008 -2.6
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149696 149696 0 0.0
.text 2068144 2068112 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462912 2461848 -1064 -0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425556 1424492 -1064 -0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842024 842024 0 0.0
(read/write) 1751612 1748716 -2896 -0.2
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188656 188656 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1253242 1253242 0 0.0
.debug_aranges 111144 111144 0 0.0
.debug_frame 373236 373232 -4 -0.0
.debug_info 27346723 27346731 8 0.0
.debug_line 3747988 3747993 5 0.0
.debug_loc 3643197 3643136 -61 -0.0
.debug_ranges 356360 356360 0 0.0
.debug_str 3465770 3465770 0 0.0
.heap 842024 842024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 576198 576198 0 0.0
.symtab 423744 423744 0 0.0
.text 0 0 0 0.0
1551904 1549008 -2896 -0.2
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1691908 1690156 -1752 -0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238845 1238845 0 0.0
.debug_aranges 110408 110408 0 0.0
.debug_frame 375680 375676 -4 -0.0
.debug_info 26907923 26907932 9 0.0
.debug_line 3756903 3756908 5 0.0
.debug_loc 3626597 3626536 -61 -0.0
.debug_ranges 354328 354328 0 0.0
.debug_str 3450634 3450634 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536688 536688 0 0.0
.symtab 408704 408704 0 0.0
.text 1492960 1491208 -1752 -0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1609916 1608844 -1072 -0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1072234 1072234 0 0.0
.debug_aranges 102608 102608 0 0.0
.debug_frame 346012 346008 -4 -0.0
.debug_info 22369313 22369321 8 0.0
.debug_line 3323259 3323264 5 0.0
.debug_loc 3326778 3326717 -61 -0.0
.debug_ranges 318464 318464 0 0.0
.debug_str 3256208 3256208 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473013 473013 0 0.0
.symtab 377200 377200 0 0.0
.text 1419160 1418088 -1072 -0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1643932 1642876 -1056 -0.1
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1074034 1074034 0 0.0
.debug_aranges 102992 102992 0 0.0
.debug_frame 347812 347808 -4 -0.0
.debug_info 22587978 22587984 6 0.0
.debug_line 3324359 3324364 5 0.0
.debug_loc 3348366 3348305 -61 -0.0
.debug_ranges 320320 320320 0 0.0
.debug_str 3272042 3272042 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475730 475730 0 0.0
.symtab 379024 379024 0 0.0
.text 1448184 1447128 -1056 -0.1
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149452 1148388 -1064 -0.1
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 596552 595488 -1064 -0.2
lock-app qpg6105+debug (read/write) 1115884 1114836 -1048 -0.1
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 562980 561932 -1048 -0.2
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1029176 1026288 -2888 -0.3
bss 98184 98184 0 0.0
text 689086 689096 10 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 966368 964628 -1740 -0.2
bss 97368 97368 0 0.0
text 652378 652386 8 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868456 867572 -884 -0.1
bss 89524 89524 0 0.0
text 581562 581572 10 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884820 883888 -932 -0.1
bss 89616 89616 0 0.0
text 596030 596038 8 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 962936 961860 -1076 -0.1
bss 97676 97676 0 0.0
text 661880 661888 8 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898408 897868 -540 -0.1
bss 90568 90568 0 0.0
text 607280 607290 10 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888124 887128 -996 -0.1
bss 91004 91004 0 0.0
text 596806 596816 10 0.0

@andy31415 andy31415 merged commit faa7b08 into project-chip:master Jan 10, 2023
@bzbarsky-apple bzbarsky-apple deleted the reorder-attribute-metadata branch January 10, 2023 17:36
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Jan 11, 2023
@andy31415
Fix dynamic bridge metadata init order after project-chip#24336
85f6b32
andy31415 added a commit that referenced this pull request Jan 11, 2023
@andy31415
Fix dynamic bridge metadata init order after #24336 (#24370)
1dce789
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 26, 2023
Closed
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple @tima-q
Re-order members of EmberAfAttributeMetadata to improve packing. (pro…
8ec7527 
…ject-chip#24336)

Fixes project-chip#23720

Co-authored-by: Timothy Maes <timothy.maes@qorvo.com>
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@andy31415
Fix dynamic bridge metadata init order after project-chip#24336 (proj…
c92a9a8 
…ect-chip#24370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@andy31415 andy31415 Awaiting requested review from andy31415

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app github integrations review - approved scripts workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ZAP] Ordering of EmberAfAttributeMetadata can save 4 bytes padding per attribute
4 participants
@bzbarsky-apple @andy31415 @jmartinez-silabs @tima-q