Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make it possible to flag fabric table entries with whether they should be advertised operationally #28279

Closed
bzbarsky-apple opened this issue Jul 25, 2023 · 0 comments · Fixed by #28537
Closed

[Feature] Make it possible to flag fabric table entries with whether they should be advertised operationally #28279

bzbarsky-apple opened this issue Jul 25, 2023 · 0 comments · Fixed by #28537
Labels
feature request feature work needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Feature description

Controllers may want operational advertising for some of their fabric table entries but not others.

This requires:

  1. Adding a boolean to this effect to FabricInfo. Reduce the size of FabricInfo by reordering some members. #28278 ensures there is space to do that easily.
  2. Modifying DnssdServer::AdvertiseOperational to pay attention to this boolean
  3. Updating these FabricTable APIs to allow passing in this boolean:
    1. UpdatePendingFabricWithProvidedOpKey
    2. AddNewPendingFabricWithProvidedOpKey
    3. UpdatePendingFabricWithOperationalKeystore
    4. AddNewPendingFabricWithOperationalKeystore
  4. Adding a boolean to control this to Controller::SetupParams.

Platform

core

Platform Version(s)

No response

Anything else?

No response
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 5, 2023
@bzbarsky-apple
Add support for controllers not advertising their operational identit…
d72fee1 
…ies.

If multiple controllers are running, and some want to enable server interactions
while others do not, the ones not enabling server interactions should not
advertise.

Fixes project-chip#28279
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 5, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 5, 2023
@bzbarsky-apple
Add support for controllers not advertising their operational identit…
7cbb182 
…ies.

If multiple controllers are running, and some want to enable server interactions
while others do not, the ones not enabling server interactions should not
advertise.

Fixes project-chip#28279
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 5, 2023
@bzbarsky-apple
Add support for controllers not advertising their operational identit…
5cb44d0 
…ies.

If multiple controllers are running, and some want to enable server interactions
while others do not, the ones not enabling server interactions should not
advertise.

Fixes project-chip#28279
@mergify mergify bot closed this as completed in #28537 Aug 8, 2023
mergify bot pushed a commit that referenced this issue Aug 8, 2023
@bzbarsky-apple
Add support for controllers not advertising their operational identit…
35998cd 
…ies. (#28537)

If multiple controllers are running, and some want to enable server interactions
while others do not, the ones not enabling server interactions should not
advertise.

Fixes #28279
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Aug 15, 2023
@bzbarsky-apple
Add support for controllers not advertising their operational identit…
78ff362 
…ies. (project-chip#28537)

If multiple controllers are running, and some want to enable server interactions
while others do not, the ones not enabling server interactions should not
advertise.

Fixes project-chip#28279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request feature work needs triage
Projects
None yet
Milestone
No milestone
1 participant
@bzbarsky-apple