-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the size of FabricInfo by reordering some members. #28278
Reduce the size of FabricInfo by reordering some members. #28278
Conversation
PR #28278: Size comparison from 88f9a44 to ec4835e Increases (29 builds for bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
Decreases (33 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, psoc6, qpg)
Full report (35 builds for bl602, bl702, bl702l, cc32xx, cyw30739, esp32, k32w, linux, mbed, psoc6, qpg)
|
ec4835e
to
160cf60
Compare
PR #28278: Size comparison from 1d49d9e to 160cf60 Increases (34 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
Decreases (37 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
Full report (39 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
160cf60
to
d203dbe
Compare
PR #28278: Size comparison from ba05087 to d203dbe Increases (36 builds for bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing all the constexpr size checks: they do not significantly add, but cause much distraction
On 32-bit systems this changes the size from 152 bytes to 144 bytes. On 64-bit systems this changes the size from 168 bytes to 152 bytes.
d203dbe
to
8b37ca4
Compare
PR #28278: Size comparison from a70d5b4 to 1fd036b Increases (37 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ip#28278) * Reduce the size of FabricInfo by reordering some members. On 32-bit systems this changes the size from 152 bytes to 144 bytes. On 64-bit systems this changes the size from 168 bytes to 152 bytes. * Address review comment. * Remove static asserts, because offsetof is not happy on FabricInfo.
…rs. (project-chip#28278) * Reduce the size of FabricInfo by reordering some members. On 32-bit systems this changes the size from 152 bytes to 144 bytes. On 64-bit systems this changes the size from 168 bytes to 152 bytes. * Address review comment. * Remove static asserts, because offsetof is not happy on FabricInfo.
…me members. (project-chip#28278)" This reverts commit 358f4a5.
On 32-bit systems this changes the size from 152 bytes to 144 bytes.
On 64-bit systems this changes the size from 168 bytes to 152 bytes.