-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android add discover #10682
Android add discover #10682
Conversation
Would it make sense to implement the discovery as part of the existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to what Damian said - if you are going to add NsdManagerServiceDiscover
in the platform code, then you should also implement the platform DnssdImpl::ChipDnssdBrowse.
I can accept doing mDNS discovery purely in the app code (i.e. use NsdManager
directly in the app), at least as a temporary solution, but we should not mix these two approaches.
Will review the PR in more detail after this is resolved.
@Damian-Nordic In the case of Android, the only way was to call ServiceResolver to know detailed information such as IP Address and discriminator. (I couldn't find another way.) |
@austinh0 Does it mean that it should be implemented in a jni format similar to the implementation of Service Resolver? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Is there a reason we call discoverCommissionableNodes
, wait, and the check getDiscoveredDevice
instead of having some sort of callback method that is invoked when a device is discovered? I haven't looked at the native implementation in a while.
src/platform/android/java/chip/platform/AndroidChipPlatform.java
Outdated
Show resolved
Hide resolved
src/platform/android/java/chip/platform/NsdManagerServiceBrowse.java
Outdated
Show resolved
Hide resolved
...Tool/app/src/main/java/com/google/chip/chiptool/provisioning/AddressCommissioningFragment.kt
Outdated
Show resolved
Hide resolved
...Tool/app/src/main/java/com/google/chip/chiptool/provisioning/AddressCommissioningFragment.kt
Outdated
Show resolved
Hide resolved
src/platform/android/java/chip/platform/NsdManagerServiceBrowse.java
Outdated
Show resolved
Hide resolved
src/platform/android/java/chip/platform/NsdManagerServiceBrowse.java
Outdated
Show resolved
Hide resolved
src/platform/android/java/chip/platform/NsdManagerServiceResolver.java
Outdated
Show resolved
Hide resolved
(#7985): Annotate csrNonce as Nullable.connectedhomeip/src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Lines 56 to 66 in 4dad4bb
This comment was generated by todo based on a
|
(#8443): This method could benefit from a ChipDevice abstraction to hideconnectedhomeip/src/controller/java/src/chip/devicecontroller/ChipDeviceController.java Lines 101 to 105 in 4dad4bb
This comment was generated by todo based on a
|
Find out if DNS-SD results for Android should contain interface IDconnectedhomeip/src/platform/android/java/chip/platform/NsdManagerServiceResolver.java Lines 87 to 97 in 4dad4bb
This comment was generated by todo based on a
|
4dad4bb
to
8fb2e54
Compare
482bebf
to
f25acd5
Compare
/rebase |
This reverts commit 8ae5b65.
* Add Android Discover * Fix Build error * Modify coding rule, string xml * Modify coding style * Restyled by google-java-format * Restyled by gn * Change browse using android platform layer * Restyled by whitespace * Restyled by google-java-format * Restyled by clang-format * Restyled by clang-format * Modify after review * Remove unused code * Restyled by google-java-format * Restyled by gn * Modify some issue * Fix some issue after reviewing * restore file * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
This reverts commit 8ae5b65.
Problem
What is being fixed?
Change overview
Testing
How was this tested? (at least one bullet point required)