Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring OTA XML into closer alignment with the spec. #11243

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Bring OTA XML into closer alignment with the spec. #11243

merged 3 commits into from
Nov 2, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

  1. Flag optional fields of QueryImage as optional.
  2. Fix ordering of arguments for QueryImage.
  3. Rename ApplyUpdateResponse to match the spec.
  4. Use cluster-objects to send responses in example OTA provider.

Problem

Some optional fields are not optional

Change overview

See above.

Testing

Need to add tests that actually don't send the fields; not sure what the best setup for that is.

@todo
Copy link

todo bot commented Oct 30, 2021

Once our client is using APIs that handle optional arguments

connectedhomeip/examples/ota-provider-app/ota-provider-common/OTAProviderExample.cpp

Lines 160 to 170 in d2ee23f

// TODO: Once our client is using APIs that handle optional arguments
// correctly, update QueryImageResponse to have the right things optional
// and just stop sending metadataForRequestor algether.
response.metadataForRequestor = chip::ByteSpan();
VerifyOrReturnError(commandObj->AddResponseData(commandPath, response) == CHIP_NO_ERROR, EMBER_ZCL_STATUS_FAILURE);
return EMBER_ZCL_STATUS_SUCCESS;
}
EmberAfStatus OTAProviderExample::HandleApplyUpdateRequest(chip::app::CommandHandler * commandObj,
const chip::app::ConcreteCommandPath & commandPath,

This comment was generated by todo based on a TODO comment in d2ee23f in #11243. cc @bzbarsky-apple.

@bzbarsky-apple bzbarsky-apple mentioned this pull request Oct 30, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 30, 2021 •
edited
Loading

PR #11243: Size comparison from bf585f8 to d2ee23f

Increases above 0.2%:

platform target config section bf585f8 d2ee23f change % change
linux ota-provider-app debug .text 1032498 1035138 2640 0.3
Increases (8 builds for esp32, linux, mbed)
platform target config section bf585f8 d2ee23f change % change
esp32 all-clusters-app c3devkit (read only) 880562 880686 124 0.0
.flash.text 880562 880686 124 0.0
m5stack (read only) 911451 911511 60 0.0
.flash.text 911451 911511 60 0.0
linux all-clusters-app debug (read only) 1687001 1687897 896 0.1
.rodata 138069 138229 160 0.1
.text 1415874 1416610 736 0.1
chip-tool debug (read only) 4314925 4315709 784 0.0
.text 3831621 3832405 784 0.0
ota-provider-app debug (read only) 1239033 1241897 2864 0.2
.rodata 110408 110632 224 0.2
.text 1032498 1035138 2640 0.3
ota-requestor-app debug (read only) 1302033 1302129 96 0.0
.text 1077170 1077266 96 0.0
tv-app debug (read only) 1773337 1774713 1376 0.1
.rodata 153464 153592 128 0.1
.text 1477682 1478930 1248 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2294952 2295016 64 0.0
.text 1257552 1257616 64 0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bf585f8 d2ee23f change % change
efr32 lighting-app BRD4161A (read only) 736636 736636 0 0.0
(read/write) 114476 114476 0 0.0
.bss 112724 112724 0 0.0
.data 1752 1752 0 0.0
.text 736628 736628 0 0.0
BRD4161A+rpc (read only) 724076 724076 0 0.0
(read/write) 131080 131080 0 0.0
.bss 129228 129228 0 0.0
.data 1852 1852 0 0.0
.text 724068 724068 0 0.0
lock-app BRD4161A (read only) 715932 715932 0 0.0
(read/write) 112292 112292 0 0.0
.bss 110580 110580 0 0.0
.data 1712 1712 0 0.0
.text 715924 715924 0 0.0
window-app BRD4161A (read only) 716836 716836 0 0.0
(read/write) 112616 112616 0 0.0
.bss 110900 110900 0 0.0
.data 1716 1716 0 0.0
.text 716828 716828 0 0.0
esp32 all-clusters-app c3devkit (read only) 880562 880686 124 0.0
(read/write) 1307800 1307800 0 0.0
.dram0.bss 58456 58456 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199640 199640 0 0.0
.flash.text 880562 880686 124 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911451 911511 60 0.0
(read/write) 427560 427560 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208344 208344 0 0.0
.flash.text 911451 911511 60 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699128 0 0.0
.bss 77720 77720 0 0.0
.data 1900 1900 0 0.0
.text 613708 613708 0 0.0
lock-app k32w061+debug (read/write) 591432 591432 0 0.0
.bss 68220 68220 0 0.0
.data 1864 1864 0 0.0
.text 515548 515548 0 0.0
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1687001 1687897 896 0.1
(read/write) 119024 119024 0 0.0
.bss 50640 50640 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138069 138229 160 0.1
.text 1415874 1416610 736 0.1
bridge-app debug+rpc (read only) 1281957 1281957 0 0.0
(read/write) 84136 84136 0 0.0
.bss 50800 50800 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110020 110020 0 0.0
.text 1076693 1076693 0 0.0
chip-tool debug (read only) 4314925 4315709 784 0.0
(read/write) 123648 123648 0 0.0
.bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98928 98928 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217360 217360 0 0.0
.text 3831621 3832405 784 0.0
lighting-app debug+rpc (read only) 1540865 1540865 0 0.0
(read/write) 101008 101008 0 0.0
.bss 40184 40184 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128113 128113 0 0.0
.text 1280370 1280370 0 0.0
ota-provider-app debug (read only) 1239033 1241897 2864 0.2
(read/write) 67104 67104 0 0.0
.bss 36640 36640 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110408 110632 224 0.2
.text 1032498 1035138 2640 0.3
ota-requestor-app debug (read only) 1302033 1302129 96 0.0
(read/write) 76360 76360 0 0.0
.bss 44896 44896 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25528 25528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127072 127072 0 0.0
.text 1077170 1077266 96 0.0
shell debug (read only) 786145 786145 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 607186 607186 0 0.0
tv-app debug (read only) 1773337 1774713 1376 0.1
(read/write) 288600 288600 0 0.0
.bss 222224 222224 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58704 58704 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153464 153592 128 0.1
.text 1477682 1478930 1248 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294952 2295016 64 0.0
.bss 179828 179828 0 0.0
.data 5216 5216 0 0.0
.heap 851400 851400 0 0.0
.text 1257552 1257616 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274336 2274336 0 0.0
.bss 171868 171868 0 0.0
.data 5568 5568 0 0.0
.heap 859008 859008 0 0.0
.text 1236936 1236936 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252056 2252056 0 0.0
.bss 170772 170772 0 0.0
.data 5552 5552 0 0.0
.heap 860120 860120 0 0.0
.text 1214656 1214656 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048656 2048656 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011256 1011256 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861267 861267 0 0.0
bss 111180 111180 0 0.0
rodata 96860 96860 0 0.0
text 577612 577612 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822095 822095 0 0.0
bss 107424 107424 0 0.0
rodata 87640 87640 0 0.0
text 550784 550784 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786306 786306 0 0.0
bss 112556 112556 0 0.0
rodata 92100 92100 0 0.0
text 507080 507080 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 837975 837975 0 0.0
bss 110216 110216 0 0.0
rodata 93216 93216 0 0.0
text 559092 559092 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763270 763270 0 0.0
bss 111628 111628 0 0.0
rodata 88520 88520 0 0.0
text 488652 488652 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842643 842643 0 0.0
bss 110352 110352 0 0.0
rodata 94460 94460 0 0.0
text 562300 562300 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837947 837947 0 0.0
bss 110252 110252 0 0.0
rodata 93236 93236 0 0.0
text 558932 558932 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776179 776179 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519936 519936 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691202 691202 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440548 440548 0 0.0
p6 lock-app default (read/write) 2167872 2167872 0 0.0
.bss 66216 66216 0 0.0
.data 2416 2416 0 0.0
.heap 964712 964712 0 0.0
.text 1126136 1126136 0 0.0
qpg lighting-app qpg6100+debug (read only) 490500 490500 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50336 50336 0 0.0
.data 1000 1000 0 0.0
.text 485180 485180 0 0.0
lock-app qpg6100+debug (read only) 466844 466844 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49288 49288 0 0.0
.data 956 956 0 0.0
.text 461524 461524 0 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662890 662890 0 0.0
bss 68992 68992 0 0.0
noinit 33216 33216 0 0.0
text 458036 458036 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

I did some digging into the Linux codesize increase (or rather a similar one on Mac). The main reason for the Mac one is that CHIP_CONFIG_VERBOSE_VERIFY_OR_DIE is true, so the VerifyOrDie in Optional::Value adds a bunch of code and string data for the logging call. And it's separate code for every instantiation of Optional. That's probably acceptable; any setup that really cares about codesize will not define CHIP_CONFIG_VERBOSE_VERIFY_OR_DIE to start with.

@andy31415
Copy link
Contributor

@holbrookt @carol-apple @selissia ?

@bzbarsky-apple
Bring OTA XML into closer alignment with the spec.
1a5c9f3 
1) Flag optional fields of QueryImage as optional.
2) Fix ordering of arguments for QueryImage.
3) Rename ApplyUpdateResponse to match the spec.
4) Use cluster-objects to send responses in example OTA provider.
@bzbarsky-apple
Addresss review comments.
b0ec2ac
@bzbarsky-apple
Rebase to tip
d8631d3
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11243: Size comparison from 2fe9024 to d8631d3

Increases above 0.2%:

platform target config section 2fe9024 d8631d3 change % change
linux ota-provider-app debug .text 1029922 1032690 2768 0.3
Increases (8 builds for esp32, linux, mbed)
platform target config section 2fe9024 d8631d3 change % change
esp32 all-clusters-app c3devkit (read only) 880170 880314 144 0.0
.flash.text 880170 880314 144 0.0
m5stack (read only) 911115 911291 176 0.0
.flash.text 911115 911291 176 0.0
linux all-clusters-app debug (read only) 1684009 1685001 992 0.1
.rodata 137749 137909 160 0.1
.text 1413202 1414034 832 0.1
chip-tool debug (read only) 4312861 4313613 752 0.0
.text 3829781 3830565 784 0.0
ota-provider-app debug (read only) 1236329 1239321 2992 0.2
.rodata 110280 110504 224 0.2
.text 1029922 1032690 2768 0.3
ota-requestor-app debug (read only) 1293601 1293665 64 0.0
.text 1074306 1074402 96 0.0
tv-app debug (read only) 1770809 1772281 1472 0.1
.rodata 153080 153208 128 0.1
.text 1475826 1477170 1344 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293560 2293688 128 0.0
.text 1256160 1256288 128 0.0
Decreases (2 builds for linux)
platform target config section 2fe9024 d8631d3 change % change
linux chip-tool debug .rodata 217424 217392 -32 -0.0
ota-requestor-app debug .rodata 121504 121472 -32 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2fe9024 d8631d3 change % change
efr32 lighting-app BRD4161A (read only) 735380 735380 0 0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735372 735372 0 0.0
BRD4161A+rpc (read only) 722820 722820 0 0.0
(read/write) 131048 131048 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 722812 722812 0 0.0
lock-app BRD4161A (read only) 714664 714664 0 0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714656 714656 0 0.0
window-app BRD4161A (read only) 715576 715576 0 0.0
(read/write) 112588 112588 0 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715568 715568 0 0.0
esp32 all-clusters-app c3devkit (read only) 880170 880314 144 0.0
(read/write) 1307528 1307528 0 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199400 199400 0 0.0
.flash.text 880170 880314 144 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911115 911291 176 0.0
(read/write) 427296 427296 0 0.0
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208112 208112 0 0.0
.flash.text 911115 911291 176 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698212 698212 0 0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 612824 612824 0 0.0
lock-app k32w061+debug (read/write) 590508 590508 0 0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514656 514656 0 0.0
shell k32w061+debug (read/write) 424772 424772 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359116 359116 0 0.0
linux all-clusters-app debug (read only) 1684009 1685001 992 0.1
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137749 137909 160 0.1
.text 1413202 1414034 832 0.1
bridge-app debug+rpc (read only) 1278437 1278437 0 0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109508 109508 0 0.0
.text 1073685 1073685 0 0.0
chip-tool debug (read only) 4312861 4313613 752 0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217424 217392 -32 -0.0
.text 3829781 3830565 784 0.0
lighting-app debug+rpc (read only) 1537409 1537409 0 0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127665 127665 0 0.0
.text 1277362 1277362 0 0.0
ota-provider-app debug (read only) 1236329 1239321 2992 0.2
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110280 110504 224 0.2
.text 1029922 1032690 2768 0.3
ota-requestor-app debug (read only) 1293601 1293665 64 0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121504 121472 -32 -0.0
.text 1074306 1074402 96 0.0
shell debug (read only) 785041 785041 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77295 77295 0 0.0
.text 606210 606210 0 0.0
tv-app debug (read only) 1770809 1772281 1472 0.1
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153080 153208 128 0.1
.text 1475826 1477170 1344 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293560 2293688 128 0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256160 1256288 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272688 2272688 0 0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235288 1235288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250344 2250344 0 0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1212944 1212944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048328 2048328 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1010928 1010928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860155 860155 0 0.0
bss 111148 111148 0 0.0
rodata 96340 96340 0 0.0
text 577052 577052 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 820975 820975 0 0.0
bss 107392 107392 0 0.0
rodata 87112 87112 0 0.0
text 550224 550224 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785194 785194 0 0.0
bss 112524 112524 0 0.0
rodata 91580 91580 0 0.0
text 506520 506520 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 836863 836863 0 0.0
bss 110184 110184 0 0.0
rodata 92696 92696 0 0.0
text 558532 558532 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762158 762158 0 0.0
bss 111596 111596 0 0.0
rodata 88000 88000 0 0.0
text 488092 488092 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842843 842843 0 0.0
bss 110320 110320 0 0.0
rodata 94404 94404 0 0.0
text 562588 562588 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836715 836715 0 0.0
bss 110220 110220 0 0.0
rodata 92692 92692 0 0.0
text 558268 558268 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775903 775903 0 0.0
bss 109096 109096 0 0.0
rodata 72404 72404 0 0.0
text 519792 519792 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690906 690906 0 0.0
bss 110080 110080 0 0.0
rodata 67044 67044 0 0.0
text 440400 440400 0 0.0
p6 lock-app default (read/write) 2166544 2166544 0 0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1124808 1124808 0 0.0
qpg lighting-app qpg6100+debug (read only) 489664 489664 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484344 484344 0 0.0
lock-app qpg6100+debug (read only) 465992 465992 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460672 460672 0 0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661586 661586 0 0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457328 457328 0 0.0

@andy31415 andy31415 merged commit 787b7ec into project-chip:master Nov 2, 2021
@todo todo bot mentioned this pull request Nov 2, 2021
Closed
@bzbarsky-apple bzbarsky-apple deleted the ota-optionals-start branch November 2, 2021 14:16
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 2, 2021
Merged
1 task
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Bring OTA XML into closer alignment with the spec. (project-chip#11243)
992f9f2 
* Bring OTA XML into closer alignment with the spec.

1) Flag optional fields of QueryImage as optional.
2) Fix ordering of arguments for QueryImage.
3) Rename ApplyUpdateResponse to match the spec.
4) Use cluster-objects to send responses in example OTA provider.

* Addresss review comments.

* Rebase to tip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@carol-apple carol-apple carol-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@holbrookt holbrookt holbrookt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bzbarsky-apple @andy31415 @holbrookt @yunhanw-google @carol-apple @jmartinez-silabs @jmeg-sfy