Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align QueryImage and QueryImageResponse XML with the spec #11336

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Align QueryImage and QueryImageResponse XML with the spec #11336

merged 2 commits into from
Nov 4, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

QueryImage is not using a list where it should and QueryImageResponse does not have various fields marked as optional.

Change overview

Fix those issues.

Testing

Ran manual test of ota-requestor and ota-provider.

@carol-apple @holbrookt Would it make sense to change HandleQueryImage to just take the response struct as an arg instead of the individual args?

@carol-apple
Copy link
Contributor

@carol-apple @holbrookt Would it make sense to change HandleQueryImage to just take the response struct as an arg instead of the individual args?

Yes, we discussed doing this for OTA Requestor cluster as well. I would support that change

Yes, please!

@holbrookt holbrookt mentioned this pull request Nov 2, 2021
Merged
1 task
@bzbarsky-apple bzbarsky-apple force-pushed the query-image-client-fixup branch from 27a0643 to b08c498 Compare November 2, 2021 23:39
@restyled-io restyled-io bot mentioned this pull request Nov 2, 2021
Closed
@bzbarsky-apple bzbarsky-apple force-pushed the query-image-client-fixup branch from b08c498 to 4f3d032 Compare November 2, 2021 23:40
@bzbarsky-apple
Copy link
Contributor Author

Please make the changes you suggested - to change the signature of HandleQueryImage to take in the command args struct

Done, and same for HandleApplyUpdateRequest. And fixed a few bugs in the caller of that while I was dealing with it anyway.....

@github-actions
Copy link

github-actions bot commented Nov 2, 2021 •
edited
Loading

PR #11336: Size comparison from cb7c854 to 4f3d032

Increases above 0.2%:

platform target config section cb7c854 4f3d032 change % change
linux ota-requestor-app debug (read only) 1310777 1323921 13144 1.0
.data.rel.ro 25512 25576 64 0.3
.rodata 123328 124064 736 0.6
.text 1089682 1101826 12144 1.1
Increases (8 builds for esp32, linux, mbed)
platform target config section cb7c854 4f3d032 change % change
esp32 all-clusters-app c3devkit (read only) 880594 880654 60 0.0
(read/write) 1308072 1308088 16 0.0
.flash.rodata 199768 199784 16 0.0
.flash.text 880594 880654 60 0.0
m5stack (read/write) 427844 427852 8 0.0
.flash.rodata 208468 208476 8 0.0
linux all-clusters-app debug (read only) 1690641 1692129 1488 0.1
.rodata 139861 140053 192 0.1
.text 1417410 1418706 1296 0.1
chip-tool debug (read only) 4348869 4350037 1168 0.0
.rodata 219528 219816 288 0.1
.text 3863637 3864517 880 0.0
ota-provider-app debug (read only) 1243417 1246153 2736 0.2
.rodata 112360 112584 224 0.2
.text 1034978 1037490 2512 0.2
ota-requestor-app debug (read only) 1310777 1323921 13144 1.0
.data.rel.ro 25512 25576 64 0.3
.got 3984 3992 8 0.2
.rodata 123328 124064 736 0.6
.text 1089682 1101826 12144 1.1
tv-app debug (read only) 1810273 1811729 1456 0.1
.rodata 155640 155800 160 0.1
.text 1512370 1513666 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293008 2293144 136 0.0
.text 1255608 1255744 136 0.0
Decreases (2 builds for esp32, linux)
platform target config section cb7c854 4f3d032 change % change
esp32 all-clusters-app m5stack (read only) 911719 911707 -12 -0.0
.flash.text 911719 911707 -12 -0.0
linux ota-requestor-app debug (read/write) 76872 76808 -64 -0.1
.bss 45408 45280 -128 -0.3
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cb7c854 4f3d032 change % change
efr32 lighting-app BRD4161A (read only) 737128 737128 0 0.0
(read/write) 114620 114620 0 0.0
.bss 112860 112860 0 0.0
.data 1756 1756 0 0.0
.text 737120 737120 0 0.0
BRD4161A+rpc (read only) 724552 724552 0 0.0
(read/write) 131220 131220 0 0.0
.bss 129364 129364 0 0.0
.data 1856 1856 0 0.0
.text 724544 724544 0 0.0
lock-app BRD4161A (read only) 716392 716392 0 0.0
(read/write) 112436 112436 0 0.0
.bss 110716 110716 0 0.0
.data 1716 1716 0 0.0
.text 716384 716384 0 0.0
window-app BRD4161A (read only) 717308 717308 0 0.0
(read/write) 112756 112756 0 0.0
.bss 111036 111036 0 0.0
.data 1720 1720 0 0.0
.text 717300 717300 0 0.0
esp32 all-clusters-app c3devkit (read only) 880594 880654 60 0.0
(read/write) 1308072 1308088 16 0.0
.dram0.bss 58608 58608 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199768 199784 16 0.0
.flash.text 880594 880654 60 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911719 911707 -12 -0.0
(read/write) 427844 427852 8 0.0
.dram0.bss 61112 61112 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208468 208476 8 0.0
.flash.text 911719 911707 -12 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699408 699408 0 0.0
.bss 77856 77856 0 0.0
.data 1904 1904 0 0.0
.text 613848 613848 0 0.0
lock-app k32w061+debug (read/write) 591716 591716 0 0.0
.bss 68372 68372 0 0.0
.data 1868 1868 0 0.0
.text 515676 515676 0 0.0
shell k32w061+debug (read/write) 424884 424884 0 0.0
.bss 63296 63296 0 0.0
.data 668 668 0 0.0
.text 359216 359216 0 0.0
linux all-clusters-app debug (read only) 1690641 1692129 1488 0.1
(read/write) 119696 119696 0 0.0
.bss 51152 51152 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62240 62240 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139861 140053 192 0.1
.text 1417410 1418706 1296 0.1
bridge-app debug+rpc (read only) 1283597 1283597 0 0.0
(read/write) 68520 68520 0 0.0
.bss 35056 35056 0 0.0
.data 992 992 0 0.0
.data.rel.ro 27496 27496 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1076581 1076581 0 0.0
chip-tool debug (read only) 4348869 4350037 1168 0.0
(read/write) 124768 124768 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 98896 98896 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 219528 219816 288 0.1
.text 3863637 3864517 880 0.0
lighting-app debug+rpc (read only) 1542921 1542921 0 0.0
(read/write) 101712 101712 0 0.0
.bss 40728 40728 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 54560 54560 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 129553 129553 0 0.0
.text 1280674 1280674 0 0.0
ota-provider-app debug (read only) 1243417 1246153 2736 0.2
(read/write) 67552 67552 0 0.0
.bss 37152 37152 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112360 112584 224 0.2
.text 1034978 1037490 2512 0.2
ota-requestor-app debug (read only) 1310777 1323921 13144 1.0
(read/write) 76872 76808 -64 -0.1
.bss 45408 45280 -128 -0.3
.data 816 816 0 0.0
.data.rel.ro 25512 25576 64 0.3
.dynamic 592 592 0 0.0
.got 3984 3992 8 0.2
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123328 124064 736 0.6
.text 1089682 1101826 12144 1.1
shell debug (read only) 786625 786625 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607298 607298 0 0.0
tv-app debug (read only) 1810273 1811729 1456 0.1
(read/write) 289944 289944 0 0.0
.bss 222768 222768 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155640 155800 160 0.1
.text 1512370 1513666 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293008 2293144 136 0.0
.bss 179964 179964 0 0.0
.data 5216 5216 0 0.0
.heap 851264 851264 0 0.0
.text 1255608 1255744 136 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272008 2272008 0 0.0
.bss 172012 172012 0 0.0
.data 5568 5568 0 0.0
.heap 858864 858864 0 0.0
.text 1234608 1234608 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249728 2249728 0 0.0
.bss 170908 170908 0 0.0
.data 5560 5560 0 0.0
.heap 859976 859976 0 0.0
.text 1212328 1212328 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048496 2048496 0 0.0
.bss 156256 156256 0 0.0
.data 4960 4960 0 0.0
.heap 875232 875232 0 0.0
.text 1011096 1011096 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861331 861331 0 0.0
bss 111320 111320 0 0.0
rodata 96772 96772 0 0.0
text 577620 577620 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822203 822203 0 0.0
bss 107560 107560 0 0.0
rodata 87564 87564 0 0.0
text 550796 550796 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786370 786370 0 0.0
bss 112696 112696 0 0.0
rodata 92028 92028 0 0.0
text 507084 507084 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838035 838035 0 0.0
bss 110356 110356 0 0.0
rodata 93140 93140 0 0.0
text 559096 559096 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763334 763334 0 0.0
bss 111764 111764 0 0.0
rodata 88448 88448 0 0.0
text 488652 488652 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844147 844147 0 0.0
bss 110492 110492 0 0.0
rodata 94852 94852 0 0.0
text 563276 563276 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837891 837891 0 0.0
bss 110392 110392 0 0.0
rodata 93140 93140 0 0.0
text 558832 558832 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775991 775991 0 0.0
bss 109112 109112 0 0.0
rodata 72412 72412 0 0.0
text 519884 519884 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691026 691026 0 0.0
bss 110092 110092 0 0.0
rodata 67052 67052 0 0.0
text 440480 440480 0 0.0
p6 lock-app default (read/write) 2167984 2167984 0 0.0
.bss 66360 66360 0 0.0
.data 2416 2416 0 0.0
.heap 964568 964568 0 0.0
.text 1126248 1126248 0 0.0
qpg lighting-app qpg6100+debug (read only) 490680 490680 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50416 50416 0 0.0
.data 1004 1004 0 0.0
.text 485360 485360 0 0.0
lock-app qpg6100+debug (read only) 467016 467016 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49360 49360 0 0.0
.data 960 960 0 0.0
.text 461696 461696 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18336 18336 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662798 662798 0 0.0
bss 69132 69132 0 0.0
noinit 33216 33216 0 0.0
text 457926 457926 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the query-image-client-fixup branch from 4f3d032 to 410e8a2 Compare November 3, 2021 19:21
@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

PR #11336: Size comparison from fe62374 to 410e8a2

Increases above 0.2%:

platform target config section fe62374 410e8a2 change % change
linux ota-requestor-app debug (read only) 1311169 1324329 13160 1.0
.data.rel.ro 25512 25576 64 0.3
.rodata 123344 124080 736 0.6
.text 1090034 1102194 12160 1.1
Increases (9 builds for esp32, linux, mbed, p6)
platform target config section fe62374 410e8a2 change % change
esp32 all-clusters-app c3devkit (read only) 880670 880742 72 0.0
(read/write) 1308064 1308080 16 0.0
.flash.rodata 199776 199792 16 0.0
.flash.text 880670 880742 72 0.0
m5stack (read/write) 427828 427836 8 0.0
.flash.rodata 208476 208484 8 0.0
linux all-clusters-app debug (read only) 1691153 1692625 1472 0.1
.rodata 139925 140117 192 0.1
.text 1417810 1419090 1280 0.1
chip-tool debug (read only) 4422981 4424165 1184 0.0
.rodata 226384 226672 288 0.1
.text 3928277 3929173 896 0.0
ota-provider-app debug (read only) 1243889 1246625 2736 0.2
.rodata 112456 112680 224 0.2
.text 1035330 1037842 2512 0.2
ota-requestor-app debug (read only) 1311169 1324329 13160 1.0
.data.rel.ro 25512 25576 64 0.3
.got 3984 3992 8 0.2
.rodata 123344 124080 736 0.6
.text 1090034 1102194 12160 1.1
tv-app debug (read only) 1810537 1812025 1488 0.1
.rodata 155528 155720 192 0.1
.text 1512722 1514018 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293160 2293296 136 0.0
.text 1255760 1255896 136 0.0
p6 all-clusters-app default (read/write) 2300640 2300816 176 0.0
.text 1258904 1259080 176 0.0
Decreases (2 builds for esp32, linux)
platform target config section fe62374 410e8a2 change % change
esp32 all-clusters-app m5stack (read only) 911823 911815 -8 -0.0
.flash.text 911823 911815 -8 -0.0
linux ota-requestor-app debug (read/write) 76808 76744 -64 -0.1
.bss 45344 45216 -128 -0.3
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fe62374 410e8a2 change % change
efr32 lighting-app BRD4161A (read only) 737152 737152 0 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737144 737144 0 0.0
BRD4161A+rpc (read only) 726332 726332 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726324 726324 0 0.0
lock-app BRD4161A (read only) 716416 716416 0 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716408 716408 0 0.0
window-app BRD4161A (read only) 717332 717332 0 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717324 717324 0 0.0
esp32 all-clusters-app c3devkit (read only) 880670 880742 72 0.0
(read/write) 1308064 1308080 16 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199776 199792 16 0.0
.flash.text 880670 880742 72 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911823 911815 -8 -0.0
(read/write) 427828 427836 8 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208476 208484 8 0.0
.flash.text 911823 911815 -8 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699400 699400 0 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 613872 613872 0 0.0
lock-app k32w061+debug (read/write) 591724 591724 0 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515716 515716 0 0.0
shell k32w061+debug (read/write) 657656 657656 0 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571024 571024 0 0.0
linux all-clusters-app debug (read only) 1691153 1692625 1472 0.1
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139925 140117 192 0.1
.text 1417810 1419090 1280 0.1
bridge-app debug+rpc (read only) 1287373 1287373 0 0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111460 111460 0 0.0
.text 1080021 1080021 0 0.0
chip-tool debug (read only) 4422981 4424165 1184 0.0
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226384 226672 288 0.1
.text 3928277 3929173 896 0.0
lighting-app debug+rpc (read only) 1548401 1548401 0 0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130129 130129 0 0.0
.text 1284690 1284690 0 0.0
ota-provider-app debug (read only) 1243889 1246625 2736 0.2
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 112456 112680 224 0.2
.text 1035330 1037842 2512 0.2
ota-requestor-app debug (read only) 1311169 1324329 13160 1.0
(read/write) 76808 76744 -64 -0.1
.bss 45344 45216 -128 -0.3
.data 816 816 0 0.0
.data.rel.ro 25512 25576 64 0.3
.dynamic 592 592 0 0.0
.got 3984 3992 8 0.2
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 123344 124080 736 0.6
.text 1090034 1102194 12160 1.1
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1810537 1812025 1488 0.1
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 155528 155720 192 0.1
.text 1512722 1514018 1296 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293160 2293296 136 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255760 1255896 136 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272728 2272728 0 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235328 1235328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250448 2250448 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213048 1213048 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861379 861379 0 0.0
bss 111288 111288 0 0.0
rodata 96772 96772 0 0.0
text 577704 577704 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823755 823755 0 0.0
bss 107640 107640 0 0.0
rodata 87948 87948 0 0.0
text 551888 551888 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786418 786418 0 0.0
bss 112664 112664 0 0.0
rodata 92028 92028 0 0.0
text 507164 507164 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838083 838083 0 0.0
bss 110324 110324 0 0.0
rodata 93140 93140 0 0.0
text 559180 559180 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763382 763382 0 0.0
bss 111732 111732 0 0.0
rodata 88448 88448 0 0.0
text 488732 488732 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844195 844195 0 0.0
bss 110460 110460 0 0.0
rodata 94852 94852 0 0.0
text 563360 563360 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 837939 837939 0 0.0
bss 110360 110360 0 0.0
rodata 93140 93140 0 0.0
text 558916 558916 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519896 519896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440492 440492 0 0.0
p6 all-clusters-app default (read/write) 2300640 2300816 176 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1258904 1259080 176 0.0
lock-app default (read/write) 2213648 2213648 0 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1171912 1171912 0 0.0
qpg lighting-app qpg6100+debug (read only) 490700 490700 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485380 485380 0 0.0
lock-app qpg6100+debug (read only) 467040 467040 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461720 461720 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 662894 662894 0 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458058 458058 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

@msandstedt @saurabhst @LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Could you please take a look?

@bzbarsky-apple bzbarsky-apple merged commit ee7682d into project-chip:master Nov 4, 2021
@bzbarsky-apple bzbarsky-apple deleted the query-image-client-fixup branch November 4, 2021 00:43
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 4, 2021
Closed
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Align QueryImage and QueryImageResponse XML with the spec (project-ch…
531f619 
…ip#11336)

* Use type-safe InvokeCommand to do QueryImage in OTA requestor app.

* Fully align the XML for QueryImage and QueryImageResponse with the spec.
This was referenced Dec 10, 2021
Closed
Closed
Closed
Closed
This was referenced Jan 6, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@holbrookt holbrookt holbrookt approved these changes

@saurabhst saurabhst saurabhst approved these changes

@carol-apple carol-apple Awaiting requested review from carol-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzbarsky-apple @holbrookt @carol-apple @saurabhst @woody-apple @jmartinez-silabs