Fix link to the cirque test guide
#11463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
documentation
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
|
PR #11463: Size comparison from 3f67119 to abe6349 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 5, 2021
|
@markus-becker-tridonic-com Looks like a real failure in your edit |
Similar to #6862. Update of Doxygen in the containers? |
andy31415
approved these changes
Nov 8, 2021
This comment has been minimized.
This comment has been minimized.
|
Our workflow seems to just say: doxygen runs on ubuntu 20.04. https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/doxygen.yaml#L31 Do we need to update doxygen? Can't we make it pass with the current version? |
|
Our scripts try to install doxygen as is. this is probably wasteful (takes time) and installs an old version as well: https://github.com/project-chip/connectedhomeip/blob/master/scripts/helpers/doxygen.sh#L37 I believe it would be best to create a doxygen dockerhub image and then we have more control. |
|
In #11529 I created a doxygen dockerhub image. Will build it and see about transitioning our workflows to using it. |
jelderton
approved these changes
Nov 8, 2021
|
/rebase |
|
Doxygen passes now, however spellcheck seems broken in ToT :( |
|
#11540 will fix spellcheck |
|
PR #11463: Size comparison from 2963857 to d264d0b Full report (9 builds for k32w, p6, qpg, telink)
|
|
/rebase |
|
PR #11463: Size comparison from 537695a to 0269132 Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
Doxygen change was reverted because it does not seem to play nice with GH-pages updates. However this PR now will pass ... but unsure what will happen after merging. @woody-apple ? |
jelderton
approved these changes
Nov 8, 2021
|
/rebase |
|
PR #11463: Size comparison from 064a490 to 15f4bb5 Increases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix link to
the cirque test guideChange overview
Change link.
Testing
Checked the preview of the README.