-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make doxygen run on a the doxygen image instead #11537
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:use_new_doxygen_image
Nov 8, 2021
Merged
Make doxygen run on a the doxygen image instead #11537
andy31415
merged 2 commits into
project-chip:master
from
andy31415:use_new_doxygen_image
Nov 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, so we can control what doxygen version is used
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
selissia
November 8, 2021 18:27
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 8, 2021 18:27
Doxygen run completed, saw output of |
Hotfixing it in so that PRs depending on this can pass. |
PR #11537: Size comparison from a93a7da to fc1a145 Increases above 0.2%:
Increases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
added a commit
that referenced
this pull request
Nov 8, 2021
This reverts commit 2963857.
woody-apple
added a commit
that referenced
this pull request
Nov 8, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Make doxygen run on a the doxygen image instead of just ubuntu latest, so we can control what doxygen version is used * Remove print actor step, seemed only there for debugging
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…#11537)" (project-chip#11543) This reverts commit 2963857.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to make builds slightly faster (still not great because we also need graphviz, can add that later to the image too) and more consistent and not have errors like in #11463