-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SimulatedDevice] Add a test step to wait for commissioning complete #11634
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:CI_WaitForCommissioning
Nov 12, 2021
Merged
[SimulatedDevice] Add a test step to wait for commissioning complete #11634
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:CI_WaitForCommissioning
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst and
selissia
November 10, 2021 15:07
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
wbschiller,
woody-apple and
yufengwangca
November 10, 2021 15:07
PR #11634: Size comparison from a27a311 to 4f13d1a Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 10, 2021
Fast tracking given this enables testing |
woody-apple
approved these changes
Nov 11, 2021
bzbarsky-apple
approved these changes
Nov 11, 2021
vivien-apple
force-pushed
the
CI_WaitForCommissioning
branch
from
November 12, 2021 13:07
4f13d1a
to
74d919c
Compare
PR #11634: Size comparison from c7018a7 to 74d919c Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For simulated node YAML tests, commissioning must complete before testing starts. Some controller certification tests will need to test their ability to walk through node commissioning flow. Therefore, weather commissioning should occur pre-test or not should be up to the script writer.
Change overview
Testing
I have manually verified that it works by removing/adding the new step of
Test_TC_DM_1_3_Simulated
#fixes #11549