Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimulatedDevice] Add a test step to wait for commissioning complete #11634

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

For simulated node YAML tests, commissioning must complete before testing starts. Some controller certification tests will need to test their ability to walk through node commissioning flow. Therefore, weather commissioning should occur pre-test or not should be up to the script writer.

Change overview

  • Add a new command to wait for commissioning

Testing

I have manually verified that it works by removing/adding the new step of Test_TC_DM_1_3_Simulated

#fixes #11549

@github-actions
Copy link

github-actions bot commented Nov 10, 2021

PR #11634: Size comparison from a27a311 to 4f13d1a

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a27a311 4f13d1a change % change
efr32 lighting-app BRD4161A (read only) 742476 742476 0 0.0
(read/write) 116280 116280 0 0.0
.bss 114500 114500 0 0.0
.data 1780 1780 0 0.0
.text 742468 742468 0 0.0
BRD4161A+rpc (read only) 730016 730016 0 0.0
(read/write) 132900 132900 0 0.0
.bss 131004 131004 0 0.0
.data 1896 1896 0 0.0
.text 730008 730008 0 0.0
lock-app BRD4161A (read only) 721756 721756 0 0.0
(read/write) 114096 114096 0 0.0
.bss 112356 112356 0 0.0
.data 1740 1740 0 0.0
.text 721748 721748 0 0.0
window-app BRD4161A (read only) 722668 722668 0 0.0
(read/write) 114420 114420 0 0.0
.bss 112676 112676 0 0.0
.data 1744 1744 0 0.0
.text 722660 722660 0 0.0
esp32 all-clusters-app c3devkit (read only) 879126 879126 0 0.0
(read/write) 1305976 1305976 0 0.0
.dram0.bss 58440 58440 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197832 197832 0 0.0
.flash.text 879126 879126 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910635 910635 0 0.0
(read/write) 423308 423308 0 0.0
.dram0.bss 60952 60952 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204100 204100 0 0.0
.flash.text 910635 910635 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699400 699400 0 0.0
.bss 78012 78012 0 0.0
.data 1908 1908 0 0.0
.text 613680 613680 0 0.0
lock-app k32w061+debug (read/write) 592152 592152 0 0.0
.bss 68548 68548 0 0.0
.data 1876 1876 0 0.0
.text 515928 515928 0 0.0
shell k32w061+debug (read/write) 657780 657780 0 0.0
.bss 79340 79340 0 0.0
.data 1844 1844 0 0.0
.text 570796 570796 0 0.0
linux all-clusters-app debug (read only) 1699057 1699057 0 0.0
(read/write) 126464 126464 0 0.0
.bss 57904 57904 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62288 62288 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139061 139061 0 0.0
.text 1426482 1426482 0 0.0
bridge-app debug+rpc (read only) 1298877 1298877 0 0.0
(read/write) 77296 77296 0 0.0
.bss 42800 42800 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27952 27952 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110932 110932 0 0.0
.text 1091477 1091477 0 0.0
chip-tool debug (read only) 4616445 4616445 0 0.0
(read/write) 135072 135072 0 0.0
.bss 25960 25960 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101424 101424 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240746 240746 0 0.0
.text 4103877 4103877 0 0.0
lighting-app debug+rpc (read only) 1558249 1558249 0 0.0
(read/write) 110408 110408 0 0.0
.bss 48560 48560 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55360 55360 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128369 128369 0 0.0
.text 1295746 1295746 0 0.0
ota-provider-app debug (read only) 1260113 1260113 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44992 44992 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24808 24808 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112615 112615 0 0.0
.text 1050674 1050674 0 0.0
ota-requestor-app debug (read only) 1344673 1344673 0 0.0
(read/write) 79424 79424 0 0.0
.bss 47456 47456 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26072 26072 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123632 123632 0 0.0
.text 1121666 1121666 0 0.0
shell debug (read only) 788537 788537 0 0.0
(read/write) 65640 65640 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36960 36960 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77519 77519 0 0.0
.text 609074 609074 0 0.0
tv-app debug (read only) 1842881 1842881 0 0.0
(read/write) 408248 408248 0 0.0
.bss 340232 340232 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59624 59624 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155757 155757 0 0.0
.text 1542626 1542626 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289320 2289320 0 0.0
.bss 179412 179412 0 0.0
.data 5216 5216 0 0.0
.heap 851816 851816 0 0.0
.text 1251920 1251920 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270688 2270688 0 0.0
.bss 172508 172508 0 0.0
.data 5576 5576 0 0.0
.heap 858360 858360 0 0.0
.text 1233288 1233288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248408 2248408 0 0.0
.bss 171404 171404 0 0.0
.data 5568 5568 0 0.0
.heap 859472 859472 0 0.0
.text 1211008 1211008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048304 2048304 0 0.0
.bss 156464 156464 0 0.0
.data 4968 4968 0 0.0
.heap 875016 875016 0 0.0
.text 1010904 1010904 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861927 861927 0 0.0
bss 111476 111476 0 0.0
rodata 96536 96536 0 0.0
text 578292 578292 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824287 824287 0 0.0
bss 107828 107828 0 0.0
rodata 87712 87712 0 0.0
text 552464 552464 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786966 786966 0 0.0
bss 112848 112848 0 0.0
rodata 91792 91792 0 0.0
text 507760 507760 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838635 838635 0 0.0
bss 110508 110508 0 0.0
rodata 92908 92908 0 0.0
text 559772 559772 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763946 763946 0 0.0
bss 111920 111920 0 0.0
rodata 88212 88212 0 0.0
text 489332 489332 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844727 844727 0 0.0
bss 110648 110648 0 0.0
rodata 94616 94616 0 0.0
text 563936 563936 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838487 838487 0 0.0
bss 110544 110544 0 0.0
rodata 92904 92904 0 0.0
text 559508 559508 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109288 109288 0 0.0
rodata 72156 72156 0 0.0
text 519920 519920 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690982 690982 0 0.0
bss 110272 110272 0 0.0
rodata 66800 66800 0 0.0
text 440528 440528 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2211752 2211752 0 0.0
.bss 101264 101264 0 0.0
.data 2400 2400 0 0.0
.heap 929680 929680 0 0.0
.text 1170016 1170016 0 0.0
qpg lighting-app qpg6100+debug (read only) 490692 490692 0 0.0
(read/write) 114144 114144 0 0.0
.bss 51168 51168 0 0.0
.data 1008 1008 0 0.0
.text 485372 485372 0 0.0
lock-app qpg6100+debug (read only) 466920 466920 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50112 50112 0 0.0
.data 964 964 0 0.0
.text 461600 461600 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663446 663446 0 0.0
bss 69288 69288 0 0.0
noinit 33216 33216 0 0.0
text 458676 458676 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking given this enables testing

@vivien-apple vivien-apple force-pushed the CI_WaitForCommissioning branch from 4f13d1a to 74d919c Compare November 12, 2021 13:07
@github-actions
Copy link

github-actions bot commented Nov 12, 2021

PR #11634: Size comparison from c7018a7 to 74d919c

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c7018a7 74d919c change % change
efr32 lighting-app BRD4161A (read only) 747600 747600 0 0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 747592 747592 0 0.0
BRD4161A+rpc (read only) 735164 735164 0 0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 735156 735156 0 0.0
lock-app BRD4161A (read only) 724440 724440 0 0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 724432 724432 0 0.0
window-app BRD4161A (read only) 725352 725352 0 0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 725344 725344 0 0.0
esp32 all-clusters-app c3devkit (read only) 822918 822918 0 0.0
(read/write) 1222330 1222330 0 0.0
.dram0.bss 56016 56016 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 166976 166976 0 0.0
.flash.text 822918 822918 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 893891 893891 0 0.0
(read/write) 420504 420504 0 0.0
.dram0.bss 61104 61104 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 194020 194020 0 0.0
.flash.text 888507 888507 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701008 701008 0 0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 615792 615792 0 0.0
lock-app k32w061+debug (read/write) 592240 592240 0 0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 516536 516536 0 0.0
shell k32w061+debug (read/write) 657908 657908 0 0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 571444 571444 0 0.0
linux all-clusters-app debug (read only) 1708081 1708081 0 0.0
(read/write) 126272 126272 0 0.0
.bss 57680 57680 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62304 62304 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139829 139829 0 0.0
.text 1434498 1434498 0 0.0
bridge-app debug+rpc (read only) 1302149 1302149 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27992 27992 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111508 111508 0 0.0
.text 1094005 1094005 0 0.0
chip-tool debug (read only) 4580005 4580005 0 0.0
(read/write) 163880 163880 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 114976 114976 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 258922 258922 0 0.0
.text 4020101 4020101 0 0.0
lighting-app debug+rpc (read only) 1568857 1568857 0 0.0
(read/write) 110128 110128 0 0.0
.bss 48080 48080 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129457 129457 0 0.0
.text 1304978 1304978 0 0.0
ota-provider-app debug (read only) 1261625 1261625 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24808 24808 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1051778 1051778 0 0.0
ota-requestor-app debug (read only) 1346409 1346409 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 816 816 0 0.0
.data.rel.ro 26056 26056 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123824 123824 0 0.0
.text 1123186 1123186 0 0.0
shell debug (read only) 788905 788905 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77839 77839 0 0.0
.text 609170 609170 0 0.0
tv-app debug (read only) 1846841 1846841 0 0.0
(read/write) 407864 407864 0 0.0
.bss 339752 339752 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59728 59728 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156525 156525 0 0.0
.text 1545506 1545506 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290392 2290392 0 0.0
.bss 179612 179612 0 0.0
.data 5216 5216 0 0.0
.heap 851616 851616 0 0.0
.text 1252992 1252992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273200 2273200 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1235800 1235800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248832 2248832 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1211432 1211432 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863515 863515 0 0.0
bss 110964 110964 0 0.0
rodata 97084 97084 0 0.0
text 579844 579844 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 825891 825891 0 0.0
bss 107316 107316 0 0.0
rodata 88276 88276 0 0.0
text 554016 554016 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788558 788558 0 0.0
bss 112336 112336 0 0.0
rodata 92344 92344 0 0.0
text 509312 509312 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838751 838751 0 0.0
bss 109988 109988 0 0.0
rodata 93152 93152 0 0.0
text 560148 560148 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764046 764046 0 0.0
bss 111400 111400 0 0.0
rodata 88456 88456 0 0.0
text 489708 489708 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844827 844827 0 0.0
bss 110128 110128 0 0.0
rodata 94860 94860 0 0.0
text 564308 564308 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838607 838607 0 0.0
bss 110024 110024 0 0.0
rodata 93152 93152 0 0.0
text 559884 559884 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775483 775483 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520008 520008 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690538 690538 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440616 440616 0 0.0
p6 all-clusters-app default (read/write) 2298576 2298576 0 0.0
.bss 112608 112608 0 0.0
.data 2520 2520 0 0.0
.heap 918216 918216 0 0.0
.text 1256840 1256840 0 0.0
lock-app default (read/write) 2212408 2212408 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1170672 1170672 0 0.0
qpg lighting-app qpg6100+debug (read only) 492636 492636 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 487316 487316 0 0.0
lock-app qpg6100+debug (read only) 467372 467372 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 462052 462052 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 665742 665742 0 0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 460372 460372 0 0.0

@vivien-apple vivien-apple merged commit 8e9738c into project-chip:master Nov 12, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SimNodes] Add config/flag specifying whether commissioning should occur pre-test or not.
3 participants