Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrf5] implement factoryreset #1196

Merged
merged 2 commits into from
Jun 23, 2020
Merged

[nrf5] implement factoryreset #1196

merged 2 commits into from
Jun 23, 2020

Conversation

bukepo
Copy link
Contributor

@bukepo bukepo commented Jun 22, 2020

Problem

The factory reset function is not implemented.

Summary of Changes

Call OpenThread's factoryreset when the app requests factory reset.

@chip-bot
Copy link

Bloat report for job "Build Examples [ESP32]":

Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
  bloat_report.txt

Bloat difference between master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

  FILE SIZE        VM SIZE    
--------------  -------------- 
+4.6% +68.4Ki  [ = ]       0    .debug_line
+7.4% +44.9Ki  [ = ]       0    .debug_loc
+5.7% +26.5Ki  +5.7% +26.5Ki    .flash.text
+4.5% +4.94Ki  +4.5% +4.94Ki    .flash.rodata
+6.0% +4.76Ki  +6.1% +4.76Ki    .iram0.text
+4.0% +3.77Ki  [ = ]       0    .debug_frame
 +23% +2.02Ki  [ = ]       0    [Unmapped]
+3.9% +1.43Ki  [ = ]       0    .debug_aranges
+2.0%    +280  +2.0%    +280    .dram0.data
 +92%    +240  [ = ]       0    [ELF Headers]
[DEL]    -196  [ = ]       0    .xt.prop._ZN4chip13MessageHeader12SetMessageIdEj
[DEL]    -328  [ = ]       0    .xt.lit._ZN4chip16SecureSessionMgrD5Ev
-0.7%    -672  [ = ]       0    .symtab
[DEL]    -676  [ = ]       0    .xt.prop._ZN2nl9ByteOrder18Swap16LittleToHostEt
-1.3% -1.44Ki  [ = ]       0    .strtab
-41.7% -7.06Ki  [ = ]       0    .shstrtab
-86.8% -7.64Ki  [ = ]       0    [122 Others]
-2.7% -8.80Ki  [ = ]       0    .debug_str
-0.5% -16.5Ki  [ = ]       0    .debug_info
-31.5% -19.5Ki  [ = ]       0    .debug_ranges
-8.0% -26.5Ki  [ = ]       0    .debug_abbrev
+0.9% +67.9Ki  +5.2% +36.5Ki    TOTAL

@chip-bot
Copy link

Bloat report for job "Build Examples [nRF]":

Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
  bloat_report.txt

Bloat difference between master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

  FILE SIZE        VM SIZE    
--------------  -------------- 
 +31% +10.5Ki  [ = ]       0    [Unmapped]
[ = ]       0  [DEL]      -4    [LOAD #2 [RW]]
-2.3%     -12  -2.5%     -12    .data
-3.0% -1.27Ki  [ = ]       0    .debug_aranges
[ = ]       0  -2.1% -1.66Ki    .bss
-2.7% -3.46Ki  [ = ]       0    .debug_frame
-4.1% -4.04Ki  [ = ]       0    .debug_ranges
-2.8% -4.69Ki  [ = ]       0    .strtab
-2.8% -5.34Ki  [ = ]       0    .symtab
-2.6% -10.5Ki  -2.6% -10.5Ki    .text
-11.0% -24.8Ki  [ = ]       0    .debug_abbrev
-7.2% -25.4Ki  [ = ]       0    .debug_macro
-7.8% -27.5Ki  [ = ]       0    .debug_loc
-3.8% -49.1Ki  [ = ]       0    .debug_str
-7.7% -58.1Ki  [ = ]       0    .debug_line
-10.4%  -190Ki  [ = ]       0    .debug_info
-6.6%  -394Ki  -2.4% -12.2Ki    TOTAL

@chip-bot
Copy link

Bloat report for job "Build Examples [main-build]":

Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
  bloat_report.txt

Bloat difference between master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

  FILE SIZE        VM SIZE    
--------------  -------------- 
-11.1%     -16 -20.0%     -16    .data.rel.ro
-0.8%     -16  -0.8%     -16    .plt
-0.5%     -20  -0.5%     -20    [4 Others]
-0.8%     -24  -0.8%     -24    .dynsym
-0.8%     -24  -0.9%     -24    .rela.plt
-1.1%     -32  -1.2%     -32    .eh_frame_hdr
-8.5%     -48  -9.5%     -48    .rela.dyn
-2.0%    -128  [ = ]       0    .debug_aranges
-1.0%    -224  [ = ]       0    .strtab
-1.7%    -240  [ = ]       0    .symtab
-2.3%    -280  -2.3%    -280    .eh_frame
-23.6%    -772 -24.1%    -772    .rodata
-7.4%    -864  [ = ]       0    .debug_ranges
-37.3% -1.27Ki  [ = ]       0    [Unmapped]
-5.1% -1.53Ki  -5.1% -1.53Ki    .text
-3.1% -4.13Ki  [ = ]       0    .debug_macro
-10.4% -4.67Ki  [ = ]       0    .debug_abbrev
-8.0% -6.86Ki  [ = ]       0    .debug_line
-1.6% -7.28Ki  [ = ]       0    .debug_str
-8.6% -7.44Ki  [ = ]       0    .debug_loc
-14.4% -44.6Ki  [ = ]       0    .debug_info
-6.5% -80.4Ki  -0.5% -2.73Ki    TOTAL

@andy31415
Copy link
Contributor

Bloat report for job "Build Examples [ESP32]":

+0.9% +67.9Ki +5.2% +36.5Ki TOTAL

... I assume this was not synced recently? This delta is huge and code change should affect nRF instead.

@chip-bot
Copy link

Bloat report for job "Build Examples [ESP32]":

Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
  bloat_report.txt

Bloat difference between master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

  FILE SIZE        VM SIZE    
--------------  -------------- 
+4.6% +68.4Ki  [ = ]       0    .debug_line
+7.4% +44.9Ki  [ = ]       0    .debug_loc
+5.7% +26.5Ki  +5.7% +26.5Ki    .flash.text
+4.5% +4.93Ki  +4.5% +4.93Ki    .flash.rodata
+6.0% +4.76Ki  +6.1% +4.76Ki    .iram0.text
+4.0% +3.77Ki  [ = ]       0    .debug_frame
 +23% +2.03Ki  [ = ]       0    [Unmapped]
+3.9% +1.43Ki  [ = ]       0    .debug_aranges
+2.0%    +280  +2.0%    +280    .dram0.data
 +92%    +240  [ = ]       0    [ELF Headers]
[DEL]    -196  [ = ]       0    .xt.prop._ZN4chip13MessageHeader12SetMessageIdEj
[DEL]    -328  [ = ]       0    .xt.lit._ZN4chip16SecureSessionMgrD5Ev
-0.7%    -672  [ = ]       0    .symtab
[DEL]    -676  [ = ]       0    .xt.prop._ZN2nl9ByteOrder18Swap16LittleToHostEt
-1.3% -1.44Ki  [ = ]       0    .strtab
-41.7% -7.06Ki  [ = ]       0    .shstrtab
-86.8% -7.64Ki  +0.0%      +8    [123 Others]
-2.7% -8.80Ki  [ = ]       0    .debug_str
-0.5% -16.5Ki  [ = ]       0    .debug_info
-31.5% -19.5Ki  [ = ]       0    .debug_ranges
-8.0% -26.5Ki  [ = ]       0    .debug_abbrev
+0.9% +67.9Ki  +5.2% +36.5Ki    TOTAL

@chip-bot
Copy link

Bloat report for job "Build Examples [nRF]":

Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
  bloat_report.txt

Bloat difference between master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

  FILE SIZE        VM SIZE    
--------------  -------------- 
 +31% +10.5Ki  [ = ]       0    [Unmapped]
[ = ]       0  [DEL]      -4    [LOAD #2 [RW]]
-2.3%     -12  -2.5%     -12    .data
-3.0% -1.27Ki  [ = ]       0    .debug_aranges
[ = ]       0  -2.1% -1.66Ki    .bss
-2.7% -3.46Ki  [ = ]       0    .debug_frame
-4.1% -4.04Ki  [ = ]       0    .debug_ranges
-2.8% -4.69Ki  [ = ]       0    .strtab
-2.8% -5.34Ki  [ = ]       0    .symtab
-2.6% -10.5Ki  -2.6% -10.5Ki    .text
-11.0% -24.8Ki  [ = ]       0    .debug_abbrev
-7.2% -25.4Ki  [ = ]       0    .debug_macro
-7.8% -27.5Ki  [ = ]       0    .debug_loc
-3.8% -49.1Ki  [ = ]       0    .debug_str
-7.7% -58.1Ki  [ = ]       0    .debug_line
-10.4%  -190Ki  [ = ]       0    .debug_info
-6.6%  -394Ki  -2.4% -12.2Ki    TOTAL

@chip-bot
Copy link

Bloat report for job "Build Examples [main-build]":

Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
  bloat_report.txt

Bloat difference between master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

  FILE SIZE        VM SIZE    
--------------  -------------- 
-11.1%     -16 -20.0%     -16    .data.rel.ro
-0.8%     -16  -0.8%     -16    .plt
-0.5%     -20  -0.5%     -20    [4 Others]
-0.8%     -24  -0.8%     -24    .dynsym
-0.8%     -24  -0.9%     -24    .rela.plt
-1.1%     -32  -1.2%     -32    .eh_frame_hdr
-8.5%     -48  -9.5%     -48    .rela.dyn
-2.0%    -128  [ = ]       0    .debug_aranges
-1.0%    -224  [ = ]       0    .strtab
-1.7%    -240  [ = ]       0    .symtab
-2.3%    -280  -2.3%    -280    .eh_frame
-23.6%    -772 -24.1%    -772    .rodata
-7.4%    -864  [ = ]       0    .debug_ranges
-37.3% -1.27Ki  [ = ]       0    [Unmapped]
-5.1% -1.53Ki  -5.1% -1.53Ki    .text
-3.1% -4.13Ki  [ = ]       0    .debug_macro
-10.4% -4.67Ki  [ = ]       0    .debug_abbrev
-8.0% -6.86Ki  [ = ]       0    .debug_line
-1.6% -7.28Ki  [ = ]       0    .debug_str
-8.6% -7.44Ki  [ = ]       0    .debug_loc
-14.4% -44.6Ki  [ = ]       0    .debug_info
-6.5% -80.4Ki  -0.5% -2.73Ki    TOTAL

@woody-apple woody-apple merged commit d8811e4 into project-chip:master Jun 23, 2020
@erjiaqing erjiaqing mentioned this pull request Jun 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@BroderickCarlin BroderickCarlin BroderickCarlin approved these changes

@andy31415 andy31415 andy31415 approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bukepo @chip-bot @andy31415 @gerickson @BroderickCarlin @woody-apple