-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf5-example] Use ConfigurationMgr().InitiateFactoryReset() #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjiaqing
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
June 28, 2020 04:07
saurabhst
approved these changes
Jun 28, 2020
bukepo
reviewed
Jun 28, 2020
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.ipp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.ipp
Outdated
Show resolved
Hide resolved
bukepo
reviewed
Jun 29, 2020
Co-authored-by: Yakun Xu <xyk@google.com>
Size increase report for "Build Examples [ESP32]"
Full report output
|
Size increase report for "Build Examples [nRF]"
Full report output
|
Size increase report for "Build Examples [main-build]"
Full report output
|
erjiaqing
changed the title
Use factory reset in ConfigurationManager in NRF5 platform demo
[nrf5-example] Use factory reset in ConfigurationManager in NRF5 platform example app
Jun 29, 2020
erjiaqing
changed the title
[nrf5-example] Use factory reset in ConfigurationManager in NRF5 platform example app
[nrf5-example] Use ConfigurationMgr().InitiateFactoryReset()
Jun 29, 2020
bukepo
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:+1:
andy31415
approved these changes
Jun 29, 2020
gerickson
approved these changes
Jun 29, 2020
woody-apple
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #1196,
ThreadStackMgr().FactoryReset()
does not clear CHIP configurationsSummary of Changes
Use
ConfigurationMgr().InitiateFactoryReset()
instead ofThreadStackMgr().FactoryReset()