Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf5-example] Use ConfigurationMgr().InitiateFactoryReset() #1317

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Jun 28, 2020

Problem

In #1196, ThreadStackMgr().FactoryReset() does not clear CHIP configurations

Summary of Changes

Use ConfigurationMgr().InitiateFactoryReset() instead of ThreadStackMgr().FactoryReset()

@erjiaqing
Copy link
Contributor Author

@bukepo @kghost @gjc13 PTAL

Co-authored-by: Yakun Xu <xyk@google.com>
@chip-bot
Copy link

Size increase report for "Build Examples [ESP32]"

File Section File VM
chip-wifi-echo.elf .dram0.bss 0 16
chip-wifi-echo.elf .flash.rodata -8 -8
chip-wifi-echo.elf .flash.text -44 -44
Full report output
Bloat report for job 'Build Examples [ESP32]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/esp32-build/chip-wifi-echo.elf and example_binaries/esp32-build/chip-wifi-echo.elf:

sections,vmsize,filesize
.dram0.bss,16,0
[Unmapped],0,11
.debug_str,0,-3
.flash.rodata,-8,-8
.flash.text,-44,-44


@chip-bot
Copy link

Size increase report for "Build Examples [nRF]"

File Section File VM
chip-nrf52840-lock-example.out .text 332 332
chip-nrf52840-lock-example.out [LOAD #2 [RW]] 0 4
Full report output
Bloat report for job 'Build Examples [nRF]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/nrf-build/chip-nrf52840-lock-example.out and example_binaries/nrf-build/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_info,0,3536
.text,332,332
.strtab,0,270
.symtab,0,240
.debug_abbrev,0,103
.debug_line,0,5
[LOAD #2 [RW]],4,0
.debug_str,0,-126
[Unmapped],0,-332


@chip-bot
Copy link

Size increase report for "Build Examples [main-build]"

File Section File VM
Full report output
Bloat report for job 'Build Examples [main-build]'

Files found only in the baseline:
    bloat_report.txt

Comparing master_binaries/main-build/chip-standalone-demo.out and example_binaries/main-build/chip-standalone-demo.out:

sections,vmsize,filesize


@erjiaqing erjiaqing changed the title Use factory reset in ConfigurationManager in NRF5 platform demo [nrf5-example] Use factory reset in ConfigurationManager in NRF5 platform example app Jun 29, 2020
@erjiaqing erjiaqing changed the title [nrf5-example] Use factory reset in ConfigurationManager in NRF5 platform example app [nrf5-example] Use ConfigurationMgr().InitiateFactoryReset() Jun 29, 2020
Copy link
Contributor

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@woody-apple woody-apple merged commit 5f0b920 into project-chip:master Jun 29, 2020
@woody-apple woody-apple deleted the factory-reset branch June 29, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants