Multiple Controllers: DND-SD should be able to support multiple consu… #12261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
wbschiller,
woody-apple and
yunhanw-google
|
PR #12261: Size comparison from 914b58e to 938b56b Increases (16 builds for efr32, k32w, linux, qpg)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
vivien-apple
force-pushed
the
Controller_MultipleDNSSD_Delegates
branch
from
938b56b to
b045fa5
Compare
vivien-apple
force-pushed
the
Controller_MultipleDNSSD_Delegates
branch
from
b045fa5 to
1b6fefe
Compare
|
PR #12261: Size comparison from 914b58e to 1b6fefe Increases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 30, 2021
woody-apple
approved these changes
Dec 2, 2021
woody-apple
requested review from
Damian-Nordic and
tcarmelveilleux
and removed request for
Damian-Nordic
gjc13
reviewed
Dec 3, 2021
| resolverDelegate = delegate; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe we can return an error or print some error message when we run out of empty slots?
Damian-Nordic
approved these changes
Dec 3, 2021
|
I'm closing this one in favour of ##12481 as it does not limit the number of delegates and it has a better routing mechanism . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mers
Problem
DNS-SD only supports 1 resolver delegate.
This is a problem for #10089 and for having multiple controller/commissioner objects in a single process.
Change overview
Testing
It was tested by locally modifying
chip-toolby having multiple instances of theCHIPDeviceControllerinto the same process.Fix #11562