-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ResolveProxy class to keep track of which controller is issuing… #12481
Add a ResolveProxy class to keep track of which controller is issuing… #12481
Conversation
Use seconds?connectedhomeip/src/lib/dnssd/Discovery_ImplPlatform.cpp Lines 90 to 100 in 92326da
This comment was generated by todo based on a
|
Fast tracking, given this has been in review for > 3 days, still pending review feedback. |
787a21b
to
07b6280
Compare
PR #12481: Size comparison from 051685b to 07b6280 Increases above 0.2%:
Increases (25 builds for efr32, k32w, linux, nrfconnect, qpg)
Decreases (10 builds for linux, nrfconnect)
Full report (37 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
93de6e4
to
e4979f1
Compare
PR #12481: Size comparison from 051685b to e4979f1 Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, nrfconnect, qpg)
Decreases (10 builds for linux, nrfconnect)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
e4979f1
to
184209f
Compare
184209f
to
85d177a
Compare
PR #12481: Size comparison from a7dd25e to 85d177a Increases (1 build for linux)
Full report (2 builds for linux)
|
85d177a
to
661203c
Compare
PR #12481: Size comparison from a7dd25e to 661203c Increases (6 builds for k32w, linux, qpg)
Full report (12 builds for k32w, linux, p6, qpg, telink)
|
661203c
to
3e1478e
Compare
PR #12481: Size comparison from 1f4024a to 3e1478e Increases (6 builds for k32w, linux, qpg)
Full report (12 builds for k32w, linux, p6, qpg, telink)
|
3e1478e
to
07c9c31
Compare
I have added a comment to make it clearer that minimal is not really supporting parallel requests in contrary to platforms implementations. |
PR #12481: Size comparison from 1f4024a to 07c9c31 Increases (18 builds for efr32, k32w, linux, nrfconnect, qpg)
Decreases (9 builds for nrfconnect)
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
07c9c31
to
f64fff9
Compare
PR #12481: Size comparison from b1d7073 to f64fff9 Increases (16 builds for efr32, esp32, linux, nrfconnect, qpg)
Decreases (9 builds for nrfconnect)
Full report (29 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
|
/rebase |
…ot trying to access a dangling pointer once a response is received
f64fff9
to
6dd833f
Compare
PR #12481: Size comparison from f18d8b7 to 6dd833f Increases (19 builds for efr32, esp32, k32w, linux, nrfconnect, qpg)
Decreases (9 builds for nrfconnect)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
project-chip#12481) * Add a ResolveProxy class to keep track of which controller is issuing a dns request * Use ReferenceCount<ResolverDelegateProxy> to make sure the stack is not trying to access a dangling pointer once a response is received
… a dns request
Problem
DNS-SD only supports 1 resolver delegate.
This is a problem for #10089 and for having multiple controller/commissioner objects in a single process.
Change overview
Testing
It was tested by locally modifying
chip-tool
by having multiple instances of theCHIPDeviceController
into the same process.Fix #11562
This is an other version of ##12261 where the code was updated to have multiple delegates, but here there is a proxy in between the singleton instance of the resolver and the clients. It allows mapping the request directly to the right controller.