Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zephyr] Added support for getting GeneralDiagnostics attributes #12552

Merged
merged 1 commit into from
Dec 7, 2021
Merged

[zephyr] Added support for getting GeneralDiagnostics attributes #12552

merged 1 commit into from
Dec 7, 2021

Conversation

kkasperczyk-no
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no commented Dec 3, 2021 •
edited
Loading

Problem

nrfconnect/Zephyr platform doesn't support get methods for GeneralDiagnostics attributes

Change overview

  • Added methods for getting RebootCount, NetworkInterfaces and BootReasons
  • Added to the InterfaceIterator methods allowing to get interface type and hardware address using Zephyr API
  • Added BootReasonType to the DiagnosticDataProvider to remove dependency between platform and auto-generated code

Testing

Tested manually for nrfconnect platform using Python CHIP Controller zclread GeneralDiagnostics commands

kpschoedel
kpschoedel reviewed Dec 3, 2021
View reviewed changes
src/inet/InetInterface.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12552: Size comparison from e8da685 to 7ca45e1

Increases (1 build for telink)
platform target config section e8da685 7ca45e1 change % change
telink lighting-app tlsr9518adk80d (read/write) 794710 795390 680 0.1
text 554486 555084 598 0.1
Full report (17 builds for esp32, k32w, mbed, p6, qpg, telink)
platform target config section e8da685 7ca45e1 change % change
esp32 all-clusters-app c3devkit (read only) 846628 846628 0 0.0
(read/write) 1224122 1224122 0 0.0
.dram0.bss 56584 56584 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 168024 168024 0 0.0
.flash.text 846628 846628 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 917155 917155 0 0.0
(read/write) 423084 423084 0 0.0
.dram0.bss 61968 61968 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195820 195820 0 0.0
.flash.text 911771 911771 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728604 728604 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641632 641632 0 0.0
lock-app k32w061+debug (read/write) 617716 617716 0 0.0
.bss 69752 69752 0 0.0
.data 1824 1824 0 0.0
.text 540340 540340 0 0.0
shell k32w061+debug (read/write) 683608 683608 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594612 594612 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305920 2305920 0 0.0
.bss 179644 179644 0 0.0
.data 5184 5184 0 0.0
.heap 851616 851616 0 0.0
.text 1268496 1268496 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295744 2295744 0 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258344 1258344 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268968 2268968 0 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231568 1231568 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046960 2046960 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009560 1009560 0 0.0
p6 all-clusters-app default (read/write) 2338312 2338312 0 0.0
.bss 107828 107828 0 0.0
.data 2456 2456 0 0.0
.heap 923056 923056 0 0.0
.text 1296576 1296576 0 0.0
light-app default (read/write) 2279024 2279024 0 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237288 1237288 0 0.0
lock-app default (read/write) 2254520 2254520 0 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212784 1212784 0 0.0
qpg lighting-app qpg6100+debug (read only) 510404 510404 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505084 505084 0 0.0
lock-app qpg6100+debug (read only) 483316 483316 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79184 79184 0 0.0
.data 916 916 0 0.0
.text 477996 477996 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794710 795390 680 0.1
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554486 555084 598 0.1

@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_support_pr branch from 7ca45e1 to 4ad880f Compare December 6, 2021 06:38
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12552: Size comparison from 186c004 to 4ad880f

Increases above 0.2%:

platform target config section 186c004 4ad880f change % change
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 99588 99816 228 0.2
nrf5340dk_nrf5340_cpuapp rodata 94844 95072 228 0.2
lock-app nrf52840dk_nrf52840 rodata 95704 95932 228 0.2
nrf5340dk_nrf5340_cpuapp rodata 90996 91224 228 0.3
pump-app nrf52840dk_nrf52840 rodata 97060 97288 228 0.2
pump-controller-app nrf52840dk_nrf52840 rodata 95196 95424 228 0.2
shell nrf52840dk_nrf52840 rodata 73792 74020 228 0.3
nrf5340dk_nrf5340_cpuapp rodata 68432 68660 228 0.3
Increases (18 builds for linux, nrfconnect, telink)
platform target config section 186c004 4ad880f change % change
linux all-clusters-app debug (read only) 1851521 1851649 128 0.0
.rodata 151285 151413 128 0.1
bridge-app debug+rpc (read only) 1432645 1432757 112 0.0
.rodata 121948 122060 112 0.1
chip-tool debug (read only) 6619645 6619749 104 0.0
.rodata 309912 310016 104 0.0
lighting-app debug+rpc (read only) 1717761 1717889 128 0.0
.rodata 142577 142705 128 0.1
ota-provider-app debug (read only) 1393289 1393401 112 0.0
.rodata 122792 122904 112 0.1
ota-requestor-app debug (read only) 1502561 1502681 120 0.0
.rodata 135504 135624 120 0.1
shell debug (read only) 823129 823225 96 0.0
.rodata 84338 84434 96 0.1
tv-app debug (read only) 2031625 2031729 104 0.0
.rodata 175344 175448 104 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 892791 1076 0.1
rodata 99588 99816 228 0.2
text 602824 603668 844 0.1
nrf52840dk_nrf52840+rpc (read/write) 855091 855743 652 0.1
rodata 90948 91008 60 0.1
text 577820 578408 588 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 817610 818734 1124 0.1
rodata 94844 95072 228 0.2
text 533156 534032 876 0.2
lock-app nrf52840dk_nrf52840 (read/write) 863639 864731 1092 0.1
rodata 95704 95932 228 0.2
text 581540 582388 848 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 789794 790902 1108 0.1
rodata 90996 91224 228 0.3
text 511964 512840 876 0.2
pump-app nrf52840dk_nrf52840 (read/write) 868523 869615 1092 0.1
rodata 97060 97288 228 0.2
text 585080 585928 848 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 862855 1092 0.1
rodata 95196 95424 228 0.2
text 580312 581160 848 0.1
shell nrf52840dk_nrf52840 (read/write) 779939 781015 1076 0.1
rodata 73792 74020 228 0.3
text 521948 522792 844 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696074 1108 0.2
rodata 68432 68660 228 0.3
text 442548 443420 872 0.2
telink lighting-app tlsr9518adk80d (read/write) 794746 795426 680 0.1
text 554540 555138 598 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 186c004 4ad880f change % change
efr32 lighting-app BRD4161A (read only) 751672 751672 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751664 751664 0 0.0
BRD4161A+rpc (read only) 780344 780344 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780336 780336 0 0.0
lock-app BRD4161A (read only) 726496 726496 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726488 726488 0 0.0
window-app BRD4161A (read only) 729000 729000 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728992 728992 0 0.0
esp32 all-clusters-app c3devkit (read only) 847922 847922 0 0.0
(read/write) 1222786 1222786 0 0.0
.dram0.bss 55352 55352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167920 167920 0 0.0
.flash.text 847922 847922 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918319 918319 0 0.0
(read/write) 421756 421756 0 0.0
.dram0.bss 60736 60736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195724 195724 0 0.0
.flash.text 912935 912935 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1851521 1851649 128 0.0
(read/write) 123344 123344 0 0.0
.bss 49680 49680 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 151285 151413 128 0.1
.text 1557154 1557154 0 0.0
bridge-app debug+rpc (read only) 1432645 1432757 112 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121948 122060 112 0.1
.text 1205797 1205797 0 0.0
chip-tool debug (read only) 6619645 6619749 104 0.0
(read/write) 199688 199688 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158456 158456 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 309912 310016 104 0.0
.text 5905173 5905173 0 0.0
lighting-app debug+rpc (read only) 1717761 1717889 128 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142577 142705 128 0.1
.text 1432514 1432514 0 0.0
ota-provider-app debug (read only) 1393289 1393401 112 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122792 122904 112 0.1
.text 1165810 1165810 0 0.0
ota-requestor-app debug (read only) 1502561 1502681 120 0.0
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135504 135624 120 0.1
.text 1258418 1258418 0 0.0
shell debug (read only) 823129 823225 96 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84338 84434 96 0.1
.text 631954 631954 0 0.0
tv-app debug (read only) 2031625 2031729 104 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175344 175448 104 0.1
.text 1701538 1701538 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307096 2307096 0 0.0
.bss 178404 178404 0 0.0
.data 5184 5184 0 0.0
.heap 852856 852856 0 0.0
.text 1269672 1269672 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270288 2270288 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232888 1232888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 892791 1076 0.1
bss 113756 113756 0 0.0
rodata 99588 99816 228 0.2
text 602824 603668 844 0.1
nrf52840dk_nrf52840+rpc (read/write) 855091 855743 652 0.1
bss 110104 110104 0 0.0
rodata 90948 91008 60 0.1
text 577820 578408 588 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 817610 818734 1124 0.1
bss 115128 115128 0 0.0
rodata 94844 95072 228 0.2
text 533156 534032 876 0.2
lock-app nrf52840dk_nrf52840 (read/write) 863639 864731 1092 0.1
bss 111016 111016 0 0.0
rodata 95704 95932 228 0.2
text 581540 582388 848 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 789794 790902 1108 0.1
bss 112428 112428 0 0.0
rodata 90996 91224 228 0.3
text 511964 512840 876 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 869615 1092 0.1
bss 110928 110928 0 0.0
rodata 97060 97288 228 0.2
text 585080 585928 848 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 862855 1092 0.1
bss 110808 110808 0 0.0
rodata 95196 95424 228 0.2
text 580312 581160 848 0.1
shell nrf52840dk_nrf52840 (read/write) 779939 781015 1076 0.1
bss 109696 109696 0 0.0
rodata 73792 74020 228 0.3
text 521948 522792 844 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696074 1108 0.2
bss 110680 110680 0 0.0
rodata 68432 68660 228 0.3
text 442548 443420 872 0.2
p6 all-clusters-app default (read/write) 2340160 2340160 0 0.0
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1298424 1298424 0 0.0
light-app default (read/write) 2279680 2279680 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1237944 1237944 0 0.0
lock-app default (read/write) 2255984 2255984 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214248 1214248 0 0.0
qpg lighting-app qpg6100+debug (read only) 510464 510464 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505144 505144 0 0.0
lock-app qpg6100+debug (read only) 484132 484132 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478812 478812 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794746 795426 680 0.1
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554540 555138 598 0.1

@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_support_pr branch from 1455e69 to 6f8c61a Compare December 6, 2021 08:19
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

PR #12552: Size comparison from bfdbd45 to 6f8c61a

Increases (1 build for telink)
platform target config section bfdbd45 6f8c61a change % change
telink lighting-app tlsr9518adk80d (read/write) 798382 799126 744 0.1
text 558088 558716 628 0.1
Full report (1 build for telink)
platform target config section bfdbd45 6f8c61a change % change
telink lighting-app tlsr9518adk80d (read/write) 798382 799126 744 0.1
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 558716 628 0.1

@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_support_pr branch from 6f8c61a to eeaaa34 Compare December 6, 2021 08:43
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12552: Size comparison from bfdbd45 to eeaaa34

Increases above 0.2%:

platform target config section bfdbd45 eeaaa34 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 99680 99936 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 94936 95192 256 0.3
lock-app nrf52840dk_nrf52840 rodata 95796 96052 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 91084 91344 260 0.3
pump-app nrf52840dk_nrf52840 rodata 97148 97408 260 0.3
pump-controller-app nrf52840dk_nrf52840 rodata 95288 95544 256 0.3
shell nrf52840dk_nrf52840 rodata 73792 74048 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 68432 68692 260 0.4
text 442548 443460 912 0.2
Increases (18 builds for linux, nrfconnect, telink)
platform target config section bfdbd45 eeaaa34 change % change
linux all-clusters-app debug (read only) 1872825 1872953 128 0.0
.rodata 152117 152245 128 0.1
bridge-app debug+rpc (read only) 1444277 1444389 112 0.0
.rodata 121500 121612 112 0.1
chip-tool debug (read only) 6628165 6628269 104 0.0
.rodata 310776 310880 104 0.0
lighting-app debug+rpc (read only) 1729441 1729569 128 0.0
.rodata 142161 142289 128 0.1
ota-provider-app debug (read only) 1400953 1401065 112 0.0
.rodata 122856 122968 112 0.1
ota-requestor-app debug (read only) 1510209 1510329 120 0.0
.rodata 135600 135720 120 0.1
shell debug (read only) 823449 823577 128 0.0
.rodata 84658 84786 128 0.2
tv-app debug (read only) 2046473 2046577 104 0.0
.rodata 174352 174456 104 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 896031 1152 0.1
rodata 99680 99936 256 0.3
text 605896 606784 888 0.1
nrf52840dk_nrf52840+rpc (read/write) 858255 858967 712 0.1
rodata 91040 91128 88 0.1
text 580892 581520 628 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820790 821958 1168 0.1
rodata 94936 95192 256 0.3
text 536232 537144 912 0.2
lock-app nrf52840dk_nrf52840 (read/write) 866899 868051 1152 0.1
rodata 95796 96052 256 0.3
text 584708 585592 884 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 793050 794222 1172 0.1
rodata 91084 91344 260 0.3
text 515132 516044 912 0.2
pump-app nrf52840dk_nrf52840 (read/write) 871683 872839 1156 0.1
rodata 97148 97408 260 0.3
text 588156 589040 884 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 866079 1152 0.1
rodata 95288 95544 256 0.3
text 583388 584272 884 0.2
shell nrf52840dk_nrf52840 (read/write) 779939 781075 1136 0.1
rodata 73792 74048 256 0.3
text 521948 522832 884 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696138 1172 0.2
rodata 68432 68692 260 0.4
text 442548 443460 912 0.2
telink lighting-app tlsr9518adk80d (read/write) 798382 799126 744 0.1
text 558088 558716 628 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 eeaaa34 change % change
efr32 lighting-app BRD4161A (read only) 758896 758896 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 758888 758888 0 0.0
BRD4161A+rpc (read only) 787544 787544 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 787536 787536 0 0.0
lock-app BRD4161A (read only) 733952 733952 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 733944 733944 0 0.0
window-app BRD4161A (read only) 736224 736224 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 736216 736216 0 0.0
esp32 all-clusters-app c3devkit (read only) 852538 852538 0 0.0
(read/write) 1290914 1290914 0 0.0
.dram0.bss 56352 56352 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169520 0 0.0
.flash.text 852538 852538 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922399 922399 0 0.0
(read/write) 424356 424356 0 0.0
.dram0.bss 61736 61736 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 197324 0 0.0
.flash.text 917015 917015 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731908 731908 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644936 644936 0 0.0
lock-app k32w061+debug (read/write) 622076 622076 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544472 544472 0 0.0
shell k32w061+debug (read/write) 687968 687968 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598744 598744 0 0.0
linux all-clusters-app debug (read only) 1872825 1872953 128 0.0
(read/write) 124336 124336 0 0.0
.bss 50672 50672 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152117 152245 128 0.1
.text 1577602 1577602 0 0.0
bridge-app debug+rpc (read only) 1444277 1444389 112 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121500 121612 112 0.1
.text 1217877 1217877 0 0.0
chip-tool debug (read only) 6628165 6628269 104 0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 310776 310880 104 0.0
.text 5912661 5912661 0 0.0
lighting-app debug+rpc (read only) 1729441 1729569 128 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142161 142289 128 0.1
.text 1444610 1444610 0 0.0
ota-provider-app debug (read only) 1400953 1401065 112 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122856 122968 112 0.1
.text 1173410 1173410 0 0.0
ota-requestor-app debug (read only) 1510209 1510329 120 0.0
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135600 135720 120 0.1
.text 1265970 1265970 0 0.0
shell debug (read only) 823449 823577 128 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84786 128 0.2
.text 631954 631954 0 0.0
tv-app debug (read only) 2046473 2046577 104 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174352 174456 104 0.1
.text 1717378 1717378 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313152 2313152 0 0.0
.bss 179404 179404 0 0.0
.data 5184 5184 0 0.0
.heap 851856 851856 0 0.0
.text 1275728 1275728 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299096 2299096 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261696 1261696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273088 2273088 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235688 1235688 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 896031 1152 0.1
bss 113756 113756 0 0.0
rodata 99680 99936 256 0.3
text 605896 606784 888 0.1
nrf52840dk_nrf52840+rpc (read/write) 858255 858967 712 0.1
bss 110104 110104 0 0.0
rodata 91040 91128 88 0.1
text 580892 581520 628 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820790 821958 1168 0.1
bss 115128 115128 0 0.0
rodata 94936 95192 256 0.3
text 536232 537144 912 0.2
lock-app nrf52840dk_nrf52840 (read/write) 866899 868051 1152 0.1
bss 111016 111016 0 0.0
rodata 95796 96052 256 0.3
text 584708 585592 884 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 793050 794222 1172 0.1
bss 112428 112428 0 0.0
rodata 91084 91344 260 0.3
text 515132 516044 912 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 872839 1156 0.1
bss 110928 110928 0 0.0
rodata 97148 97408 260 0.3
text 588156 589040 884 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 866079 1152 0.1
bss 110808 110808 0 0.0
rodata 95288 95544 256 0.3
text 583388 584272 884 0.2
shell nrf52840dk_nrf52840 (read/write) 779939 781075 1136 0.1
bss 109696 109696 0 0.0
rodata 73792 74048 256 0.3
text 521948 522832 884 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696138 1172 0.2
bss 110680 110680 0 0.0
rodata 68432 68692 260 0.4
text 442548 443460 912 0.2
p6 all-clusters-app default (read/write) 2349448 2349448 0 0.0
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307712 1307712 0 0.0
light-app default (read/write) 2284072 2284072 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242336 1242336 0 0.0
lock-app default (read/write) 2260624 2260624 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218888 1218888 0 0.0
qpg lighting-app qpg6100+debug (read only) 513724 513724 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508404 508404 0 0.0
lock-app qpg6100+debug (read only) 487464 487464 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482144 482144 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798382 799126 744 0.1
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 558716 628 0.1

@woody-apple
Copy link
Contributor

Fast tracking, given this is a platform change by a platform manufacturer (modulo some error code replacements across others).

@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_support_pr branch 3 times, most recently from 9eafd0a to fba36eb Compare December 7, 2021 06:53
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12552: Size comparison from 21392ef to fba36eb

Increases above 0.2%:

platform target config section 21392ef fba36eb change % change
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 99676 99932 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 94936 95192 256 0.3
lock-app nrf52840dk_nrf52840 rodata 95796 96052 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 91084 91340 256 0.3
pump-app nrf52840dk_nrf52840 rodata 97148 97404 256 0.3
pump-controller-app nrf52840dk_nrf52840 rodata 95284 95540 256 0.3
shell nrf52840dk_nrf52840 rodata 73792 74048 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 68432 68692 260 0.4
text 442548 443476 928 0.2
Increases (18 builds for linux, nrfconnect, telink)
platform target config section 21392ef fba36eb change % change
linux all-clusters-app debug (read only) 1902129 1902257 128 0.0
.rodata 154933 155061 128 0.1
bridge-app debug+rpc (read only) 1450789 1450901 112 0.0
.rodata 122692 122804 112 0.1
chip-tool debug (read only) 6661157 6661261 104 0.0
.rodata 334449 334553 104 0.0
lighting-app debug+rpc (read only) 1736569 1736697 128 0.0
.rodata 143281 143409 128 0.1
ota-provider-app debug (read only) 1408089 1408201 112 0.0
.rodata 124078 124190 112 0.1
ota-requestor-app debug (read only) 1512865 1512985 120 0.0
.rodata 136823 136943 120 0.1
shell debug (read only) 823577 823705 128 0.0
.rodata 84754 84882 128 0.2
tv-app debug (read only) 2049985 2050089 104 0.0
.rodata 175436 175540 104 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894699 895867 1168 0.1
rodata 99676 99932 256 0.3
text 605624 606524 900 0.1
nrf52840dk_nrf52840+rpc (read/write) 858075 858803 728 0.1
rodata 91036 91124 88 0.1
text 580620 581264 644 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820598 821798 1200 0.1
rodata 94936 95192 256 0.3
text 535952 536880 928 0.2
lock-app nrf52840dk_nrf52840 (read/write) 867283 868451 1168 0.1
rodata 95796 96052 256 0.3
text 584996 585896 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 793434 794618 1184 0.1
rodata 91084 91340 256 0.3
text 515416 516344 928 0.2
pump-app nrf52840dk_nrf52840 (read/write) 872019 873187 1168 0.1
rodata 97148 97404 256 0.3
text 588396 589296 900 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 865243 866411 1168 0.1
rodata 95284 95540 256 0.3
text 583608 584508 900 0.2
shell nrf52840dk_nrf52840 (read/write) 779939 781091 1152 0.1
rodata 73792 74048 256 0.3
text 521948 522848 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696154 1188 0.2
rodata 68432 68692 260 0.4
text 442548 443476 928 0.2
telink lighting-app tlsr9518adk80d (read/write) 798086 798846 760 0.1
text 557696 558338 642 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 21392ef fba36eb change % change
efr32 lighting-app BRD4161A (read only) 796540 796540 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 796532 796532 0 0.0
BRD4161A+rpc (read only) 824508 824508 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 824500 824500 0 0.0
lock-app BRD4161A (read only) 771224 771224 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 771216 771216 0 0.0
window-app BRD4161A (read only) 773496 773496 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 773488 773488 0 0.0
esp32 all-clusters-app c3devkit (read only) 856134 856134 0 0.0
(read/write) 1298882 1298882 0 0.0
.dram0.bss 61424 61424 0 0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170288 170288 0 0.0
.flash.text 856134 856134 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 959387 959387 0 0.0
(read/write) 443208 443208 0 0.0
.dram0.bss 68776 68776 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208588 208588 0 0.0
.flash.text 954003 954003 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731592 731592 0 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644524 644524 0 0.0
lock-app k32w061+debug (read/write) 622308 622308 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544608 544608 0 0.0
shell k32w061+debug (read/write) 688216 688216 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598896 598896 0 0.0
linux all-clusters-app debug (read only) 1902129 1902257 128 0.0
(read/write) 128712 128712 0 0.0
.bss 54064 54064 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 67968 67968 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 154933 155061 128 0.1
.text 1601666 1601666 0 0.0
bridge-app debug+rpc (read only) 1450789 1450901 112 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 122804 112 0.1
.text 1223029 1223029 0 0.0
chip-tool debug (read only) 6661157 6661261 104 0.0
(read/write) 201512 201512 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160072 160072 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 334449 334553 104 0.0
.text 5918213 5918213 0 0.0
lighting-app debug+rpc (read only) 1736569 1736697 128 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143281 143409 128 0.1
.text 1450450 1450450 0 0.0
ota-provider-app debug (read only) 1408089 1408201 112 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 124190 112 0.1
.text 1179154 1179154 0 0.0
ota-requestor-app debug (read only) 1512865 1512985 120 0.0
(read/write) 78120 78120 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29704 29704 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 136943 120 0.1
.text 1267282 1267282 0 0.0
shell debug (read only) 823577 823705 128 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84882 128 0.2
.text 631986 631986 0 0.0
tv-app debug (read only) 2049985 2050089 104 0.0
(read/write) 320288 320288 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64208 64208 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175436 175540 104 0.1
.text 1719714 1719714 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316272 2316272 0 0.0
.bss 184596 184596 0 0.0
.data 5240 5240 0 0.0
.heap 846608 846608 0 0.0
.text 1278848 1278848 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299968 2299968 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262568 1262568 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894699 895867 1168 0.1
bss 113852 113852 0 0.0
rodata 99676 99932 256 0.3
text 605624 606524 900 0.1
nrf52840dk_nrf52840+rpc (read/write) 858075 858803 728 0.1
bss 110200 110200 0 0.0
rodata 91036 91124 88 0.1
text 580620 581264 644 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820598 821798 1200 0.1
bss 115224 115224 0 0.0
rodata 94936 95192 256 0.3
text 535952 536880 928 0.2
lock-app nrf52840dk_nrf52840 (read/write) 867283 868451 1168 0.1
bss 111112 111112 0 0.0
rodata 95796 96052 256 0.3
text 584996 585896 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 793434 794618 1184 0.1
bss 112524 112524 0 0.0
rodata 91084 91340 256 0.3
text 515416 516344 928 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 872019 873187 1168 0.1
bss 111024 111024 0 0.0
rodata 97148 97404 256 0.3
text 588396 589296 900 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 865243 866411 1168 0.1
bss 110904 110904 0 0.0
rodata 95284 95540 256 0.3
text 583608 584508 900 0.2
shell nrf52840dk_nrf52840 (read/write) 779939 781091 1152 0.1
bss 109696 109696 0 0.0
rodata 73792 74048 256 0.3
text 521948 522848 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696154 1188 0.2
bss 110680 110680 0 0.0
rodata 68432 68692 260 0.4
text 442548 443476 928 0.2
p6 all-clusters-app default (read/write) 2352208 2352208 0 0.0
.bss 110868 110868 0 0.0
.data 2520 2520 0 0.0
.heap 919952 919952 0 0.0
.text 1310472 1310472 0 0.0
light-app default (read/write) 2283256 2283256 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1241520 1241520 0 0.0
lock-app default (read/write) 2259424 2259424 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1217688 1217688 0 0.0
qpg lighting-app qpg6100+debug (read only) 513300 513300 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507980 507980 0 0.0
lock-app qpg6100+debug (read only) 487604 487604 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482284 482284 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798086 798846 760 0.1
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557696 558338 642 0.1

@kkasperczyk-no
[zephyr] Added support for getting GeneralDiagnostics attributes
d5fd8e3 
nrfconnect/Zephyr platform doesn't support get methods for
GeneralDiagnostics attributes

* Added methods for getting RebootCount, NetworkInterfaces
and BootReasons
* Added to the InetIterator methods allowing to get interface
type and hardware address using Zephyr API
* Added BootReasonType to the DiagnosticDataProvider to remove
dependency between platform and auto-generated code
@kkasperczyk-no kkasperczyk-no force-pushed the diagnostic_cluster_support_pr branch from fba36eb to d5fd8e3 Compare December 7, 2021 10:47
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12552: Size comparison from f647393 to d5fd8e3

Increases above 0.2%:

platform target config section f647393 d5fd8e3 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 rodata 99676 99932 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 94936 95192 256 0.3
lock-app nrf52840dk_nrf52840 rodata 95796 96052 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 91084 91340 256 0.3
pump-app nrf52840dk_nrf52840 rodata 97148 97404 256 0.3
pump-controller-app nrf52840dk_nrf52840 rodata 95284 95540 256 0.3
shell nrf52840dk_nrf52840 rodata 73792 74048 256 0.3
nrf5340dk_nrf5340_cpuapp rodata 68432 68692 260 0.4
text 442548 443476 928 0.2
Increases (18 builds for linux, nrfconnect, telink)
platform target config section f647393 d5fd8e3 change % change
linux all-clusters-app debug (read only) 1902129 1902257 128 0.0
.rodata 154933 155061 128 0.1
bridge-app debug+rpc (read only) 1450789 1450901 112 0.0
.rodata 122692 122804 112 0.1
chip-tool debug (read only) 6680117 6680221 104 0.0
.rodata 334449 334553 104 0.0
lighting-app debug+rpc (read only) 1736569 1736697 128 0.0
.rodata 143281 143409 128 0.1
ota-provider-app debug (read only) 1408089 1408201 112 0.0
.rodata 124078 124190 112 0.1
ota-requestor-app debug (read only) 1512865 1512985 120 0.0
.rodata 136823 136943 120 0.1
shell debug (read only) 823577 823705 128 0.0
.rodata 84754 84882 128 0.2
tv-app debug (read only) 2049985 2050089 104 0.0
.rodata 175436 175540 104 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894699 895867 1168 0.1
rodata 99676 99932 256 0.3
text 605624 606524 900 0.1
nrf52840dk_nrf52840+rpc (read/write) 858075 858803 728 0.1
rodata 91036 91124 88 0.1
text 580620 581264 644 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820598 821798 1200 0.1
rodata 94936 95192 256 0.3
text 535952 536880 928 0.2
lock-app nrf52840dk_nrf52840 (read/write) 867283 868451 1168 0.1
rodata 95796 96052 256 0.3
text 584996 585896 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 793434 794618 1184 0.1
rodata 91084 91340 256 0.3
text 515416 516344 928 0.2
pump-app nrf52840dk_nrf52840 (read/write) 872019 873187 1168 0.1
rodata 97148 97404 256 0.3
text 588396 589296 900 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 865243 866411 1168 0.1
rodata 95284 95540 256 0.3
text 583608 584508 900 0.2
shell nrf52840dk_nrf52840 (read/write) 779939 781091 1152 0.1
rodata 73792 74048 256 0.3
text 521948 522848 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696154 1188 0.2
rodata 68432 68692 260 0.4
text 442548 443476 928 0.2
telink lighting-app tlsr9518adk80d (read/write) 798086 798846 760 0.1
text 557696 558338 642 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f647393 d5fd8e3 change % change
efr32 lighting-app BRD4161A (read only) 796540 796540 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 796532 796532 0 0.0
BRD4161A+rpc (read only) 824508 824508 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 824500 824500 0 0.0
lock-app BRD4161A (read only) 771224 771224 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 771216 771216 0 0.0
window-app BRD4161A (read only) 773496 773496 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 773488 773488 0 0.0
esp32 all-clusters-app c3devkit (read only) 856134 856134 0 0.0
(read/write) 1298882 1298882 0 0.0
.dram0.bss 61424 61424 0 0.0
.dram0.data 14132 14132 0 0.0
.flash.rodata 170288 170288 0 0.0
.flash.text 856134 856134 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 959387 959387 0 0.0
(read/write) 443208 443208 0 0.0
.dram0.bss 68776 68776 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 208588 208588 0 0.0
.flash.text 954003 954003 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731592 731592 0 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644524 644524 0 0.0
lock-app k32w061+debug (read/write) 622308 622308 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544608 544608 0 0.0
shell k32w061+debug (read/write) 688216 688216 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598896 598896 0 0.0
linux all-clusters-app debug (read only) 1902129 1902257 128 0.0
(read/write) 128712 128712 0 0.0
.bss 54064 54064 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 67968 67968 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 154933 155061 128 0.1
.text 1601666 1601666 0 0.0
bridge-app debug+rpc (read only) 1450789 1450901 112 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 122692 122804 112 0.1
.text 1223029 1223029 0 0.0
chip-tool debug (read only) 6680117 6680221 104 0.0
(read/write) 201512 201512 0 0.0
.bss 34728 34728 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160072 160072 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 334449 334553 104 0.0
.text 5937173 5937173 0 0.0
lighting-app debug+rpc (read only) 1736569 1736697 128 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 143281 143409 128 0.1
.text 1450450 1450450 0 0.0
ota-provider-app debug (read only) 1408089 1408201 112 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124078 124190 112 0.1
.text 1179154 1179154 0 0.0
ota-requestor-app debug (read only) 1512865 1512985 120 0.0
(read/write) 78120 78120 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29704 29704 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136823 136943 120 0.1
.text 1267282 1267282 0 0.0
shell debug (read only) 823577 823705 128 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84754 84882 128 0.2
.text 631986 631986 0 0.0
tv-app debug (read only) 2049985 2050089 104 0.0
(read/write) 320288 320288 0 0.0
.bss 247480 247480 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64208 64208 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175436 175540 104 0.1
.text 1719714 1719714 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316272 2316272 0 0.0
.bss 184596 184596 0 0.0
.data 5240 5240 0 0.0
.heap 846608 846608 0 0.0
.text 1278848 1278848 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299968 2299968 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262568 1262568 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894699 895867 1168 0.1
bss 113852 113852 0 0.0
rodata 99676 99932 256 0.3
text 605624 606524 900 0.1
nrf52840dk_nrf52840+rpc (read/write) 858075 858803 728 0.1
bss 110200 110200 0 0.0
rodata 91036 91124 88 0.1
text 580620 581264 644 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820598 821798 1200 0.1
bss 115224 115224 0 0.0
rodata 94936 95192 256 0.3
text 535952 536880 928 0.2
lock-app nrf52840dk_nrf52840 (read/write) 867283 868451 1168 0.1
bss 111112 111112 0 0.0
rodata 95796 96052 256 0.3
text 584996 585896 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 793434 794618 1184 0.1
bss 112524 112524 0 0.0
rodata 91084 91340 256 0.3
text 515416 516344 928 0.2
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 872019 873187 1168 0.1
bss 111024 111024 0 0.0
rodata 97148 97404 256 0.3
text 588396 589296 900 0.2
pump-controller-app nrf52840dk_nrf52840 (read/write) 865243 866411 1168 0.1
bss 110904 110904 0 0.0
rodata 95284 95540 256 0.3
text 583608 584508 900 0.2
shell nrf52840dk_nrf52840 (read/write) 779939 781091 1152 0.1
bss 109696 109696 0 0.0
rodata 73792 74048 256 0.3
text 521948 522848 900 0.2
nrf5340dk_nrf5340_cpuapp (read/write) 694966 696154 1188 0.2
bss 110680 110680 0 0.0
rodata 68432 68692 260 0.4
text 442548 443476 928 0.2
p6 all-clusters-app default (read/write) 2352208 2352208 0 0.0
.bss 110868 110868 0 0.0
.data 2520 2520 0 0.0
.heap 919952 919952 0 0.0
.text 1310472 1310472 0 0.0
light-app default (read/write) 2283256 2283256 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1241520 1241520 0 0.0
lock-app default (read/write) 2259424 2259424 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1217688 1217688 0 0.0
qpg lighting-app qpg6100+debug (read only) 513300 513300 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507980 507980 0 0.0
lock-app qpg6100+debug (read only) 487604 487604 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482284 482284 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798086 798846 760 0.1
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557696 558338 642 0.1

@Damian-Nordic Damian-Nordic merged commit 1b24137 into project-chip:master Dec 7, 2021
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Dec 7, 2021
@kpschoedel
[Inet] InetIterator::GetHardwareAddress for LwIP
f9cc19f 
#### Problem

1b24137 (project-chip#12552) added `InetIterator::GetHardwareAddress()`,
with an implementation for Zephyr and stubs for other builds.

#### Change overview

Implement `GetHardwareAddress()` for LwIP builds.

(For sockets builds, there is no cross-platform access to the
hardware MAC. Linux could use `SIOCGIFHWADDR`.)

#### Testing

CI (test from project-chip#12552)
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Dec 7, 2021
@kpschoedel
[Inet] InetIterator::GetHardwareAddress for LwIP
89cf0a2 
#### Problem

1b24137 (project-chip#12552) added `InetIterator::GetHardwareAddress()`,
with an implementation for Zephyr and stubs for other builds.

#### Change overview

Implement `GetHardwareAddress()` for LwIP builds.

(For sockets builds, there is no cross-platform access to the
hardware MAC. Linux could use `SIOCGIFHWADDR`.)

#### Testing

CI (test from project-chip#12552)
@kpschoedel kpschoedel mentioned this pull request Dec 7, 2021
Merged
andy31415 pushed a commit that referenced this pull request Dec 8, 2021
@kpschoedel
[Inet] InetIterator::GetHardwareAddress for LwIP (#12687)
47fceae 
* [Inet] InetIterator::GetHardwareAddress for LwIP

#### Problem

1b24137 (#12552) added `InetIterator::GetHardwareAddress()`,
with an implementation for Zephyr and stubs for other builds.

#### Change overview

Implement `GetHardwareAddress()` for LwIP builds.

(For sockets builds, there is no cross-platform access to the
hardware MAC. Linux could use `SIOCGIFHWADDR`.)

#### Testing

CI (test from #12552)

* fix buffer size check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpschoedel kpschoedel kpschoedel left review comments

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app config efr32 esp32 fast track inet linux platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kkasperczyk-no @woody-apple @tcarmelveilleux @andy31415 @LuDuda @kpschoedel @jmartinez-silabs @Damian-Nordic