[OTA] Integrate ota-requestor cluster as normal cluster in data model build flow #13256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
ab7d6c4 to
d07bf85
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda and
lzgrablic02
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
e3857f1 to
d4e33e6
Compare
|
PR #13256: Size comparison from a841e21 to f522bbf Decreases (1 build for k32w)
Full report (6 builds for k32w, qpg, telink)
|
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
f522bbf to
2cad632
Compare
|
PR #13256: Size comparison from a841e21 to 2cad632 Increases above 0.2%:
Increases (3 builds for qpg)
Decreases (5 builds for esp32, k32w, mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
Update to all-clusters part required due to issues in ZAP (client/cluster can't coexist) - see #13437 #13246. |
dhrishi
reviewed
Jan 11, 2022
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
2cad632 to
c383a56
Compare
|
PR #13256: Size comparison from b7afede to c383a56 Increases above 0.2%:
Increases (4 builds for k32w, qpg)
Decreases (2 builds for linux, p6)
Full report (24 builds for efr32, k32w, linux, nrfconnect, p6, qpg)
|
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
c383a56 to
7603898
Compare
|
PR #13256: Size comparison from 781f540 to 7603898 Increases above 0.2%:
Increases (3 builds for qpg)
Decreases (5 builds for esp32, k32w, mbed, p6)
Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
7603898 to
043e95f
Compare
|
PR #13256: Size comparison from f878e4a to 043e95f Increases above 0.2%:
Increases (4 builds for k32w, qpg)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
* Adjust apps with a stub (all-clusters-app, ota-requestor-app, shell)
tima-q
force-pushed
the
ota/use_data_model_build
branch
from
043e95f to
bd0b3c0
Compare
|
PR #13256: Size comparison from 6c6f438 to bd0b3c0 Increases above 0.2%:
Increases (5 builds for mbed, p6, qpg)
Decreases (1 build for k32w)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
shubhamdp
approved these changes
Jan 12, 2022
dhrishi
approved these changes
Jan 12, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…ct-chip#13256) * Adjust apps with a stub (all-clusters-app, ota-requestor-app, shell)
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
…ct-chip#13256) * Adjust apps with a stub (all-clusters-app, ota-requestor-app, shell)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building the ota-requestor cluster is currently done by directly including the sources from src/app/clusters at application level.
This generates code duplication in the .gn/cmake files when trying to add the requestor to another application.
Also ota-requestor-stubs with the same functionality as the general cluster exist.
Change overview
Introducing ota-requestor server in gn and cmake builds same way as other cluster are handled.
Added to the list parsed in zap_cluster_list.py
Adjusted chip_data_model.gni to select non-default sources of ota-requestor-server
Adjust all-clusters-app and ota-requestor-app
changes to all-clusters similar to [ESP32] Init OTA requestor in all-clusters-app #13246, enabling provider-client to be able to use requestor-server. Opposed to that PR, keeping the ota-provider-server intact in this PR.
Adjust tests to cope with ota-provider client that is added to all-clusters-app
This is preparation to add a ota-requestor-server to the QPG lighting-app.
This PR holds the generic changes.
Note - CMake based builds of all-clusters-app are not using the default mechanism to include clusters. As it could be a conscious choice, leaving maintainers to update that further.
Testing
** AnnounceOTAProvider triggered with chip-tool, processed at requestor side, OTAQuery and subsequent download seen.