Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Add OTARequstor to all-clusters-app #12360

Merged
merged 3 commits into from
Dec 6, 2021
Merged

ESP32: Add OTARequstor to all-clusters-app #12360

merged 3 commits into from
Dec 6, 2021

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Nov 30, 2021

Problem

Add ota commands to chip shell for ESP32 platform in all-clusters-app

Change overview

  1. Enable OTAProvider client cluster in all-clusters-app
  2. Add ota commands to chip shell for esp32 platform in all-clusters-app

Testing

Test on ESP32C3 with a Linux OTAProvider

  1. Input 'matter ota query 1 {Provider-NodeId} 0 {Provider-IPAddr} 5540' to query the image
  2. Apply the image and reboot, then the new image will start to run.

@todo
Copy link

todo bot commented Nov 30, 2021

Process/skip the Matter OTA header

connectedhomeip/src/lib/shell/commands/DFUManager_esp32.h

Lines 102 to 112 in a8a90fc

// TODO: Process/skip the Matter OTA header
OTAUpdater::GetInstance().Write(reinterpret_cast<const void *>(event.blockdata.Data),
event.blockdata.Length);
if (event.blockdata.IsEof)
{
err = mTransfer.PrepareBlockAck();
VerifyOrReturn(err == CHIP_NO_ERROR, ChipLogError(BDX, "PrepareBlockAck failed: %" CHIP_ERROR_FORMAT, err.Format()));
mIsTransferComplete = true;
}
else
{

This comment was generated by todo based on a TODO comment in a8a90fc in #12360. cc @wqx6.

@restyled-io restyled-io bot mentioned this pull request Nov 30, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12360: Size comparison from dc10c82 to 9ce710c

Increases above 0.2%:

platform target config section dc10c823 9ce710c change % change
esp32 all-clusters-app c3devkit .dram0.bss 58824 60744 1920 3.3
m5stack (read only) 910791 942575 31784 3.5
(read/write) 424312 438912 14600 3.4
.dram0.bss 64224 68128 3904 6.1
.flash.rodata 194808 205224 10416 5.3
.flash.text 905407 937191 31784 3.5
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 181892 183804 1912 1.1
Increases (5 builds for esp32, linux, mbed)
platform target config section dc10c823 9ce710c change % change
esp32 all-clusters-app c3devkit (read/write) 1225090 1226546 1456 0.1
.dram0.bss 58824 60744 1920 3.3
m5stack (read only) 910791 942575 31784 3.5
(read/write) 424312 438912 14600 3.4
.dram0.bss 64224 68128 3904 6.1
.flash.rodata 194808 205224 10416 5.3
.flash.text 905407 937191 31784 3.5
.iram0.text 122943 123223 280 0.2
linux all-clusters-app debug .data.rel.ro 66128 66160 32 0.0
chip-tool debug (read only) 6528285 6528445 160 0.0
.rodata 304984 305016 32 0.0
.text 5816693 5816821 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 181892 183804 1912 1.1
.data 5168 5176 8 0.2
Decreases (4 builds for esp32, linux, mbed, p6)
platform target config section dc10c823 9ce710c change % change
esp32 all-clusters-app c3devkit (read only) 839114 837818 -1296 -0.2
.flash.rodata 166968 166504 -464 -0.3
.flash.text 839114 837818 -1296 -0.2
linux all-clusters-app debug (read only) 1797065 1788513 -8552 -0.5
.bss 53456 53424 -32 -0.1
.rodata 145909 145621 -288 -0.2
.text 1510818 1502530 -8288 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2299376 2297768 -1608 -0.1
.heap 849384 847464 -1920 -0.2
.text 1261976 1260368 -1608 -0.1
p6 all-clusters-app default (read/write) 2320840 2318776 -2064 -0.1
.text 1279104 1277040 -2064 -0.2
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dc10c823 9ce710c change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
esp32 all-clusters-app c3devkit (read only) 839114 837818 -1296 -0.2
(read/write) 1225090 1226546 1456 0.1
.dram0.bss 58824 60744 1920 3.3
.dram0.data 14036 14036 0 0.0
.flash.rodata 166968 166504 -464 -0.3
.flash.text 839114 837818 -1296 -0.2
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910791 942575 31784 3.5
(read/write) 424312 438912 14600 3.4
.dram0.bss 64224 68128 3904 6.1
.dram0.data 34000 34000 0 0.0
.flash.rodata 194808 205224 10416 5.3
.flash.text 905407 937191 31784 3.5
.iram0.text 122943 123223 280 0.2
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1788513 -8552 -0.5
(read/write) 125992 125992 0 0.0
.bss 53456 53424 -32 -0.1
.data 1104 1104 0 0.0
.data.rel.ro 66128 66160 32 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145621 -288 -0.2
.text 1510818 1502530 -8288 -0.5
bridge-app debug+rpc (read only) 1367285 1367285 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1147589 0 0.0
chip-tool debug (read only) 6528285 6528445 160 0.0
(read/write) 199760 199760 0 0.0
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 305016 32 0.0
.text 5816693 5816821 128 0.0
lighting-app debug+rpc (read only) 1651097 1651097 0 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1373906 0 0.0
ota-provider-app debug (read only) 1327881 1327881 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1106514 0 0.0
ota-requestor-app debug (read only) 1427937 1427937 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1191186 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944817 1944817 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1626946 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299376 2297768 -1608 -0.1
.bss 181892 183804 1912 1.1
.data 5168 5176 8 0.2
.heap 849384 847464 -1920 -0.2
.text 1261976 1260368 -1608 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284104 2284104 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246704 1246704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257200 2257200 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219800 1219800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 880507 880507 0 0.0
bss 113396 113396 0 0.0
rodata 98540 98540 0 0.0
text 593036 593036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 843883 843883 0 0.0
bss 109744 109744 0 0.0
rodata 89900 89900 0 0.0
text 568032 568032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806422 806422 0 0.0
bss 114768 114768 0 0.0
rodata 93800 93800 0 0.0
text 523376 523376 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 851335 851335 0 0.0
bss 110432 110432 0 0.0
rodata 94280 94280 0 0.0
text 571288 571288 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 777518 777518 0 0.0
bss 111844 111844 0 0.0
rodata 89568 89568 0 0.0
text 501720 501720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 857379 857379 0 0.0
bss 110568 110568 0 0.0
rodata 96012 96012 0 0.0
text 575356 575356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850459 0 0.0
bss 110448 110448 0 0.0
rodata 94148 94148 0 0.0
text 570416 570416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779903 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694946 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442528 0 0.0
p6 all-clusters-app default (read/write) 2320840 2318776 -2064 -0.1
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279104 1277040 -2064 -0.2
light-app default (read/write) 2256624 2256624 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214888 1214888 0 0.0
lock-app default (read/write) 2231984 2231984 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190248 1190248 0 0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@wqx6 wqx6 force-pushed the add_ota_requestor_all_cluster_app branch from 9ce710c to 9e8ffba Compare December 3, 2021 03:05
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12360: Size comparison from c8e8696 to 9e8ffba

Full report (7 builds for k32w, qpg, telink)
platform target config section c8e8696 9e8ffba change % change
k32w lighting-app k32w061+se05x+release (read/write) 728688 728688 0 0.0
.bss 79304 79304 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 617672 617672 0 0.0
.bss 69744 69744 0 0.0
.data 1824 1824 0 0.0
.text 540304 540304 0 0.0
shell k32w061+debug (read/write) 683588 683588 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594592 594592 0 0.0
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80264 80264 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 483288 483288 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79176 79176 0 0.0
.data 916 916 0 0.0
.text 477968 477968 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794546 794546 0 0.0
bss 80328 80328 0 0.0
noinit 37160 37160 0 0.0
text 554526 554526 0 0.0

@wqx6 wqx6 force-pushed the add_ota_requestor_all_cluster_app branch from 9e8ffba to 513bd8c Compare December 3, 2021 03:35
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR #12360: Size comparison from c8e8696 to 513bd8c

Full report (4 builds for qpg, telink)
platform target config section c8e8696 513bd8c change % change
qpg lighting-app qpg6100+debug (read only) 510480 510480 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80264 80264 0 0.0
.data 964 964 0 0.0
.text 505160 505160 0 0.0
lock-app qpg6100+debug (read only) 483288 483288 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79176 79176 0 0.0
.data 916 916 0 0.0
.text 477968 477968 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794546 794546 0 0.0
bss 80328 80328 0 0.0
noinit 37160 37160 0 0.0
text 554526 554526 0 0.0

@wqx6 wqx6 force-pushed the add_ota_requestor_all_cluster_app branch from 513bd8c to a8f4b58 Compare December 3, 2021 04:00
@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

PR #12360: Size comparison from f111727 to a8f4b58

Increases above 0.2%:

platform target config section f111727 a8f4b58 change % change
esp32 all-clusters-app c3devkit .dram0.bss 56576 58496 1920 3.4
m5stack (read only) 918227 950011 31784 3.5
(read/write) 422820 437428 14608 3.5
.dram0.bss 61960 65864 3904 6.3
.flash.rodata 195564 205988 10424 5.3
.flash.text 912843 944627 31784 3.5
.iram0.text 122943 123223 280 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179636 181548 1912 1.1
Increases (5 builds for esp32, linux, mbed)
platform target config section f111727 a8f4b58 change % change
esp32 all-clusters-app c3devkit (read/write) 1223842 1225282 1440 0.1
.dram0.bss 56576 58496 1920 3.4
m5stack (read only) 918227 950011 31784 3.5
(read/write) 422820 437428 14608 3.5
.dram0.bss 61960 65864 3904 6.3
.flash.rodata 195564 205988 10424 5.3
.flash.text 912843 944627 31784 3.5
.iram0.text 122943 123223 280 0.2
linux all-clusters-app debug .data.rel.ro 67088 67120 32 0.0
chip-tool debug (read only) 6622533 6622693 160 0.0
.rodata 307640 307672 32 0.0
.text 5904133 5904261 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179636 181548 1912 1.1
Decreases (4 builds for esp32, linux, mbed, p6)
platform target config section f111727 a8f4b58 change % change
esp32 all-clusters-app c3devkit (read only) 847818 846538 -1280 -0.2
.flash.rodata 167760 167280 -480 -0.3
.flash.text 847818 846538 -1280 -0.2
linux all-clusters-app debug (read only) 1848081 1839673 -8408 -0.5
.bss 50896 50864 -32 -0.1
.rodata 148501 148213 -288 -0.2
.text 1556690 1548546 -8144 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2309224 2307624 -1600 -0.1
.heap 851624 849712 -1912 -0.2
.text 1271800 1270200 -1600 -0.1
p6 all-clusters-app default (read/write) 2339504 2337456 -2048 -0.1
.text 1297768 1295720 -2048 -0.2
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f111727 a8f4b58 change % change
efr32 lighting-app BRD4161A (read only) 751536 751536 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751528 751528 0 0.0
BRD4161A+rpc (read only) 780216 780216 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780208 780208 0 0.0
lock-app BRD4161A (read only) 725392 725392 0 0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725384 725384 0 0.0
window-app BRD4161A (read only) 728704 728704 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728696 728696 0 0.0
esp32 all-clusters-app c3devkit (read only) 847818 846538 -1280 -0.2
(read/write) 1223842 1225282 1440 0.1
.dram0.bss 56576 58496 1920 3.4
.dram0.data 14052 14052 0 0.0
.flash.rodata 167760 167280 -480 -0.3
.flash.text 847818 846538 -1280 -0.2
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918227 950011 31784 3.5
(read/write) 422820 437428 14608 3.5
.dram0.bss 61960 65864 3904 6.3
.dram0.data 34016 34016 0 0.0
.flash.rodata 195564 205988 10424 5.3
.flash.text 912843 944627 31784 3.5
.iram0.text 122943 123223 280 0.2
k32w lighting-app k32w061+se05x+release (read/write) 728716 728716 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641744 641744 0 0.0
lock-app k32w061+debug (read/write) 617700 617700 0 0.0
.bss 69752 69752 0 0.0
.data 1824 1824 0 0.0
.text 540324 540324 0 0.0
shell k32w061+debug (read/write) 683608 683608 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594612 594612 0 0.0
linux all-clusters-app debug (read only) 1848081 1839673 -8408 -0.5
(read/write) 124520 124520 0 0.0
.bss 50896 50864 -32 -0.1
.data 1120 1120 0 0.0
.data.rel.ro 67088 67120 32 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 148501 148213 -288 -0.2
.text 1556690 1548546 -8144 -0.5
bridge-app debug+rpc (read only) 1426261 1426261 0 0.0
(read/write) 74616 74616 0 0.0
.bss 36240 36240 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 120652 120652 0 0.0
.text 1200709 1200709 0 0.0
chip-tool debug (read only) 6622533 6622693 160 0.0
(read/write) 202376 202376 0 0.0
.bss 34504 34504 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161208 161208 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 307640 307672 32 0.0
.text 5904133 5904261 128 0.0
lighting-app debug+rpc (read only) 1710801 1710801 0 0.0
(read/write) 107648 107648 0 0.0
.bss 41936 41936 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 140721 140721 0 0.0
.text 1427410 1427410 0 0.0
ota-provider-app debug (read only) 1386329 1386329 0 0.0
(read/write) 72816 72816 0 0.0
.bss 38816 38816 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 121448 121448 0 0.0
.text 1160194 1160194 0 0.0
ota-requestor-app debug (read only) 1490137 1490137 0 0.0
(read/write) 76784 76784 0 0.0
.bss 40960 40960 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29592 29592 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 133776 133776 0 0.0
.text 1247666 1247666 0 0.0
shell debug (read only) 819625 819625 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3512 3512 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83570 83570 0 0.0
.text 629314 629314 0 0.0
tv-app debug (read only) 2020441 2020441 0 0.0
(read/write) 320000 320000 0 0.0
.bss 247224 247224 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64200 64200 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 173608 173608 0 0.0
.text 1692354 1692354 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309224 2307624 -1600 -0.1
.bss 179636 181548 1912 1.1
.data 5184 5184 0 0.0
.heap 851624 849712 -1912 -0.2
.text 1271800 1270200 -1600 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295616 2295616 0 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258216 1258216 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268648 2268648 0 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231248 1231248 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046960 2046960 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009560 1009560 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891475 891475 0 0.0
bss 113756 113756 0 0.0
rodata 99428 99428 0 0.0
text 602740 602740 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854851 854851 0 0.0
bss 110104 110104 0 0.0
rodata 90788 90788 0 0.0
text 577736 577736 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817370 817370 0 0.0
bss 115128 115128 0 0.0
rodata 94684 94684 0 0.0
text 533076 533076 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862331 862331 0 0.0
bss 110792 110792 0 0.0
rodata 95164 95164 0 0.0
text 580992 580992 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788486 788486 0 0.0
bss 112204 112204 0 0.0
rodata 90456 90456 0 0.0
text 511420 511420 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868347 868347 0 0.0
bss 110928 110928 0 0.0
rodata 96900 96900 0 0.0
text 585056 585056 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861411 861411 0 0.0
bss 110808 110808 0 0.0
rodata 95036 95036 0 0.0
text 580116 580116 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779891 779891 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694934 694934 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339504 2337456 -2048 -0.1
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1297768 1295720 -2048 -0.2
light-app default (read/write) 2278856 2278856 0 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237120 1237120 0 0.0
lock-app default (read/write) 2254208 2254208 0 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212472 1212472 0 0.0
qpg lighting-app qpg6100+debug (read only) 510500 510500 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505180 505180 0 0.0
lock-app qpg6100+debug (read only) 483308 483308 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79184 79184 0 0.0
.data 916 916 0 0.0
.text 477988 477988 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794566 794566 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554526 554526 0 0.0

@wqx6 wqx6 force-pushed the add_ota_requestor_all_cluster_app branch from a8f4b58 to 4a859c6 Compare December 6, 2021 04:30
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12360: Size comparison from 186c004 to 4a859c6

Increases above 0.2%:

platform target config section 186c004 4a859c6 change % change
esp32 all-clusters-app c3devkit .dram0.bss 55352 57272 1920 3.5
m5stack (read only) 918319 950655 32336 3.5
(read/write) 421756 436356 14600 3.5
.dram0.bss 60736 64640 3904 6.4
.flash.rodata 195724 206140 10416 5.3
.flash.text 912935 945271 32336 3.5
.iram0.text 122943 123223 280 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 178404 180316 1912 1.1
Increases (5 builds for esp32, linux, mbed)
platform target config section 186c004 4a859c6 change % change
esp32 all-clusters-app c3devkit (read/write) 1222786 1224234 1448 0.1
.dram0.bss 55352 57272 1920 3.5
m5stack (read only) 918319 950655 32336 3.5
(read/write) 421756 436356 14600 3.5
.dram0.bss 60736 64640 3904 6.4
.flash.rodata 195724 206140 10416 5.3
.flash.text 912935 945271 32336 3.5
.iram0.text 122943 123223 280 0.2
linux all-clusters-app debug .data.rel.ro 67104 67136 32 0.0
.rodata 151285 151637 352 0.2
chip-tool debug (read only) 6619645 6619757 112 0.0
.text 5905173 5905285 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 178404 180316 1912 1.1
.data 5184 5192 8 0.2
Decreases (4 builds for esp32, linux, mbed, p6)
platform target config section 186c004 4a859c6 change % change
esp32 all-clusters-app c3devkit (read only) 847922 846642 -1280 -0.2
.flash.rodata 167920 167448 -472 -0.3
.flash.text 847922 846642 -1280 -0.2
linux all-clusters-app debug (read only) 1851521 1843769 -7752 -0.4
.bss 49680 49648 -32 -0.1
.text 1557154 1549026 -8128 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2307096 2305560 -1536 -0.1
.heap 852856 850936 -1920 -0.2
.text 1269672 1268136 -1536 -0.1
p6 all-clusters-app default (read/write) 2340160 2338096 -2064 -0.1
.text 1298424 1296360 -2064 -0.2
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 186c004 4a859c6 change % change
efr32 lighting-app BRD4161A (read only) 751672 751672 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751664 751664 0 0.0
BRD4161A+rpc (read only) 780344 780344 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780336 780336 0 0.0
lock-app BRD4161A (read only) 726496 726496 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726488 726488 0 0.0
window-app BRD4161A (read only) 729000 729000 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728992 728992 0 0.0
esp32 all-clusters-app c3devkit (read only) 847922 846642 -1280 -0.2
(read/write) 1222786 1224234 1448 0.1
.dram0.bss 55352 57272 1920 3.5
.dram0.data 14052 14052 0 0.0
.flash.rodata 167920 167448 -472 -0.3
.flash.text 847922 846642 -1280 -0.2
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918319 950655 32336 3.5
(read/write) 421756 436356 14600 3.5
.dram0.bss 60736 64640 3904 6.4
.dram0.data 34016 34016 0 0.0
.flash.rodata 195724 206140 10416 5.3
.flash.text 912935 945271 32336 3.5
.iram0.text 122943 123223 280 0.2
k32w lighting-app k32w061+se05x+release (read/write) 728696 728696 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 641724 0 0.0
lock-app k32w061+debug (read/write) 618736 618736 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 541132 0 0.0
shell k32w061+debug (read/write) 684644 684644 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 595420 0 0.0
linux all-clusters-app debug (read only) 1851521 1843769 -7752 -0.4
(read/write) 123344 123344 0 0.0
.bss 49680 49648 -32 -0.1
.data 1120 1120 0 0.0
.data.rel.ro 67104 67136 32 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 151285 151637 352 0.2
.text 1557154 1549026 -8128 -0.5
bridge-app debug+rpc (read only) 1432645 1432645 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121948 121948 0 0.0
.text 1205797 1205797 0 0.0
chip-tool debug (read only) 6619645 6619757 112 0.0
(read/write) 199688 199688 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158456 158456 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 309912 309912 0 0.0
.text 5905173 5905285 112 0.0
lighting-app debug+rpc (read only) 1717761 1717761 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142577 142577 0 0.0
.text 1432514 1432514 0 0.0
ota-provider-app debug (read only) 1393289 1393289 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122792 122792 0 0.0
.text 1165810 1165810 0 0.0
ota-requestor-app debug (read only) 1502561 1502561 0 0.0
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135504 135504 0 0.0
.text 1258418 1258418 0 0.0
shell debug (read only) 823129 823129 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84338 84338 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2031625 2031625 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175344 175344 0 0.0
.text 1701538 1701538 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307096 2305560 -1536 -0.1
.bss 178404 180316 1912 1.1
.data 5184 5192 8 0.2
.heap 852856 850936 -1920 -0.2
.text 1269672 1268136 -1536 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2296296 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1258896 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270288 2270288 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232888 1232888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 891715 0 0.0
bss 113756 113756 0 0.0
rodata 99588 99588 0 0.0
text 602824 602824 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 855091 855091 0 0.0
bss 110104 110104 0 0.0
rodata 90948 90948 0 0.0
text 577820 577820 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817610 817610 0 0.0
bss 115128 115128 0 0.0
rodata 94844 94844 0 0.0
text 533156 533156 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 863639 863639 0 0.0
bss 111016 111016 0 0.0
rodata 95704 95704 0 0.0
text 581540 581540 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789794 789794 0 0.0
bss 112428 112428 0 0.0
rodata 90996 90996 0 0.0
text 511964 511964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 868523 0 0.0
bss 110928 110928 0 0.0
rodata 97060 97060 0 0.0
text 585080 585080 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 861763 0 0.0
bss 110808 110808 0 0.0
rodata 95196 95196 0 0.0
text 580312 580312 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2340160 2338096 -2064 -0.1
.bss 106596 106596 0 0.0
.data 2464 2464 0 0.0
.heap 924280 924280 0 0.0
.text 1298424 1296360 -2064 -0.2
light-app default (read/write) 2279680 2279680 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1237944 1237944 0 0.0
lock-app default (read/write) 2255984 2255984 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214248 1214248 0 0.0
qpg lighting-app qpg6100+debug (read only) 510464 510464 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505144 505144 0 0.0
lock-app qpg6100+debug (read only) 484132 484132 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478812 478812 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794746 794746 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554540 554540 0 0.0

@wqx6 wqx6 force-pushed the add_ota_requestor_all_cluster_app branch from 4a859c6 to 94567cd Compare December 6, 2021 09:54
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12360: Size comparison from bfdbd45 to 94567cd

Increases above 0.2%:

platform target config section bfdbd45 94567cd change % change
esp32 all-clusters-app c3devkit .dram0.bss 56352 58272 1920 3.4
m5stack (read only) 922399 954835 32436 3.5
(read/write) 424356 438964 14608 3.4
.dram0.bss 61736 65640 3904 6.3
.flash.rodata 197324 207748 10424 5.3
.flash.text 917015 949451 32436 3.5
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179404 181316 1912 1.1
Increases (5 builds for esp32, linux, mbed)
platform target config section bfdbd45 94567cd change % change
esp32 all-clusters-app c3devkit .dram0.bss 56352 58272 1920 3.4
m5stack (read only) 922399 954835 32436 3.5
(read/write) 424356 438964 14608 3.4
.dram0.bss 61736 65640 3904 6.3
.flash.rodata 197324 207748 10424 5.3
.flash.text 917015 949451 32436 3.5
.iram0.text 122943 123223 280 0.2
linux all-clusters-app debug .data.rel.ro 67104 67136 32 0.0
.rodata 152117 152469 352 0.2
chip-tool debug (read only) 6628165 6628293 128 0.0
.text 5912661 5912789 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179404 181316 1912 1.1
.data 5184 5192 8 0.2
Decreases (4 builds for esp32, linux, mbed, p6)
platform target config section bfdbd45 94567cd change % change
esp32 all-clusters-app c3devkit (read only) 852538 851258 -1280 -0.2
(read/write) 1290914 1226826 -64088 -5.0
.flash.rodata 169520 169048 -472 -0.3
.flash.text 852538 851258 -1280 -0.2
linux all-clusters-app debug (read only) 1872825 1865073 -7752 -0.4
.bss 50672 50640 -32 -0.1
.text 1577602 1569474 -8128 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313152 2311616 -1536 -0.1
.heap 851856 849936 -1920 -0.2
.text 1275728 1274192 -1536 -0.1
p6 all-clusters-app default (read/write) 2349448 2347384 -2064 -0.1
.text 1307712 1305648 -2064 -0.2
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 94567cd change % change
efr32 lighting-app BRD4161A (read only) 758896 758896 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 758888 758888 0 0.0
BRD4161A+rpc (read only) 787544 787544 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 787536 787536 0 0.0
lock-app BRD4161A (read only) 733952 733952 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 733944 733944 0 0.0
window-app BRD4161A (read only) 736224 736224 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 736216 736216 0 0.0
esp32 all-clusters-app c3devkit (read only) 852538 851258 -1280 -0.2
(read/write) 1290914 1226826 -64088 -5.0
.dram0.bss 56352 58272 1920 3.4
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169048 -472 -0.3
.flash.text 852538 851258 -1280 -0.2
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922399 954835 32436 3.5
(read/write) 424356 438964 14608 3.4
.dram0.bss 61736 65640 3904 6.3
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 207748 10424 5.3
.flash.text 917015 949451 32436 3.5
.iram0.text 122943 123223 280 0.2
k32w lighting-app k32w061+se05x+release (read/write) 731908 731908 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644936 644936 0 0.0
lock-app k32w061+debug (read/write) 622076 622076 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544472 544472 0 0.0
shell k32w061+debug (read/write) 687968 687968 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598744 598744 0 0.0
linux all-clusters-app debug (read only) 1872825 1865073 -7752 -0.4
(read/write) 124336 124336 0 0.0
.bss 50672 50640 -32 -0.1
.data 1120 1120 0 0.0
.data.rel.ro 67104 67136 32 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152117 152469 352 0.2
.text 1577602 1569474 -8128 -0.5
bridge-app debug+rpc (read only) 1444277 1444277 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121500 121500 0 0.0
.text 1217877 1217877 0 0.0
chip-tool debug (read only) 6628165 6628293 128 0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 310776 310776 0 0.0
.text 5912661 5912789 128 0.0
lighting-app debug+rpc (read only) 1729441 1729441 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142161 142161 0 0.0
.text 1444610 1444610 0 0.0
ota-provider-app debug (read only) 1400953 1400953 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122856 122856 0 0.0
.text 1173410 1173410 0 0.0
ota-requestor-app debug (read only) 1510209 1510209 0 0.0
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135600 135600 0 0.0
.text 1265970 1265970 0 0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046473 2046473 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174352 174352 0 0.0
.text 1717378 1717378 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313152 2311616 -1536 -0.1
.bss 179404 181316 1912 1.1
.data 5184 5192 8 0.2
.heap 851856 849936 -1920 -0.2
.text 1275728 1274192 -1536 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299096 2299096 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261696 1261696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273088 2273088 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235688 1235688 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 894879 0 0.0
bss 113756 113756 0 0.0
rodata 99680 99680 0 0.0
text 605896 605896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 858255 858255 0 0.0
bss 110104 110104 0 0.0
rodata 91040 91040 0 0.0
text 580892 580892 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820790 820790 0 0.0
bss 115128 115128 0 0.0
rodata 94936 94936 0 0.0
text 536232 536232 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 866899 866899 0 0.0
bss 111016 111016 0 0.0
rodata 95796 95796 0 0.0
text 584708 584708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793050 793050 0 0.0
bss 112428 112428 0 0.0
rodata 91084 91084 0 0.0
text 515132 515132 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 871683 0 0.0
bss 110928 110928 0 0.0
rodata 97148 97148 0 0.0
text 588156 588156 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 864927 0 0.0
bss 110808 110808 0 0.0
rodata 95288 95288 0 0.0
text 583388 583388 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2349448 2347384 -2064 -0.1
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307712 1305648 -2064 -0.2
light-app default (read/write) 2284072 2284072 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242336 1242336 0 0.0
lock-app default (read/write) 2260624 2260624 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218888 1218888 0 0.0
qpg lighting-app qpg6100+debug (read only) 513724 513724 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508404 508404 0 0.0
lock-app qpg6100+debug (read only) 487464 487464 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482144 482144 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798382 798382 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 558088 0 0.0

chshu
chshu reviewed Dec 6, 2021
View reviewed changes
src/lib/shell/streamer_esp32.cpp Outdated Show resolved Hide resolved
src/lib/shell/commands/OTAUpdater_esp32.h Show resolved Hide resolved
src/lib/shell/commands/OTAUpdater_esp32.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12360: Size comparison from bfdbd45 to 229f7c8

Increases above 0.2%:

platform target config section bfdbd45 229f7c8 change % change
esp32 all-clusters-app c3devkit .dram0.bss 56352 58272 1920 3.4
m5stack (read only) 922399 954811 32412 3.5
(read/write) 424356 438916 14560 3.4
.dram0.bss 61736 65640 3904 6.3
.flash.rodata 197324 207700 10376 5.3
.flash.text 917015 949427 32412 3.5
.iram0.text 122943 123223 280 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179404 181316 1912 1.1
Increases (5 builds for esp32, linux, mbed)
platform target config section bfdbd45 229f7c8 change % change
esp32 all-clusters-app c3devkit .dram0.bss 56352 58272 1920 3.4
m5stack (read only) 922399 954811 32412 3.5
(read/write) 424356 438916 14560 3.4
.dram0.bss 61736 65640 3904 6.3
.flash.rodata 197324 207700 10376 5.3
.flash.text 917015 949427 32412 3.5
.iram0.text 122943 123223 280 0.2
linux all-clusters-app debug .data.rel.ro 67104 67136 32 0.0
.rodata 152117 152469 352 0.2
chip-tool debug (read only) 6628165 6628293 128 0.0
.text 5912661 5912789 128 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179404 181316 1912 1.1
.data 5184 5192 8 0.2
Decreases (4 builds for esp32, linux, mbed, p6)
platform target config section bfdbd45 229f7c8 change % change
esp32 all-clusters-app c3devkit (read only) 852538 851258 -1280 -0.2
(read/write) 1290914 1226826 -64088 -5.0
.flash.rodata 169520 169048 -472 -0.3
.flash.text 852538 851258 -1280 -0.2
linux all-clusters-app debug (read only) 1872825 1865073 -7752 -0.4
.bss 50672 50640 -32 -0.1
.text 1577602 1569474 -8128 -0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313152 2311616 -1536 -0.1
.heap 851856 849936 -1920 -0.2
.text 1275728 1274192 -1536 -0.1
p6 all-clusters-app default (read/write) 2349448 2347384 -2064 -0.1
.text 1307712 1305648 -2064 -0.2
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bfdbd45 229f7c8 change % change
efr32 lighting-app BRD4161A (read only) 758896 758896 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 758888 758888 0 0.0
BRD4161A+rpc (read only) 787544 787544 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 787536 787536 0 0.0
lock-app BRD4161A (read only) 733952 733952 0 0.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 733944 733944 0 0.0
window-app BRD4161A (read only) 736224 736224 0 0.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 736216 736216 0 0.0
esp32 all-clusters-app c3devkit (read only) 852538 851258 -1280 -0.2
(read/write) 1290914 1226826 -64088 -5.0
.dram0.bss 56352 58272 1920 3.4
.dram0.data 14052 14052 0 0.0
.flash.rodata 169520 169048 -472 -0.3
.flash.text 852538 851258 -1280 -0.2
.iram0.text 61394 61394 0 0.0
m5stack (read only) 922399 954811 32412 3.5
(read/write) 424356 438916 14560 3.4
.dram0.bss 61736 65640 3904 6.3
.dram0.data 34016 34016 0 0.0
.flash.rodata 197324 207700 10376 5.3
.flash.text 917015 949427 32412 3.5
.iram0.text 122943 123223 280 0.2
k32w lighting-app k32w061+se05x+release (read/write) 731908 731908 0 0.0
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 644936 644936 0 0.0
lock-app k32w061+debug (read/write) 622076 622076 0 0.0
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 544472 544472 0 0.0
shell k32w061+debug (read/write) 687968 687968 0 0.0
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 598744 598744 0 0.0
linux all-clusters-app debug (read only) 1872825 1865073 -7752 -0.4
(read/write) 124336 124336 0 0.0
.bss 50672 50640 -32 -0.1
.data 1120 1120 0 0.0
.data.rel.ro 67104 67136 32 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152117 152469 352 0.2
.text 1577602 1569474 -8128 -0.5
bridge-app debug+rpc (read only) 1444277 1444277 0 0.0
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121500 121500 0 0.0
.text 1217877 1217877 0 0.0
chip-tool debug (read only) 6628165 6628293 128 0.0
(read/write) 199752 199752 0 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158520 158520 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 310776 310776 0 0.0
.text 5912661 5912789 128 0.0
lighting-app debug+rpc (read only) 1729441 1729441 0 0.0
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142161 142161 0 0.0
.text 1444610 1444610 0 0.0
ota-provider-app debug (read only) 1400953 1400953 0 0.0
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122856 122856 0 0.0
.text 1173410 1173410 0 0.0
ota-requestor-app debug (read only) 1510209 1510209 0 0.0
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135600 135600 0 0.0
.text 1265970 1265970 0 0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046473 2046473 0 0.0
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 174352 174352 0 0.0
.text 1717378 1717378 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313152 2311616 -1536 -0.1
.bss 179404 181316 1912 1.1
.data 5184 5192 8 0.2
.heap 851856 849936 -1920 -0.2
.text 1275728 1274192 -1536 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299096 2299096 0 0.0
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1261696 1261696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273088 2273088 0 0.0
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1235688 1235688 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894879 894879 0 0.0
bss 113756 113756 0 0.0
rodata 99680 99680 0 0.0
text 605896 605896 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 858255 858255 0 0.0
bss 110104 110104 0 0.0
rodata 91040 91040 0 0.0
text 580892 580892 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820790 820790 0 0.0
bss 115128 115128 0 0.0
rodata 94936 94936 0 0.0
text 536232 536232 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 866899 866899 0 0.0
bss 111016 111016 0 0.0
rodata 95796 95796 0 0.0
text 584708 584708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793050 793050 0 0.0
bss 112428 112428 0 0.0
rodata 91084 91084 0 0.0
text 515132 515132 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871683 871683 0 0.0
bss 110928 110928 0 0.0
rodata 97148 97148 0 0.0
text 588156 588156 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 864927 864927 0 0.0
bss 110808 110808 0 0.0
rodata 95288 95288 0 0.0
text 583388 583388 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2349448 2347384 -2064 -0.1
.bss 107596 107596 0 0.0
.data 2464 2464 0 0.0
.heap 923280 923280 0 0.0
.text 1307712 1305648 -2064 -0.2
light-app default (read/write) 2284072 2284072 0 0.0
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1242336 1242336 0 0.0
lock-app default (read/write) 2260624 2260624 0 0.0
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1218888 1218888 0 0.0
qpg lighting-app qpg6100+debug (read only) 513724 513724 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 508404 508404 0 0.0
lock-app qpg6100+debug (read only) 487464 487464 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 482144 482144 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798382 798382 0 0.0
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 558088 558088 0 0.0

@shubhamdp
Copy link
Contributor

@wqx6, #12560 is merged, I think we should be implementing Interfaces from there. Should we implement them here or in follow-up PR?

@andy31415 andy31415 merged commit 3df8387 into project-chip:master Dec 6, 2021
@wqx6
Copy link
Contributor Author

wqx6 commented Dec 7, 2021

@wqx6, #12560 is merged, I think we should be implementing Interfaces from there. Should we implement them here or in follow-up PR?

Sure, I think using the interfaces form src/app/clusters/ota-requestor is better.

@bzbarsky-apple
Copy link
Contributor

@wqx6 Unfortunately, this PR broke OTA Provider server for all-clusters-app due to a limitation in ZAP: In its current form it randomly does not allow the client and server parts of the same cluster to coexist as far as I can tell (@tecimovic). If you look at zzz_generated/all-clusters-app/zap-generated/IMClusterCommandHandler.cpp after this change it looks like this:

namespace OtaSoftwareUpdateProvider {

void DispatchServerCommand(CommandHandler * apCommandObj, const ConcreteCommandPath & aCommandPath, TLV::TLVReader & aDataTlv)
{
    ReportCommandUnsupported(apCommandObj, aCommandPath);
}

} // namespace OtaSoftwareUpdateProvider

Worse yet, this is not stable: sometimes it ends up including the right code in there and sometimes it does not. This is causing very common CI failures. And I am not sure that putting the client on a different endpoint from the server would necessarily help, though maybe it's worth trying.

I'm also a little confused by the fact that the PR title talks about OTARequestor but all the changes are about OTAProvider client....

@andy31415 andy31415 mentioned this pull request Dec 7, 2021
Merged
@wqx6
Copy link
Contributor Author

wqx6 commented Dec 8, 2021 •
edited
Loading

@bzbarsky-apple I enabled OTA Provider Client because OTA Provider commands QueryImage ApplyUpdateRequest was used in src/lib/shell/commands/Ota.cpp. But in fact, the OTASoftwareUpdateProviderCluster used in chip shell was from controller data-model, so the OTAProvider client can be removed in all-clusters-app. I will raise a PR to remove it.

I wonder why the client and the server of the same cluster can't coexist. If we wants to develop an OTA Provider device supporting OTA update, we should enable both the OTAProvider client and the OTAProvider server in this device.

@wqx6 wqx6 mentioned this pull request Dec 8, 2021
Merged
@bzbarsky-apple
Copy link
Contributor

I wonder why the client and the server of the same cluster can't coexist.

Because ZAP is buggy....

@wqx6 wqx6 mentioned this pull request Dec 28, 2021
Merged
@tima-q
Copy link
Contributor

tima-q commented Jan 11, 2022

@bzbarsky-apple @wqx6 I've put up this PR #13256 last year before the holiday's. It basically removes all stubs from the applications and uses the data model files for all ota-requestor-server implementation.
Side effect was I needed to added the correct provider client/requestor server to all applications (shell, all-clusters-app) that had a stubbed implementation.
Now I see that kind of enabling broke some stuff due to ZAP. How can I proceed to integrate this ?
End goal is to get the lighting-app 'OTA-ready' - preferably in a clean way eg just enabling the necessary clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@dhrishi dhrishi dhrishi left review comments

@shubhamdp shubhamdp shubhamdp approved these changes

@chshu chshu chshu approved these changes

@woody-apple woody-apple woody-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app config darwin esp32 examples lib platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wqx6 @dhrishi @shubhamdp @bzbarsky-apple @tima-q @andy31415 @chshu @woody-apple @Damian-Nordic