-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Register reportable commands for attributes of type list #13759
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_ComplexReportable
Jan 20, 2022
Merged
[chip-tool] Register reportable commands for attributes of type list #13759
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_ComplexReportable
Jan 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
mspang and
pan-apple
January 20, 2022 12:24
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 20, 2022 12:24
vivien-apple
changed the title
Chip tool complex reportable
[chip-tool] Register reportable commands for attributes of type list
Jan 20, 2022
PR #13759: Size comparison from 914ba3e to e9e3101 Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
andy31415
approved these changes
Jan 20, 2022
fast track: small delta (one if removed), tested as working. |
We used to not be able to report them. And apparently when we added support we did not remove this condition. |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Complex attributes
report
command is not registered. Not sure why.Change overview
Testing
I have runned
./out/debug/standalone/chip-tool basic report attribute-list 2 5 1 0x12345 0