Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chip-tool] Register reportable commands for attributes of type list #13759

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

Complex attributes report command is not registered. Not sure why.

Change overview

  • Register the commands
  • Update generated code

Testing

I have runned ./out/debug/standalone/chip-tool basic report attribute-list 2 5 1 0x12345 0

@vivien-apple vivien-apple changed the title Chip tool complex reportable [chip-tool] Register reportable commands for attributes of type list Jan 20, 2022
@github-actions
Copy link

github-actions bot commented Jan 20, 2022

PR #13759: Size comparison from 914ba3e to e9e3101

Increases above 0.2%:

platform target config section 914ba3e4 e9e3101 change % change
linux chip-tool-ipv6only arm64 (read only) 8155868 8377500 221632 2.7
(read/write) 376481 386113 9632 2.6
.data.rel.ro 249928 257200 7272 2.9
.got 65632 67992 2360 3.6
.rodata 423044 429972 6928 1.6
.text 6928708 7119364 190656 2.8
Increases (1 build for linux)
platform target config section 914ba3e4 e9e3101 change % change
linux chip-tool-ipv6only arm64 (read only) 8155868 8377500 221632 2.7
(read/write) 376481 386113 9632 2.6
.data.rel.ro 249928 257200 7272 2.9
.got 65632 67992 2360 3.6
.rodata 423044 429972 6928 1.6
.text 6928708 7119364 190656 2.8
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 914ba3e4 e9e3101 change % change
efr32 lighting-app BRD4161A (read only) 832684 832684 0 0.0
(read/write) 127112 127112 0 0.0
.bss 125216 125216 0 0.0
.data 1896 1896 0 0.0
.text 832676 832676 0 0.0
BRD4161A+rpc (read only) 820080 820080 0 0.0
(read/write) 143776 143776 0 0.0
.bss 141776 141776 0 0.0
.data 1996 1996 0 0.0
.text 820072 820072 0 0.0
window-app BRD4161A (read only) 803268 803268 0 0.0
(read/write) 125800 125800 0 0.0
.bss 123952 123952 0 0.0
.data 1848 1848 0 0.0
.text 803260 803260 0 0.0
esp32 all-clusters-app c3devkit (read only) 910524 910524 0 0.0
(read/write) 1315850 1315850 0 0.0
.dram0.bss 70024 70024 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 178096 178096 0 0.0
.flash.text 910524 910524 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 959535 959535 0 0.0
(read/write) 448008 448008 0 0.0
.dram0.bss 74480 74480 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 207368 207368 0 0.0
.flash.text 954151 954151 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 656696 656696 0 0.0
.bss 76608 76608 0 0.0
.data 1864 1864 0 0.0
.text 572424 572424 0 0.0
lock k32w061+release (read/write) 659400 659400 0 0.0
.bss 76904 76904 0 0.0
.data 1884 1884 0 0.0
.text 574812 574812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8155868 8377500 221632 2.7
(read/write) 376481 386113 9632 2.6
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 249928 257200 7272 2.9
.dynamic 560 560 0 0.0
.got 65632 67992 2360 3.6
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 423044 429972 6928 1.6
.text 6928708 7119364 190656 2.8
thermostat-no-ble arm64 (read only) 2033476 2033476 0 0.0
(read/write) 144417 144417 0 0.0
.bss 63841 63841 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72704 72704 0 0.0
.dynamic 560 560 0 0.0
.got 4032 4032 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129508 129508 0 0.0
.text 1689952 1689952 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347504 2347504 0 0.0
.bss 188732 188732 0 0.0
.data 5296 5296 0 0.0
.text 1310080 1310080 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331768 2331768 0 0.0
.bss 180232 180232 0 0.0
.data 5576 5576 0 0.0
.text 1294368 1294368 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302120 2302120 0 0.0
.bss 179240 179240 0 0.0
.data 5552 5552 0 0.0
.text 1264720 1264720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
p6 all-clusters-app default (read/write) 2403648 2403648 0 0.0
.bss 117068 117068 0 0.0
.data 2568 2568 0 0.0
.text 1361912 1361912 0 0.0
light-app default (read/write) 2327768 2327768 0 0.0
.bss 105600 105600 0 0.0
.data 2408 2408 0 0.0
.text 1286032 1286032 0 0.0
lock-app default (read/write) 2296792 2296792 0 0.0
.bss 104448 104448 0 0.0
.data 2352 2352 0 0.0
.text 1255056 1255056 0 0.0
qpg lighting-app qpg6105+debug (read only) 563480 563480 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89696 89696 0 0.0
.data 1060 1060 0 0.0
.text 558160 558160 0 0.0
lock-app qpg6105+debug (read only) 513836 513836 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88320 88320 0 0.0
.data 984 984 0 0.0
.text 508516 508516 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 838018 838018 0 0.0
bss 86772 86772 0 0.0
noinit 37160 37160 0 0.0
text 585862 585862 0 0.0

@andy31415
Copy link
Contributor

fast track: small delta (one if removed), tested as working.

@bzbarsky-apple
Copy link
Contributor

Complex attributes report command is not registered. Not sure why.

We used to not be able to report them. And apparently when we added support we did not remove this condition.

selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants