-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Support complex types (as command argument or as writeable attribute) #13761
[chip-tool] Support complex types (as command argument or as writeable attribute) #13761
Conversation
PR #13761: Size comparison from 786fdfa to acc6d29 Increases above 0.2%:
Increases (1 build for linux)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
acc6d29
to
c8ae11c
Compare
PR #13761: Size comparison from fa0b36f to c8ae11c Increases above 0.2%:
Increases (1 build for linux)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given tooling changes
c8ae11c
to
da909b7
Compare
da909b7
to
90c4c66
Compare
PR #13761: Size comparison from 799d195 to 90c4c66 Increases above 0.2%:
Increases (1 build for linux)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
90c4c66
to
fe6f881
Compare
PR #13761: Size comparison from 12253c6 to fe6f881 Increases above 0.2%:
Increases (1 build for linux)
Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
|
…e attribute) (project-chip#13761) * [chip-tool] Add complex types supports * Update generated code
Problem
chip-tool
does not support complex types as command argument or as attribute when it comes to writing.The first 4 commits are #13759 and #13726 and so they can be ignored while reviewing. The interesting part is the commit named:
Change overview
Testing
I have verified it with a few different commands: