Call InitChipStack from the device controller #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerickson
approved these changes
Jul 8, 2020
woody-apple
changed the title
vivien-apple
force-pushed
the
Darwin_AddPlatformCallInitChipStack
branch
from
fb499b9 to
0e0f9bf
Compare
vivien-apple
requested review from
andy31415,
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
saurabhst and
woody-apple
as code owners
BroderickCarlin
approved these changes
Jul 9, 2020
woody-apple
approved these changes
Jul 10, 2020
|
@vivien-apple please rebase :) |
This PR will work once #1534 has landed. Will rebased once I I finished fixing the build issues with #1534 |
vivien-apple
force-pushed
the
Darwin_AddPlatformCallInitChipStack
branch
from
0e0f9bf to
d540971
Compare
vivien-apple
force-pushed
the
Darwin_AddPlatformCallInitChipStack
branch
4 times, most recently
from
fb499b9 to
f57a8ca
Compare
|
I add to fight a bit the old build system and the gn build system to get it to work. Should be green now. |
|
@vivien-apple can you fix the merge conflicts here please? @andy31415 @jelderton - can you review please? |
woody-apple
reviewed
Jul 20, 2020
woody-apple
approved these changes
Jul 20, 2020
woody-apple
reviewed
Jul 20, 2020
vivien-apple
force-pushed
the
Darwin_AddPlatformCallInitChipStack
branch
from
f57a8ca to
d361620
Compare
vivien-apple
force-pushed
the
Darwin_AddPlatformCallInitChipStack
branch
2 times, most recently
from
fb499b9 to
5f8e73f
Compare
|
Size increase report for "nrf-example-build"
Full report output |
|
Size increase report for "linux-example-build"
Full report output |
|
Size increase report for "esp32-example-build"
Full report output |
|
Size increase report for "gn_nrf-example-build"
Full report output |
|
Size increase report for "gn_linux-example-build"
Full report output |
jelderton
approved these changes
Jul 21, 2020
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Jul 23, 2020
After 0320920 ("Call PlatformMgr::InitChipStack from the device controller (project-chip#1500)") this fails due to trying to include a nonexistent header. Fix it by leaving CHIP_PLATFORM_CONFIG_INCLUDE et al undefined when device_platform is "none".
andy31415
pushed a commit
that referenced
this pull request
Jul 27, 2020
* Fix building with device_platform="none" After 0320920 ("Call PlatformMgr::InitChipStack from the device controller (#1500)") this fails due to trying to include a nonexistent header. Fix it by leaving CHIP_PLATFORM_CONFIG_INCLUDE et al undefined when device_platform is "none". * Add Darwin device layer to fix Mac build * Update pigweed for objc toolchain * darwin: Add frameworks via "frameworks", not "libs" It turns out that putting frameworks in {{libs}} was deprecated and is removed as of gn 3028c6a4 ("[apple] Remove support for frameworks in libs"). Specify them separately via "frameworks".
kpschoedel
pushed a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Jul 27, 2020
* Fix building with device_platform="none" After 0320920 ("Call PlatformMgr::InitChipStack from the device controller (project-chip#1500)") this fails due to trying to include a nonexistent header. Fix it by leaving CHIP_PLATFORM_CONFIG_INCLUDE et al undefined when device_platform is "none". * Add Darwin device layer to fix Mac build * Update pigweed for objc toolchain * darwin: Add frameworks via "frameworks", not "libs" It turns out that putting frameworks in {{libs}} was deprecated and is removed as of gn 3028c6a4 ("[apple] Remove support for frameworks in libs"). Specify them separately via "frameworks".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is an example of how I would change the event loop code from the Darwin framework to ChipDeviceController if #1497 lands. The current code is not ready to be merged yet. It needs some more love since in the current shape it will likely break examples/chip-tool and we need to determine if CHIPDeviceController always expect a device layer or not.