Glue standalone application to a device layer for POSIX platforms #1534

vivien-apple · 2020-07-09T14:34:32Z

Problem

This patch glue standalone apps to a device layer. Examples of such standalone builds are the one produce by:

make -f Makefile-Standalone
examples/chip-tool (which use config/standalone)
examples/shell (which use config/standalone)

gerickson · 2020-07-09T14:37:12Z

Makefile-Standalone

@@ -192,6 +192,14 @@ ifeq ($(ENABLE_CHIPOBLE_TEST),1)
 configure_OPTIONS               += --enable-chipoble-test=yes
 endif

+ifeq ($(HOSTOS),darwin)
+configure_OPTIONS               += --with-device-layer=darwin


I think this is fine; however, I'd like to propose auto-detecting this in configure.ac by --with-device-layer supporting and defaulting to an auto value.

This will preclude having this logic in both Makefile-Standalone and in standalone-chip.mk.

Happy to help with this if you'd like.

Makes sense. I have updated the patch.

lgtm-com · 2020-07-09T15:08:57Z

This pull request introduces 4 alerts and fixes 1 when merging d598a6d into ace290d - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

gerickson

Nice work!

lgtm-com · 2020-07-09T19:40:17Z

This pull request introduces 4 alerts and fixes 1 when merging 4129e4d into e0f65ef - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

vivien-apple · 2020-07-09T22:11:13Z

I have added a few missing headers in src/platform/Makefile.am

lgtm-com · 2020-07-09T22:48:39Z

This pull request introduces 4 alerts and fixes 1 when merging 215ff84 into e0f65ef - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

woody-apple · 2020-07-10T03:27:32Z

@vivien-apple build failure

lgtm-com · 2020-07-10T17:21:42Z

This pull request introduces 4 alerts and fixes 1 when merging 166116a into 18129db - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

lgtm-com · 2020-07-10T17:53:01Z

This pull request introduces 4 alerts and fixes 1 when merging 8c7ab44 into 18129db - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

lgtm-com · 2020-07-10T18:38:03Z

This pull request introduces 4 alerts and fixes 1 when merging c252466 into 0c1fc15 - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

github-actions · 2020-07-10T19:44:37Z

Size increase report for "linux-example-build"

File	Section	File	VM
chip-standalone-demo.out	[LOAD #5 [RW]]	0	16
chip-standalone-demo.out	.eh_frame	-8	-8
chip-standalone-demo.out	.data	-16	-16
chip-standalone-demo.out	.text	-32	-32
chip-standalone-demo.out	.bss	0	-14080

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize
.debug_line,0,3512
.debug_str,0,625
.debug_macro,0,287
[Unmapped],0,37
[LOAD #5 [RW]],16,0
.eh_frame,-8,-8
.data,-16,-16
.symtab,0,-24
.strtab,0,-31
.text,-32,-32
.debug_loc,0,-126
.debug_abbrev,0,-359
.debug_info,0,-513
.bss,-14080,0

andy31415 · 2020-07-10T19:53:18Z

This seems to be the first version that has a diffable bloat report.

Is 14K really correct? Is the minus correct? I see only addition - I wonder if our bot does things backwards.

@vivien-apple - do you think a large BSS size change is expected from this PR? Is a 'decrease' correct?

woody-apple · 2020-07-10T20:49:27Z

@vivien-apple Seems to be breaking builds still :(

vivien-apple · 2020-07-15T16:30:06Z

@vivien-apple Seems to be breaking builds still :(

Sorry about that and my also for the way I have used the CI.
There are some differences between the CI and the VSCode container when it comes to build the dist package related to the ot-br-posix dependency.

I finally found a way to get the build system happy locally but I will open a specific bug for this issue as it is unclear to me what it works on CI and not on VSCode.

vivien-apple · 2020-07-15T16:44:01Z

This seems to be the first version that has a diffable bloat report.

Is 14K really correct? Is the minus correct? I see only addition - I wonder if our bot does things backwards.

@vivien-apple - do you think a large BSS size change is expected from this PR? Is a 'decrease' correct?

It was not expected. But the configuration of the demo build may have changed with the platform config flags in src/platform and something could have been disabled.

lgtm-com · 2020-07-15T17:01:52Z

This pull request introduces 4 alerts and fixes 1 when merging 8f0b23c into bca8b6e - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

lgtm-com · 2020-07-15T17:37:54Z

This pull request introduces 4 alerts and fixes 1 when merging 98632e5 into bca8b6e - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

github-actions · 2020-07-15T18:56:15Z

Size increase report for "nrf-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

lgtm-com · 2020-07-15T19:00:39Z

This pull request introduces 4 alerts and fixes 1 when merging 65597f6 into bca8b6e - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

github-actions · 2020-07-16T10:36:46Z

Size increase report for "esp32-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

github-actions · 2020-07-16T10:36:50Z

Size increase report for "gn_nrf-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

github-actions · 2020-07-16T10:36:53Z

Size increase report for "gn_linux-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

lgtm-com · 2020-07-16T10:46:22Z

This pull request introduces 4 alerts and fixes 1 when merging aedca64 into bca8b6e - view on LGTM.com

new alerts:

4 for Expression has no effect

fixed alerts:

1 for Expression has no effect

…oject-chip#1534)

…p when it is uncommissioned Merge in WMN_TOOLS/matter from feature/917_sleepy_uncommissioned to RC_2.3.0-1.3 Squashed commit of the following: commit 0d5350c7dc0468aeb1c7bcf7f8cb8833b8e1427a Author: chbansal <chirag.bansal@silabs.com> Date: Thu Feb 8 15:07:37 2024 +0530 reverting the DIC_ENABLE macro to back place commit 5df0f689f39525889979e6e609f56b463611c3dc Author: chbansal <chirag.bansal@silabs.com> Date: Wed Feb 7 23:15:22 2024 +0530 Adding different Appdelegate to not allow the DUT go to sleep in between commissioning commit 4bfd3a125ec5561325ee29b263479821253cc69d Author: chbansal <chirag.bansal@silabs.com> Date: Wed Feb 7 21:43:01 2024 +0530 reverting the BLEManagerImpl.cpp ... and 7 more commits

vivien-apple requested review from andy31415, anush-apple, BroderickCarlin, chrisdecenzo, hawk248, jelderton, robszewczyk, saurabhst and woody-apple as code owners July 9, 2020 14:34

gerickson suggested changes Jul 9, 2020

View reviewed changes

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 8972c7b to d598a6d Compare July 9, 2020 14:55

vivien-apple requested a review from gerickson July 9, 2020 14:56

gerickson approved these changes Jul 9, 2020

View reviewed changes

vivien-apple mentioned this pull request Jul 9, 2020

Call InitChipStack from the device controller #1500

Merged

BroderickCarlin approved these changes Jul 9, 2020

View reviewed changes

woody-apple approved these changes Jul 9, 2020

View reviewed changes

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from d598a6d to 4129e4d Compare July 9, 2020 19:24

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch 2 times, most recently from 2542488 to deec3aa Compare July 9, 2020 22:10

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from deec3aa to 6589180 Compare July 9, 2020 22:14

andy31415 approved these changes Jul 9, 2020

View reviewed changes

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch 2 times, most recently from e402b83 to 215ff84 Compare July 9, 2020 22:34

woody-apple mentioned this pull request Jul 10, 2020

LGTM issues #1548

Closed

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 215ff84 to b51651a Compare July 10, 2020 16:28

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 166116a to 8c7ab44 Compare July 10, 2020 17:39

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 8c7ab44 to c252466 Compare July 10, 2020 18:21

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch 2 times, most recently from c252466 to a43f6d6 Compare July 15, 2020 16:56

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 8f0b23c to 98632e5 Compare July 15, 2020 17:22

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 98632e5 to 65597f6 Compare July 15, 2020 18:46

Glue standalone application to a device layer for POSIX platforms

aedca64

vivien-apple force-pushed the Darwin_GlueStandaloneAppToDeviceLayer branch from 65597f6 to aedca64 Compare July 16, 2020 10:26

andy31415 merged commit 694f20d into project-chip:master Jul 16, 2020

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020

Glue standalone application to a device layer for POSIX platforms (pr…

b075ccc

…oject-chip#1534)

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request Jul 21, 2020

Glue standalone application to a device layer for POSIX platforms (pr…

76bb6b5

…oject-chip#1534)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glue standalone application to a device layer for POSIX platforms #1534

Glue standalone application to a device layer for POSIX platforms #1534

vivien-apple commented Jul 9, 2020

gerickson Jul 9, 2020

gerickson Jul 9, 2020

gerickson Jul 9, 2020

vivien-apple Jul 9, 2020

lgtm-com bot commented Jul 9, 2020

gerickson left a comment

lgtm-com bot commented Jul 9, 2020

vivien-apple commented Jul 9, 2020

lgtm-com bot commented Jul 9, 2020

woody-apple commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

github-actions bot commented Jul 10, 2020

andy31415 commented Jul 10, 2020

woody-apple commented Jul 10, 2020

vivien-apple commented Jul 15, 2020

vivien-apple commented Jul 15, 2020

lgtm-com bot commented Jul 15, 2020

lgtm-com bot commented Jul 15, 2020

github-actions bot commented Jul 15, 2020

lgtm-com bot commented Jul 15, 2020

github-actions bot commented Jul 16, 2020

github-actions bot commented Jul 16, 2020

github-actions bot commented Jul 16, 2020

lgtm-com bot commented Jul 16, 2020

Glue standalone application to a device layer for POSIX platforms #1534

Glue standalone application to a device layer for POSIX platforms #1534

Conversation

vivien-apple commented Jul 9, 2020

Problem

gerickson Jul 9, 2020

Choose a reason for hiding this comment

gerickson Jul 9, 2020

Choose a reason for hiding this comment

gerickson Jul 9, 2020

Choose a reason for hiding this comment

vivien-apple Jul 9, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Jul 9, 2020

gerickson left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Jul 9, 2020

vivien-apple commented Jul 9, 2020

lgtm-com bot commented Jul 9, 2020

woody-apple commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

github-actions bot commented Jul 10, 2020

andy31415 commented Jul 10, 2020

woody-apple commented Jul 10, 2020

vivien-apple commented Jul 15, 2020

vivien-apple commented Jul 15, 2020

lgtm-com bot commented Jul 15, 2020

lgtm-com bot commented Jul 15, 2020

github-actions bot commented Jul 15, 2020

lgtm-com bot commented Jul 15, 2020

github-actions bot commented Jul 16, 2020

github-actions bot commented Jul 16, 2020

github-actions bot commented Jul 16, 2020

lgtm-com bot commented Jul 16, 2020