Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex types to chip tool darwin #16909

Merged

Conversation

krypton36
Copy link
Contributor

Problem

Change overview

  • Use the current CLI parsing implementation of complex types in chip-tool-darwin

Testing

  • Generated code
  • Compiled
  • Sent commands to chip-all-clusters

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

PR #16909: Size comparison from 089d46a to 1902dda

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 089d46a 1902dda change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667427 667427 0 0.0
(read/write) 184316 184316 0 0.0
.bss 81784 81784 0 0.0
.data 3132 3132 0 0.0
.rodata 79595 79595 0 0.0
.text 587352 587352 0 0.0
lock-mtd LP_CC2652R7 (read only) 616555 616555 0 0.0
(read/write) 154500 154500 0 0.0
.bss 77512 77512 0 0.0
.data 3132 3132 0 0.0
.rodata 79475 79475 0 0.0
.text 536592 536592 0 0.0
pump-app LP_CC2652R7 (read only) 686887 686887 0 0.0
(read/write) 166016 166016 0 0.0
.bss 82176 82176 0 0.0
.data 3164 3164 0 0.0
.rodata 81671 81671 0 0.0
.text 604732 604732 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669159 669159 0 0.0
(read/write) 183488 183488 0 0.0
.bss 81920 81920 0 0.0
.data 3128 3128 0 0.0
.rodata 78007 78007 0 0.0
.text 590668 590668 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 609634 609634 0 0.0
.app_xip_area 516376 516376 0 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567146 567146 0 0.0
.app_xip_area 475424 475424 0 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578926 578926 0 0.0
.app_xip_area 477548 477548 0 0.0
.bss 83836 83836 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 930216 930216 0 0.0
(read/write) 129128 129128 0 0.0
.bss 127136 127136 0 0.0
.data 1992 1992 0 0.0
.text 930208 930208 0 0.0
BRD4161A+rpc (read only) 959216 959216 0 0.0
(read/write) 145088 145088 0 0.0
.bss 142912 142912 0 0.0
.data 2172 2172 0 0.0
.text 959208 959208 0 0.0
window-app BRD4161A (read only) 865512 865512 0 0.0
(read/write) 127136 127136 0 0.0
.bss 125264 125264 0 0.0
.data 1872 1872 0 0.0
.text 865504 865504 0 0.0
esp32 all-clusters-app c3devkit (read only) 970490 970490 0 0.0
(read/write) 1395138 1395138 0 0.0
.dram0.bss 62456 62456 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 199544 199544 0 0.0
.flash.text 970490 970490 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1026223 1026223 0 0.0
(read/write) 462900 462900 0 0.0
.dram0.bss 67984 67984 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 229056 229056 0 0.0
.flash.text 1020839 1020839 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 707240 707240 0 0.0
.bss 77992 77992 0 0.0
.data 1872 1872 0 0.0
.text 621576 621576 0 0.0
lock k32w061+release (read/write) 706488 706488 0 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 620816 620816 0 0.0
linux all-clusters-app debug (read only) 2552497 2552497 0 0.0
(read/write) 143872 143872 0 0.0
.bss 57472 57472 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 79352 79352 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 218981 218981 0 0.0
.text 2169090 2169090 0 0.0
bridge-app debug+rpc (read only) 1782397 1782397 0 0.0
(read/write) 89880 89880 0 0.0
.bss 44552 44552 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 38232 38232 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146961 146961 0 0.0
.text 1519573 1519573 0 0.0
chip-tool debug (read only) 10367501 10367501 0 0.0
(read/write) 357952 357952 0 0.0
.bss 22080 22080 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 328576 328576 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 531629 531629 0 0.0
.text 9044981 9044981 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9972980 9972980 0 0.0
(read/write) 477329 477329 0 0.0
.bss 40401 40401 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 375432 375432 0 0.0
.dynamic 560 560 0 0.0
.got 56552 56552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 505388 505388 0 0.0
.text 8405188 8405188 0 0.0
door-lock-app debug (read only) 2035121 2035121 0 0.0
(read/write) 117288 117288 0 0.0
.bss 47680 47680 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 63176 63176 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 183553 183553 0 0.0
.text 1701250 1701250 0 0.0
lighting-app debug+rpc (read only) 2212881 2212881 0 0.0
(read/write) 124280 124280 0 0.0
.bss 48960 48960 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 68248 68248 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 177569 177569 0 0.0
.text 1875634 1875634 0 0.0
ota-provider-app debug (read only) 1974937 1974937 0 0.0
(read/write) 113016 113016 0 0.0
.bss 47584 47584 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58488 58488 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169187 169187 0 0.0
.text 1653378 1653378 0 0.0
ota-requestor-app debug (read only) 2003129 2003129 0 0.0
(read/write) 116176 116176 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60680 60680 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 165612 165612 0 0.0
.text 1684210 1684210 0 0.0
shell debug (read only) 2467801 2467801 0 0.0
(read/write) 147824 147824 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74016 74016 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212146 212146 0 0.0
.text 2098034 2098034 0 0.0
thermostat-no-ble arm64 (read only) 2292676 2292676 0 0.0
(read/write) 148657 148657 0 0.0
.bss 62849 62849 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77216 77216 0 0.0
.dynamic 560 560 0 0.0
.got 4536 4536 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 142052 142052 0 0.0
.text 1926688 1926688 0 0.0
tv-app debug (read only) 2716201 2716201 0 0.0
(read/write) 248632 248632 0 0.0
.bss 165072 165072 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74368 74368 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 209419 209419 0 0.0
.text 2331650 2331650 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358540 2358540 0 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321140 1321140 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147827 1147827 0 0.0
bss 143092 143092 0 0.0
rodata 143204 143204 0 0.0
text 786732 786732 0 0.0
p6 all-clusters-app default (read/write) 2502872 2502872 0 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461136 1461136 0 0.0
light-app default (read/write) 2404360 2404360 0 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1362624 1362624 0 0.0
lock-app default (read/write) 2367968 2367968 0 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326232 1326232 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 791300 791300 0 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561260 561260 0 0.0

@bzbarsky-apple bzbarsky-apple changed the title Add commplex types to chip tool darwin Add complex types to chip tool darwin Apr 1, 2022
@krypton36 krypton36 force-pushed the AddCommplexTypesToChipToolDarwin branch from 1902dda to e20b367 Compare April 1, 2022 15:35
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

PR #16909: Size comparison from 193b85c to e20b367

Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 193b85c e20b367 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667419 667419 0 0.0
(read/write) 184324 184324 0 0.0
.bss 81784 81784 0 0.0
.data 3132 3132 0 0.0
.rodata 79595 79595 0 0.0
.text 587344 587344 0 0.0
lock-mtd LP_CC2652R7 (read only) 616547 616547 0 0.0
(read/write) 154500 154500 0 0.0
.bss 77512 77512 0 0.0
.data 3132 3132 0 0.0
.rodata 79475 79475 0 0.0
.text 536584 536584 0 0.0
pump-app LP_CC2652R7 (read only) 686879 686879 0 0.0
(read/write) 166024 166024 0 0.0
.bss 82176 82176 0 0.0
.data 3164 3164 0 0.0
.rodata 81671 81671 0 0.0
.text 604724 604724 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669151 669151 0 0.0
(read/write) 183496 183496 0 0.0
.bss 81920 81920 0 0.0
.data 3128 3128 0 0.0
.rodata 78007 78007 0 0.0
.text 590660 590660 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 609626 609626 0 0.0
.app_xip_area 516368 516368 0 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567138 567138 0 0.0
.app_xip_area 475416 475416 0 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578990 578990 0 0.0
.app_xip_area 477612 477612 0 0.0
.bss 83836 83836 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914632 914632 0 0.0
(read/write) 129776 129776 0 0.0
.bss 127816 127816 0 0.0
.data 1960 1960 0 0.0
.text 914624 914624 0 0.0
BRD4161A+rpc (read only) 942512 942512 0 0.0
(read/write) 145736 145736 0 0.0
.bss 143592 143592 0 0.0
.data 2140 2140 0 0.0
.text 942504 942504 0 0.0
window-app BRD4161A (read only) 849944 849944 0 0.0
(read/write) 127784 127784 0 0.0
.bss 125944 125944 0 0.0
.data 1840 1840 0 0.0
.text 849936 849936 0 0.0
esp32 all-clusters-app c3devkit (read only) 970740 970740 0 0.0
(read/write) 1395242 1395242 0 0.0
.dram0.bss 62456 62456 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 199648 199648 0 0.0
.flash.text 970740 970740 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1026443 1026443 0 0.0
(read/write) 462964 462964 0 0.0
.dram0.bss 67984 67984 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 229120 229120 0 0.0
.flash.text 1021059 1021059 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 707304 707304 0 0.0
.bss 77992 77992 0 0.0
.data 1872 1872 0 0.0
.text 621640 621640 0 0.0
lock k32w061+release (read/write) 706488 706488 0 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 620816 620816 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9975524 9975524 0 0.0
(read/write) 477489 477489 0 0.0
.bss 40401 40401 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 375576 375576 0 0.0
.dynamic 560 560 0 0.0
.got 56568 56568 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 505372 505372 0 0.0
.text 8407364 8407364 0 0.0
thermostat-no-ble arm64 (read only) 2294132 2294132 0 0.0
(read/write) 148785 148785 0 0.0
.bss 62849 62849 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77328 77328 0 0.0
.dynamic 560 560 0 0.0
.got 4552 4552 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 142164 142164 0 0.0
.text 1927744 1927744 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358540 2358540 0 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321140 1321140 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147811 1147811 0 0.0
bss 143092 143092 0 0.0
rodata 143204 143204 0 0.0
text 786716 786716 0 0.0
p6 all-clusters-app default (read/write) 2502776 2502776 0 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461040 1461040 0 0.0
light-app default (read/write) 2404264 2404264 0 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1362528 1362528 0 0.0
lock-app default (read/write) 2367872 2367872 0 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326136 1326136 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 791252 791252 0 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561214 561214 0 0.0

Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking tooling changes.

@woody-apple woody-apple merged commit 9db5ca8 into project-chip:master Apr 1, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
* Add complex types to chip-tool darwin.

* Generated Code
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
* Add complex types to chip-tool darwin.

* Generated Code
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
* Add complex types to chip-tool darwin.

* Generated Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TC-SU-2.4 & 2.6] otasoftwareupdateprovider cluster errors with chip-tool-darwin
3 participants