Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment when using PacketBuffer reserve space #19244

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Fix alignment when using PacketBuffer reserve space #19244

merged 2 commits into from
Jun 7, 2022

Conversation

kpschoedel
Copy link
Contributor

Problem

Some UDPEndPoint implementation code assumes that IPPacketInfo
is aligned to 4 bytes, when storing one inside PacketBuffer
reserved space. It would also fail to identify the available
reserve if there was enough space, but less that 3 bytes more
than enough.

See #17213 Re-alignment logic makes incorrect assumptions

Change overview

Adds a PacketBuffer::GetReserve() that returns a pointer in
the buffer reserve space suitable in size and alignment for a T,
and uses it for GetPacketInfo() in UDPEndPointImplLwIP and
UDPEndPointImplOT.

Testing

Added a unit test, PacketBufferTest::CheckGetReserve().

@kpschoedel
Fix alignment when using PacketBuffer reserve space
81c8754 
#### Problem

Some UDPEndPoint implementation code assumes that IPPacketInfo
is aligned to 4 bytes, when storing one inside PacketBuffer
reserved space. It would also fail to identify the available
reserve if there was enough space, but less that 3 bytes more
than enough.

See project-chip#17213 Re-alignment logic makes incorrect assumptions

#### Change overview

Adds a PacketBuffer::GetReserve<T>() that returns a pointer in
the buffer reserve space suitable in size and alignment for a T,
and uses it for `GetPacketInfo()` in `UDPEndPointImplLwIP` and
`UDPEndPointImplOT`.

#### Testing

Added a unit test, `PacketBufferTest::CheckGetReserve()`.
@github-actions
Copy link

github-actions bot commented Jun 6, 2022 •
edited
Loading

PR #19244: Size comparison from 5f0dc86 to 81c8754

Increases (16 builds for cc13x2_26x2, cyw30739, k32w, p6)
platform target config section 5f0dc86 81c8754 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 651711 48 0.0
.text 565904 565952 48 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 617735 48 0.0
.text 542496 542544 48 0.0
lock-ftd LP_CC2652R7 (read only) 683027 683075 48 0.0
.text 584896 584944 48 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632483 48 0.0
.text 534416 534464 48 0.0
pump-app LP_CC2652R7 (read only) 664099 664147 48 0.0
.text 577768 577816 48 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655307 48 0.0
.text 570880 570928 48 0.0
shell LP_CC2652R7 (read only) 644702 644750 48 0.0
.text 561956 562004 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602290 48 0.0
.app_xip_area 461268 461316 48 0.0
lock cyw930739m2evb_01 (read/write) 599294 599342 48 0.0
.app_xip_area 458184 458232 48 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596958 48 0.0
.app_xip_area 456932 456980 48 0.0
k32w light k32w061+release (read/write) 653400 653448 48 0.0
.text 575624 575672 48 0.0
lock k32w061+release (read/write) 714380 714428 48 0.0
.text 636192 636240 48 0.0
p6 all-clusters-app default (read/write) 2545728 2545792 64 0.0
.text 1503992 1504056 64 0.0
all-clusters-minimal-app default (read/write) 2490592 2490656 64 0.0
.text 1448856 1448920 64 0.0
light-app default (read/write) 2422488 2422552 64 0.0
.text 1380752 1380816 64 0.0
lock-app default (read/write) 2442808 2442872 64 0.0
.text 1401072 1401136 64 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 5f0dc86 81c8754 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 159804 159756 -48 -0.0
pump-app LP_CC2652R7 (read/write) 179636 179588 -48 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188588 188540 -48 -0.0
Full report (32 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 5f0dc86 81c8754 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 651711 48 0.0
(read/write) 158924 158924 0 0.0
.bss 74604 74604 0 0.0
.data 3404 3404 0 0.0
.rodata 85527 85527 0 0.0
.text 565904 565952 48 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 617735 48 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74959 74959 0 0.0
.text 542496 542544 48 0.0
lock-ftd LP_CC2652R7 (read only) 683027 683075 48 0.0
(read/write) 159804 159756 -48 -0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97651 97651 0 0.0
.text 584896 584944 48 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632483 48 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97531 97531 0 0.0
.text 534416 534464 48 0.0
pump-app LP_CC2652R7 (read only) 664099 664147 48 0.0
(read/write) 179636 179588 -48 -0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85851 85851 0 0.0
.text 577768 577816 48 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655307 48 0.0
(read/write) 188588 188540 -48 -0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83899 83899 0 0.0
.text 570880 570928 48 0.0
shell LP_CC2652R7 (read only) 644702 644750 48 0.0
(read/write) 154480 154480 0 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 82510 82510 0 0.0
.text 561956 562004 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602290 48 0.0
.app_xip_area 461268 461316 48 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599342 48 0.0
.app_xip_area 458184 458232 48 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596958 48 0.0
.app_xip_area 456932 456980 48 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 653400 653448 48 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575672 48 0.0
lock k32w061+release (read/write) 714380 714428 48 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636240 48 0.0
linux all-clusters-app debug (read only) 2779289 2779289 0 0.0
(read/write) 178568 178568 0 0.0
.bss 86368 86368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 246205 246205 0 0.0
.text 2359154 2359154 0 0.0
all-clusters-minimal-app debug (read only) 2654849 2654849 0 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2234258 2234258 0 0.0
bridge-app debug+rpc (read only) 2032521 2032521 0 0.0
(read/write) 147960 147960 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65544 65544 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1706130 1706130 0 0.0
chip-tool debug (read only) 9659181 9659181 0 0.0
(read/write) 606448 606448 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 575064 575064 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497277 497277 0 0.0
.text 7760261 7760261 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409764 0 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412116 0 0.0
lighting-app debug+rpc (read only) 2322777 2322777 0 0.0
(read/write) 153632 153632 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71064 71064 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1968210 1968210 0 0.0
lock-app debug (read only) 2266001 2266001 0 0.0
(read/write) 148736 148736 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1902546 1902546 0 0.0
ota-provider-app debug (read only) 2067105 2067105 0 0.0
(read/write) 141616 141616 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61032 61032 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726722 1726722 0 0.0
ota-requestor-app debug (read only) 2095025 2095025 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1757266 1757266 0 0.0
shell debug (read only) 2584129 2584129 0 0.0
(read/write) 201976 201976 0 0.0
.bss 117224 117224 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77632 77632 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 226258 226258 0 0.0
.text 2198450 2198450 0 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
tv-app debug (read only) 2880897 2880897 0 0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223136 223136 0 0.0
.text 2475106 2475106 0 0.0
tv-casting-app debug (read only) 5330409 5330409 0 0.0
(read/write) 222704 222704 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135440 135440 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337408 337408 0 0.0
.text 4641762 4641762 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545792 64 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1504056 64 0.0
all-clusters-minimal-app default (read/write) 2490592 2490656 64 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448920 64 0.0
light-app default (read/write) 2422488 2422552 64 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380816 64 0.0
lock-app default (read/write) 2442808 2442872 64 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401136 64 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781008 781008 0 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552400 552400 0 0.0
lighting-app tlsr9518adk80d (read/write) 801052 801052 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569142 569142 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jun 6, 2022
View reviewed changes
src/system/SystemPacketBuffer.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 6, 2022 •
edited
Loading

PR #19244: Size comparison from 5f0dc86 to d4fa0ab

Increases (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, p6, telink)
platform target config section 5f0dc86 d4fa0ab change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 651695 32 0.0
.text 565904 565936 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 617719 32 0.0
.text 542496 542528 32 0.0
lock-ftd LP_CC2652R7 (read only) 683027 683059 32 0.0
.text 584896 584928 32 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632467 32 0.0
.text 534416 534448 32 0.0
pump-app LP_CC2652R7 (read only) 664099 664131 32 0.0
.text 577768 577800 32 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655291 32 0.0
.text 570880 570912 32 0.0
shell LP_CC2652R7 (read only) 644702 644734 32 0.0
.text 561956 561988 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602274 32 0.0
.app_xip_area 461268 461300 32 0.0
lock cyw930739m2evb_01 (read/write) 599294 599326 32 0.0
.app_xip_area 458184 458216 32 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596942 32 0.0
.app_xip_area 456932 456964 32 0.0
efr32 lighting-app BRD4161A (read only) 916152 916200 48 0.0
.text 916144 916192 48 0.0
BRD4161A+rpc (read only) 950380 950428 48 0.0
.text 950372 950420 48 0.0
BRD4161A+rs911x (read only) 791364 791412 48 0.0
.text 791356 791404 48 0.0
lock-app BRD4161A+wf200 (read only) 958152 958184 32 0.0
.text 958144 958176 32 0.0
window-app BRD4161A (read only) 901208 901256 48 0.0
.text 901200 901248 48 0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007840 42 0.0
.flash.text 1007798 1007840 42 0.0
m5stack (read only) 1062743 1062803 60 0.0
.flash.text 1057359 1057419 60 0.0
k32w light k32w061+release (read/write) 653400 653432 32 0.0
.text 575624 575656 32 0.0
lock k32w061+release (read/write) 714380 714412 32 0.0
.text 636192 636224 32 0.0
linux chip-tool debug (read only) 9659181 9660453 1272 0.0
.got 5008 5016 8 0.2
.text 7760261 7761349 1088 0.0
p6 all-clusters-app default (read/write) 2545728 2545776 48 0.0
.text 1503992 1504040 48 0.0
all-clusters-minimal-app default (read/write) 2490592 2490640 48 0.0
.text 1448856 1448904 48 0.0
light-app default (read/write) 2422488 2422536 48 0.0
.text 1380752 1380800 48 0.0
lock-app default (read/write) 2442808 2442856 48 0.0
.text 1401072 1401120 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781008 781016 8 0.0
text 552400 552406 6 0.0
lighting-app tlsr9518adk80d text 569142 569148 6 0.0
Decreases (4 builds for cc13x2_26x2, linux)
platform target config section 5f0dc86 d4fa0ab change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 159804 159772 -32 -0.0
pump-app LP_CC2652R7 (read/write) 179636 179604 -32 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188588 188556 -32 -0.0
linux tv-app debug (read only) 2880897 2880833 -64 -0.0
.rodata 223136 223072 -64 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5f0dc86 d4fa0ab change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 651663 651695 32 0.0
(read/write) 158924 158924 0 0.0
.bss 74604 74604 0 0.0
.data 3404 3404 0 0.0
.rodata 85527 85527 0 0.0
.text 565904 565936 32 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 617687 617719 32 0.0
(read/write) 158080 158080 0 0.0
.bss 73820 73820 0 0.0
.data 3344 3344 0 0.0
.rodata 74959 74959 0 0.0
.text 542496 542528 32 0.0
lock-ftd LP_CC2652R7 (read only) 683027 683059 32 0.0
(read/write) 159804 159772 -32 -0.0
.bss 72612 72612 0 0.0
.data 3268 3268 0 0.0
.rodata 97651 97651 0 0.0
.text 584896 584928 32 0.0
lock-mtd LP_CC2652R7 (read only) 632435 632467 32 0.0
(read/write) 145732 145732 0 0.0
.bss 68348 68348 0 0.0
.data 3268 3268 0 0.0
.rodata 97531 97531 0 0.0
.text 534416 534448 32 0.0
pump-app LP_CC2652R7 (read only) 664099 664131 32 0.0
(read/write) 179636 179604 -32 -0.0
.bss 72748 72748 0 0.0
.data 3300 3300 0 0.0
.rodata 85851 85851 0 0.0
.text 577768 577800 32 0.0
pump-controller-app LP_CC2652R7 (read only) 655259 655291 32 0.0
(read/write) 188588 188556 -32 -0.0
.bss 72860 72860 0 0.0
.data 3264 3264 0 0.0
.rodata 83899 83899 0 0.0
.text 570880 570912 32 0.0
shell LP_CC2652R7 (read only) 644702 644734 32 0.0
(read/write) 154480 154480 0 0.0
.bss 76956 76956 0 0.0
.data 3408 3408 0 0.0
.rodata 82510 82510 0 0.0
.text 561956 561988 32 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602242 602274 32 0.0
.app_xip_area 461268 461300 32 0.0
.bss 83912 83912 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599294 599326 32 0.0
.app_xip_area 458184 458216 32 0.0
.bss 84080 84080 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 596910 596942 32 0.0
.app_xip_area 456932 456964 32 0.0
.bss 83044 83044 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916152 916200 48 0.0
(read/write) 133184 133184 0 0.0
.bss 131088 131088 0 0.0
.data 2096 2096 0 0.0
.text 916144 916192 48 0.0
BRD4161A+rpc (read only) 950380 950428 48 0.0
(read/write) 149876 149876 0 0.0
.bss 147576 147576 0 0.0
.data 2300 2300 0 0.0
.text 950372 950420 48 0.0
BRD4161A+rs911x (read only) 791364 791412 48 0.0
(read/write) 129460 129460 0 0.0
.bss 127356 127356 0 0.0
.data 2104 2104 0 0.0
.text 791356 791404 48 0.0
lock-app BRD4161A+wf200 (read only) 958152 958184 32 0.0
(read/write) 128252 128252 0 0.0
.bss 126180 126180 0 0.0
.data 2072 2072 0 0.0
.text 958144 958176 32 0.0
window-app BRD4161A (read only) 901208 901256 48 0.0
(read/write) 133272 133272 0 0.0
.bss 131176 131176 0 0.0
.data 2092 2092 0 0.0
.text 901200 901248 48 0.0
esp32 all-clusters-app c3devkit (read only) 1007798 1007840 42 0.0
(read/write) 1481490 1481490 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212240 212240 0 0.0
.flash.text 1007798 1007840 42 0.0
.iram0.text 62954 62954 0 0.0
m5stack (read only) 1062743 1062803 60 0.0
(read/write) 483660 483660 0 0.0
.dram0.bss 74680 74680 0 0.0
.dram0.data 34208 34208 0 0.0
.flash.rodata 242776 242776 0 0.0
.flash.text 1057359 1057419 60 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653400 653432 32 0.0
.bss 69964 69964 0 0.0
.data 2012 2012 0 0.0
.text 575624 575656 32 0.0
lock k32w061+release (read/write) 714380 714412 32 0.0
.bss 70404 70404 0 0.0
.data 1984 1984 0 0.0
.text 636192 636224 32 0.0
linux all-clusters-app debug (read only) 2779289 2779289 0 0.0
(read/write) 178568 178568 0 0.0
.bss 86368 86368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 83992 83992 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 246205 246205 0 0.0
.text 2359154 2359154 0 0.0
all-clusters-minimal-app debug (read only) 2654849 2654849 0 0.0
(read/write) 170408 170408 0 0.0
.bss 85536 85536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1024 1024 0 0.0
.rodata 247837 247837 0 0.0
.text 2234258 2234258 0 0.0
bridge-app debug+rpc (read only) 2032521 2032521 0 0.0
(read/write) 147960 147960 0 0.0
.bss 72896 72896 0 0.0
.data 3936 3936 0 0.0
.data.rel.ro 65544 65544 0 0.0
.dynamic 592 592 0 0.0
.got 4272 4272 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 169824 169824 0 0.0
.text 1706130 1706130 0 0.0
chip-tool debug (read only) 9659181 9660453 1272 0.0
(read/write) 606448 606448 0 0.0
.bss 23968 23968 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 575064 575064 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5016 8 0.2
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 497277 497277 0 0.0
.text 7760261 7761349 1088 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9409764 9409764 0 0.0
(read/write) 672401 672401 0 0.0
.bss 42257 42257 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 610256 610256 0 0.0
.dynamic 528 528 0 0.0
.got 14896 14896 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 461172 461172 0 0.0
.text 7412116 7412116 0 0.0
lighting-app debug+rpc (read only) 2322777 2322777 0 0.0
(read/write) 153632 153632 0 0.0
.bss 74752 74752 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 71064 71064 0 0.0
.dynamic 608 608 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 188744 188744 0 0.0
.text 1968210 1968210 0 0.0
lock-app debug (read only) 2266001 2266001 0 0.0
(read/write) 148736 148736 0 0.0
.bss 73472 73472 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 67992 67992 0 0.0
.dynamic 592 592 0 0.0
.got 4336 4336 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 202920 202920 0 0.0
.text 1902546 1902546 0 0.0
ota-provider-app debug (read only) 2067105 2067105 0 0.0
(read/write) 141616 141616 0 0.0
.bss 73024 73024 0 0.0
.data 1768 1768 0 0.0
.data.rel.ro 61032 61032 0 0.0
.dynamic 608 608 0 0.0
.got 4504 4504 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 181240 181240 0 0.0
.text 1726722 1726722 0 0.0
ota-requestor-app debug (read only) 2095025 2095025 0 0.0
(read/write) 144424 144424 0 0.0
.bss 73728 73728 0 0.0
.data 1960 1960 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 177152 177152 0 0.0
.text 1757266 1757266 0 0.0
shell debug (read only) 2584129 2584129 0 0.0
(read/write) 201976 201976 0 0.0
.bss 117224 117224 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 77632 77632 0 0.0
.dynamic 608 608 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 226258 226258 0 0.0
.text 2198450 2198450 0 0.0
thermostat-no-ble arm64 (read only) 2368932 2368932 0 0.0
(read/write) 177521 177521 0 0.0
.bss 87921 87921 0 0.0
.data 1528 1528 0 0.0
.data.rel.ro 80272 80272 0 0.0
.dynamic 528 528 0 0.0
.got 4792 4792 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 148804 148804 0 0.0
.text 1990432 1990432 0 0.0
tv-app debug (read only) 2880897 2880833 -64 -0.0
(read/write) 280208 280208 0 0.0
.bss 191048 191048 0 0.0
.data 4672 4672 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 592 592 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 223136 223072 -64 -0.0
.text 2475106 2475106 0 0.0
tv-casting-app debug (read only) 5330409 5330409 0 0.0
(read/write) 222704 222704 0 0.0
.bss 78632 78632 0 0.0
.data 2400 2400 0 0.0
.data.rel.ro 135440 135440 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 337408 337408 0 0.0
.text 4641762 4641762 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427240 2427240 0 0.0
.bss 202628 202628 0 0.0
.data 5880 5880 0 0.0
.text 1389884 1389884 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191507 1191507 0 0.0
bss 141297 141297 0 0.0
rodata 154236 154236 0 0.0
text 817100 817100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139227 1139227 0 0.0
bss 140514 140514 0 0.0
rodata 130748 130748 0 0.0
text 789152 789152 0 0.0
p6 all-clusters-app default (read/write) 2545728 2545776 48 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1503992 1504040 48 0.0
all-clusters-minimal-app default (read/write) 2490592 2490640 48 0.0
.bss 136336 136336 0 0.0
.data 2752 2752 0 0.0
.text 1448856 1448904 48 0.0
light-app default (read/write) 2422488 2422536 48 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1380752 1380800 48 0.0
lock-app default (read/write) 2442808 2442856 48 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1401072 1401120 48 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781008 781016 8 0.0
bss 70564 70564 0 0.0
noinit 40416 40416 0 0.0
text 552400 552406 6 0.0
lighting-app tlsr9518adk80d (read/write) 801052 801052 0 0.0
bss 70824 70824 0 0.0
noinit 40416 40416 0 0.0
text 569142 569148 6 0.0

@andy31415 andy31415 merged commit fa43c74 into project-chip:master Jun 7, 2022
@bzbarsky-apple
Copy link
Contributor

This seems to be causing boot-loops on esp32: #19289

kpschoedel added a commit that referenced this pull request Jun 7, 2022
@kpschoedel
Revert "Fix alignment when using PacketBuffer reserve space (#19244)"
f7ce63d 
This reverts commit fa43c74.
@kpschoedel kpschoedel mentioned this pull request Jun 7, 2022
Merged
bzbarsky-apple pushed a commit that referenced this pull request Jun 8, 2022
@kpschoedel
Revert "Fix alignment when using PacketBuffer reserve space (#19244)" (…
7b3fb84 
…#19293)

This reverts commit fa43c74.
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
@kpschoedel @mkardous-silabs
Revert "Fix alignment when using PacketBuffer reserve space (project-…
d3e87d5 
…chip#19244)" (project-chip#19293)

This reverts commit fa43c74.
@kpschoedel kpschoedel mentioned this pull request Jun 10, 2022
Open
@kpschoedel kpschoedel deleted the x17213 branch September 13, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
inet review - approved system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @bzbarsky-apple @andy31415