Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix alignment when using PacketBuffer reserve space" #19293

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

kpschoedel
Copy link
Contributor

@kpschoedel kpschoedel commented Jun 7, 2022

Reverts #19244

Fixes #19289 M5 board cannot be paired due to continuous crash and rebooting

@bzbarsky-apple bzbarsky-apple added the hotfix urgent fix needed, can bypass review label Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

PR #19293: Size comparison from c868f81 to f7ce63d

Increases (1 build for nrfconnect)
platform target config section c868f81 f7ce63d change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 817260 817264 4 0.0
Full report (5 builds for mbed, nrfconnect, telink)
platform target config section c868f81 f7ce63d change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429848 2429848 0 0.0
.bss 202724 202724 0 0.0
.data 5872 5872 0 0.0
.text 1392492 1392492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192179 1192179 0 0.0
bss 141378 141378 0 0.0
rodata 154628 154628 0 0.0
text 817260 817264 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139891 1139891 0 0.0
bss 140595 140595 0 0.0
rodata 131124 131124 0 0.0
text 789312 789312 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781940 781940 0 0.0
bss 70652 70652 0 0.0
noinit 40416 40416 0 0.0
text 552810 552810 0 0.0
lighting-app tlsr9518adk80d (read/write) 801952 801952 0 0.0
bss 70904 70904 0 0.0
noinit 40416 40416 0 0.0
text 569530 569530 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 7b3fb84 into master Jun 8, 2022
@bzbarsky-apple bzbarsky-apple deleted the revert-19244-x17213 branch June 8, 2022 00:30
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review inet review - pending system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M5 board cannot be paired due to continuous crash and rebooting
2 participants