Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update darwin-framework-tool to build Matter.framework on changes. #20952

Merged

Conversation

krypton36
Copy link
Contributor

Problem

When making changes to Matter.framework, darwin-framework-tool does not re-build the framework. When building we target the project which builds for multiple platforms and takes a very long times. When the building Darwin-framework-tool and the framework portion fails, it has a vague message.

Change overview

  • Update the framework to have CHIP folder as dependency for any changes that occur in there.
  • Update the xcodebuild command to target the "Matter Framework" scheme.
  • Update the xcodebuild command to have the derived data in the out folder.
  • Update the build Matter.framework log to indicate the proper failure.

Testing

  • Compiled Darwin-framework-tool
  • Modified Matter.framework after compile and re-compiled.
  • Timed compilation ~5-6min
  • Ran tool to make sure it can still run.

@github-actions
Copy link

github-actions bot commented Jul 19, 2022

PR #20952: Size comparison from 4cdecc9 to ca471d8

Increases (1 build for telink)
platform target config section 4cdecc9 ca471d8 change % change
telink light-switch-app tlsr9518adk80d text 566348 566350 2 0.0
Decreases (1 build for esp32)
platform target config section 4cdecc9 ca471d8 change % change
esp32 all-clusters-app c3devkit (read only) 1021374 1021372 -2 -0.0
.flash.text 1021374 1021372 -2 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 4cdecc9 ca471d8 change % change
bl602 lighting-app bl602 (read/write) 1379314 1379314 0 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1049952 1049952 0 0.0
bl602+rpc (read/write) 1424722 1424722 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081608 1081608 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667959 667959 0 0.0
(read/write) 183288 183288 0 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579324 579324 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633559 633559 0 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555684 555684 0 0.0
lock-ftd LP_CC2652R7 (read only) 671067 671067 0 0.0
(read/write) 170356 170356 0 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594144 594144 0 0.0
lock-mtd LP_CC2652R7 (read only) 653343 653343 0 0.0
(read/write) 183768 183768 0 0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551672 551672 0 0.0
pump-app LP_CC2652R7 (read only) 680059 680059 0 0.0
(read/write) 162212 162212 0 0.0
.bss 71284 71284 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590764 590764 0 0.0
pump-controller-app LP_CC2652R7 (read only) 665843 665843 0 0.0
(read/write) 176548 176548 0 0.0
.bss 71404 71404 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580688 580688 0 0.0
shell LP_CC2652R7 (read only) 660434 660434 0 0.0
(read/write) 186316 186316 0 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575028 575028 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581382 581382 0 0.0
.app_xip_area 459936 459936 0 0.0
.bss 64240 64240 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587290 587290 0 0.0
.app_xip_area 461116 461116 0 0.0
.bss 68968 68968 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584738 584738 0 0.0
.app_xip_area 464140 464140 0 0.0
.bss 63448 63448 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085616 1085616 0 0.0
.bss 133052 133052 0 0.0
.data 2048 2048 0 0.0
.text 950496 950496 0 0.0
BRD4161A+rpc (read/write) 1139916 1139916 0 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 987900 987900 0 0.0
BRD4161A+rs911x (read/write) 950840 950840 0 0.0
.bss 140776 140776 0 0.0
.data 2048 2048 0 0.0
.text 807996 807996 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127228 1127228 0 0.0
.bss 144144 144144 0 0.0
.data 2056 2056 0 0.0
.text 981008 981008 0 0.0
window-app BRD4161A (read/write) 1079108 1079108 0 0.0
.bss 134524 134524 0 0.0
.data 2076 2076 0 0.0
.text 942488 942488 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021374 1021372 -2 -0.0
(read/write) 1486042 1486042 0 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215912 215912 0 0.0
.flash.text 1021374 1021372 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075171 1075171 0 0.0
(read/write) 488072 488072 0 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246324 246324 0 0.0
.flash.text 1069787 1069787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660176 660176 0 0.0
.bss 69548 69548 0 0.0
.data 1992 1992 0 0.0
.text 582836 582836 0 0.0
lock k32w061+release (read/write) 687148 687148 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609332 609332 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10055644 10055644 0 0.0
(read/write) 694801 694801 0 0.0
.bss 42993 42993 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 630920 630920 0 0.0
.dynamic 528 528 0 0.0
.got 13656 13656 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 480028 480028 0 0.0
.text 7995252 7995252 0 0.0
thermostat-no-ble arm64 (read only) 2603180 2603180 0 0.0
(read/write) 158481 158481 0 0.0
.bss 65281 65281 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83368 0 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165748 165748 0 0.0
.text 2197136 2197136 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448416 2448416 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411060 1411060 0 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685196 1685196 0 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525592 1525592 0 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629324 1629324 0 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470440 1470440 0 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549332 1549332 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1398752 1398752 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576332 1576332 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1425880 1425880 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798212 798212 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566348 566350 2 0.0
lighting-app tlsr9518adk80d (read/write) 818260 818260 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 582892 582892 0 0.0

@woody-apple woody-apple enabled auto-merge (squash) July 19, 2022 20:54
@woody-apple woody-apple merged commit e039344 into project-chip:master Jul 19, 2022
woody-apple added a commit that referenced this pull request Jul 20, 2022
…20952) (#20968)

Co-authored-by: Joshua Villasenor <jvillasenor@apple.com>
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error on M1 Mac while trying to build darwin-framework-tool
3 participants