Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update darwin-framework-tool to build Matter.framework on changes. #20968

Merged

Conversation

woody-apple
Copy link
Contributor

Problem

When making changes to Matter.framework, darwin-framework-tool does not re-build the framework. When building we target the project which builds for multiple platforms and takes a very long times. When the building Darwin-framework-tool and the framework portion fails, it has a vague message.

Change overview

  • Update the framework to have CHIP folder as dependency for any changes that occur in there.
  • Update the xcodebuild command to target the "Matter Framework" scheme.
  • Update the xcodebuild command to have the derived data in the out folder.
  • Update the build Matter.framework log to indicate the proper failure.

Testing

  • Compiled Darwin-framework-tool
  • Modified Matter.framework after compile and re-compiled.
  • Timed compilation ~5-6min
  • Ran tool to make sure it can still run.

@woody-apple woody-apple enabled auto-merge (squash) July 19, 2022 23:12
@github-actions
Copy link

github-actions bot commented Jul 20, 2022

PR #20968: Size comparison from ab19bab to 47a5484

Increases (2 builds for cc13x2_26x2, telink)
platform target config section ab19bab 47a5484 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 679843 679851 8 0.0
.text 590548 590556 8 0.0
telink lighting-app tlsr9518adk80d text 582892 582894 2 0.0
Decreases (2 builds for cc13x2_26x2, esp32)
platform target config section ab19bab 47a5484 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 162428 162420 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1021374 1021372 -2 -0.0
.flash.text 1021374 1021372 -2 -0.0
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ab19bab 47a5484 change % change
bl602 lighting-app bl602 (read/write) 1379314 1379314 0 0.0
.bss 116970 116970 0 0.0
.data 4480 4480 0 0.0
.text 1049952 1049952 0 0.0
bl602+rpc (read/write) 1424490 1424490 0 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1081380 1081380 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 667759 667759 0 0.0
(read/write) 183488 183488 0 0.0
.bss 74140 74140 0 0.0
.data 3356 3356 0 0.0
.rodata 88319 88319 0 0.0
.text 579124 579124 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633351 633351 0 0.0
(read/write) 157708 157708 0 0.0
.bss 73436 73436 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555476 555476 0 0.0
lock-ftd LP_CC2652R7 (read only) 670851 670851 0 0.0
(read/write) 170572 170572 0 0.0
.bss 71204 71204 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 593928 593928 0 0.0
lock-mtd LP_CC2652R7 (read only) 653135 653135 0 0.0
(read/write) 183976 183976 0 0.0
.bss 66892 66892 0 0.0
.data 3280 3280 0 0.0
.rodata 101191 101191 0 0.0
.text 551464 551464 0 0.0
pump-app LP_CC2652R7 (read only) 679843 679851 8 0.0
(read/write) 162428 162420 -8 -0.0
.bss 71284 71284 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590548 590556 8 0.0
pump-controller-app LP_CC2652R7 (read only) 665635 665635 0 0.0
(read/write) 176756 176756 0 0.0
.bss 71404 71404 0 0.0
.data 3276 3276 0 0.0
.rodata 84675 84675 0 0.0
.text 580480 580480 0 0.0
shell LP_CC2652R7 (read only) 660226 660226 0 0.0
(read/write) 186524 186524 0 0.0
.bss 76444 76444 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 574820 574820 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581166 581166 0 0.0
.app_xip_area 459864 459864 0 0.0
.bss 64240 64240 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587082 587082 0 0.0
.app_xip_area 461052 461052 0 0.0
.bss 68968 68968 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 584530 584530 0 0.0
.app_xip_area 464076 464076 0 0.0
.bss 63448 63448 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1085616 1085616 0 0.0
.bss 133052 133052 0 0.0
.data 2048 2048 0 0.0
.text 950496 950496 0 0.0
BRD4161A+rpc (read/write) 1139948 1139948 0 0.0
.bss 149732 149732 0 0.0
.data 2260 2260 0 0.0
.text 987932 987932 0 0.0
BRD4161A+rs911x (read/write) 950840 950840 0 0.0
.bss 140776 140776 0 0.0
.data 2048 2048 0 0.0
.text 807996 807996 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127228 1127228 0 0.0
.bss 144144 144144 0 0.0
.data 2056 2056 0 0.0
.text 981008 981008 0 0.0
window-app BRD4161A (read/write) 1079108 1079108 0 0.0
.bss 134524 134524 0 0.0
.data 2076 2076 0 0.0
.text 942488 942488 0 0.0
esp32 all-clusters-app c3devkit (read only) 1021374 1021372 -2 -0.0
(read/write) 1486042 1486042 0 0.0
.dram0.bss 70088 70088 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215912 215912 0 0.0
.flash.text 1021374 1021372 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075171 1075171 0 0.0
(read/write) 488072 488072 0 0.0
.dram0.bss 75608 75608 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246324 246324 0 0.0
.flash.text 1069787 1069787 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659952 659952 0 0.0
.bss 69548 69548 0 0.0
.data 1992 1992 0 0.0
.text 582612 582612 0 0.0
lock k32w061+release (read/write) 686924 686924 0 0.0
.bss 70012 70012 0 0.0
.data 2004 2004 0 0.0
.text 609108 609108 0 0.0
linux all-clusters-app debug (read only) 2976489 2976489 0 0.0
(read/write) 155152 155152 0 0.0
.bss 61696 61696 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 85160 85160 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 264797 264797 0 0.0
.text 2533714 2533714 0 0.0
all-clusters-minimal-app debug (read only) 2823049 2823049 0 0.0
(read/write) 146824 146824 0 0.0
.bss 60896 60896 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77720 77720 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 265725 265725 0 0.0
.text 2382002 2382002 0 0.0
bridge-app debug+rpc (read only) 2323161 2323161 0 0.0
(read/write) 125640 125640 0 0.0
.bss 48960 48960 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 67096 67096 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 198240 198240 0 0.0
.text 1962898 1962898 0 0.0
chip-tool debug (read only) 10316289 10316289 0 0.0
(read/write) 629640 629640 0 0.0
.bss 24760 24760 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 595256 595256 0 0.0
.dynamic 608 608 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 516085 516085 0 0.0
.text 8351892 8351892 0 0.0
chip-tool-ipv6only arm64 (read only) 10055212 10055212 0 0.0
(read/write) 694801 694801 0 0.0
.bss 42993 42993 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 630920 630920 0 0.0
.dynamic 528 528 0 0.0
.got 13656 13656 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 480028 480028 0 0.0
.text 7994820 7994820 0 0.0
lighting-app debug+rpc (read only) 2560953 2560953 0 0.0
(read/write) 129664 129664 0 0.0
.bss 49472 49472 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72248 72248 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 214024 214024 0 0.0
.text 2176674 2176674 0 0.0
lock-app debug (read only) 2525785 2525785 0 0.0
(read/write) 124648 124648 0 0.0
.bss 47872 47872 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69208 69208 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 229064 229064 0 0.0
.text 2131266 2131266 0 0.0
ota-provider-app debug (read only) 2329345 2329345 0 0.0
(read/write) 118448 118448 0 0.0
.bss 47520 47520 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63192 63192 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 203832 203832 0 0.0
.text 1962450 1962450 0 0.0
ota-requestor-app debug (read only) 2447945 2447945 0 0.0
(read/write) 125384 125384 0 0.0
.bss 49888 49888 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67416 67416 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 207584 207584 0 0.0
.text 2068898 2068898 0 0.0
shell debug (read only) 2563345 2563345 0 0.0
(read/write) 141240 141240 0 0.0
.bss 57480 57480 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76792 76792 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 228178 228178 0 0.0
.text 2177778 2177778 0 0.0
thermostat-no-ble arm64 (read only) 2603036 2603036 0 0.0
(read/write) 158481 158481 0 0.0
.bss 65281 65281 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83368 83368 0 0.0
.dynamic 528 528 0 0.0
.got 5104 5104 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165748 165748 0 0.0
.text 2196992 2196992 0 0.0
tv-app debug (read only) 3111393 3111393 0 0.0
(read/write) 256752 256752 0 0.0
.bss 166856 166856 0 0.0
.data 4720 4720 0 0.0
.data.rel.ro 78728 78728 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 249568 249568 0 0.0
.text 2673570 2673570 0 0.0
tv-casting-app debug (read only) 5359297 5359297 0 0.0
(read/write) 157800 157800 0 0.0
.bss 51048 51048 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 98032 98032 0 0.0
.dynamic 608 608 0 0.0
.got 4736 4736 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 332841 332841 0 0.0
.text 4760770 4760770 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448416 2448416 0 0.0
.bss 213948 213948 0 0.0
.data 5872 5872 0 0.0
.text 1411060 1411060 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175875 1175875 0 0.0
bss 142908 142908 0 0.0
rodata 142204 142204 0 0.0
text 811864 811864 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155939 1155939 0 0.0
bss 142144 142144 0 0.0
rodata 133748 133748 0 0.0
text 801176 801176 0 0.0
p6 all-clusters-app default (read only) 882128 882128 0 0.0
(read/write) 1685196 1685196 0 0.0
.bss 148568 148568 0 0.0
.data 2648 2648 0 0.0
.text 1525592 1525592 0 0.0
all-clusters-minimal-app default (read only) 882848 882848 0 0.0
(read/write) 1629324 1629324 0 0.0
.bss 147848 147848 0 0.0
.data 2648 2648 0 0.0
.text 1470440 1470440 0 0.0
light-app default (read only) 891152 891152 0 0.0
(read/write) 1549332 1549332 0 0.0
.bss 139752 139752 0 0.0
.data 2440 2440 0 0.0
.text 1398752 1398752 0 0.0
lock-app default (read only) 891280 891280 0 0.0
(read/write) 1576332 1576332 0 0.0
.bss 139608 139608 0 0.0
.data 2456 2456 0 0.0
.text 1425880 1425880 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798212 798212 0 0.0
bss 70584 70584 0 0.0
noinit 40416 40416 0 0.0
text 566348 566348 0 0.0
lighting-app tlsr9518adk80d (read/write) 818260 818260 0 0.0
bss 71428 71428 0 0.0
noinit 40416 40416 0 0.0
text 582892 582894 2 0.0

@woody-apple woody-apple merged commit 88aa1a5 into sve Jul 20, 2022
@woody-apple woody-apple deleted the cherry-pick-e03934405030148c0b8d383eb8eea21f4a5164a4 branch July 20, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants