[ColorControl] Enhanced commands should set EnhancedColorMode to 3 #22580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #22580: Size comparison from 5caec5a to cc99b49 Increases (24 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc13x2_26x2, esp32)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
requested changes
Sep 13, 2022
There was a problem hiding this comment.
Your patch works for that one case but the real issue lies within the function handleModeSwitch
In fact, I see it was patched the same way you are doing before for moveToHueCommand and I didn't catch it in that PR.
The real fix would add the EnhancedCurrentHue and CurrentSaturation mode (COLOR_MODE_EHSV = 0x03) in this enum in
src/app/clusters/color-control-server/color-control-server.h
enum ColorMode
{
COLOR_MODE_HSV = 0x00,
COLOR_MODE_CIE_XY = 0x01,
COLOR_MODE_TEMPERATURE = 0x02
};
Check and correct all the calls of handleModeSwitch(endpoint, COLOR_MODE_HSV); to pass as argument the new COLOR_MODE_EHSV mode if the command's isEnhanced==true
In handleModeSwitch, add a check to transpose COLOR_MODE_EHSV to COLOR_MODE_HSV for the standard Attributes::ColorMode::Set(endpoint, newColorMode);
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
yufengwangca,
wbschiller,
tecimovic,
woody-apple,
vijs,
xylophone21 and
vivien-apple
|
Updated PR description |
pankore
changed the title
jmartinez-silabs
approved these changes
Sep 14, 2022
|
Thank you |
|
Accepted for 1.0: spec fix to pass cert |
andy31415
approved these changes
Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…roject-chip#22580) * [ColorControl] Set EnhancedColorMode to 3 during enhanced-move-to-hue-and-saturation * [ColorControl] Update handleModeSwitch to set EnhancedColorMode
|
@andy31415 @woody-apple can we cherry pick this onto SVE-2 branch please ? |
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Sep 21, 2022
…roject-chip#22580) * [ColorControl] Set EnhancedColorMode to 3 during enhanced-move-to-hue-and-saturation * [ColorControl] Update handleModeSwitch to set EnhancedColorMode
Merged
q-thla
pushed a commit
to Qorvo/connectedhomeip
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
COLOR_MODE_EHSV = 0x03in ColorMode enumhandleModeSwitch(endpoint, COLOR_MODE_EHSV)for all commands that are enhancedhandleModeSwitchwill set EnhancedColorMode to 3 if command is enhanced and set ColorMode to 0Testing