-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Mark GLib source as removed when exiting callback #22841
Conversation
753630a
to
d47b7ee
Compare
PR #22841: Size comparison from efb8f2f to d47b7ee Increases (7 builds for bl602, cc13x2_26x2, nrfconnect, telink)
Decreases (5 builds for bl702, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
d47b7ee
to
92103dd
Compare
PR #22841: Size comparison from dc66d4e to 92103dd Increases (6 builds for bl702, cc13x2_26x2, linux, psoc6)
Decreases (8 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
47c853f
to
fa46c8f
Compare
PR #22841: Size comparison from f2cd15f to fa46c8f Increases (6 builds for cc13x2_26x2, efr32, esp32, linux, psoc6)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding checkmark, but please add some TODO at least to also investigate behavior if we need to set mWatch = 0. I am very unclear what "add watch" actually does and it feels somehow like a handle that we can leak/lose here.
fa46c8f
to
364644b
Compare
PR #22841: Size comparison from a6ecd62 to 364644b Decreases (2 builds for bl702, qpg)
Full report (10 builds for bl702, mbed, nrfconnect, qpg, telink)
|
PR #22841: Size comparison from a6ecd62 to 86a3961 Increases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (2 builds for cc13x2_26x2, linux)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Issue Being Resolved
Change overview