-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter by vendor/product id (if available) in SetUpCodePairer. #23019
Merged
woody-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:filter-by-vendor-id
Oct 5, 2022
Merged
Filter by vendor/product id (if available) in SetUpCodePairer. #23019
woody-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:filter-by-vendor-id
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
October 4, 2022 14:36
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
October 4, 2022 14:36
andy31415
reviewed
Oct 4, 2022
andy31415
approved these changes
Oct 4, 2022
PR #23019: Size comparison from 87eee2d to 71f25aa Increases (2 builds for linux, qpg)
Decreases (10 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Oct 4, 2022
PR #23019: Size comparison from 87eee2d to 94feeb4 Increases (12 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, qpg, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
If we have vendor/product information, from a QR code or long manual code, we should use that to filter out advertisements for other vendors or products.
bzbarsky-apple
force-pushed
the
filter-by-vendor-id
branch
from
October 5, 2022 03:14
94feeb4
to
a1be44c
Compare
PR #23019: Size comparison from bcc99dd to a1be44c Increases (5 builds for bl602, bl702, cc13x2_26x2, linux, psoc6)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have vendor/product information, from a QR code or long manual code, we should use that to filter out advertisements for other vendors or products.