Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix session selection to actually select the most recently active session. #23246

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix session selection to actually select the most recently active session. #23246

merged 1 commit into from
Oct 18, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

We were actually selecting the least recently active one.

@bzbarsky-apple
Fix session selection to actually select the most recently active ses…
f5d1b97 
…sion.

We were actually selecting the least recently active one.
@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

PR #23246: Size comparison from 4e17011 to f5d1b97

Increases (3 builds for cc13x2_26x2, esp32, telink)
platform target config section 4e17011 f5d1b97 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677343 677351 8 0.0
.text 587240 587248 8 0.0
esp32 all-clusters-app m5stack (read/write) 564228 564236 8 0.0
.flash.rodata 314928 314936 8 0.0
telink lighting-app tlsr9518adk80d text 571552 571554 2 0.0
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section 4e17011 f5d1b97 change % change
bl602 lighting-app bl602 .text 1069372 1069370 -2 -0.0
bl602+rpc .text 1100720 1100716 -4 -0.0
bl702 lighting-app bl702 (read/write) 1188963 1188947 -16 -0.0
.debug_info 37908924 37908754 -170 -0.0
.debug_line 5257423 5257407 -16 -0.0
.text 957314 957308 -6 -0.0
bl702+rpc .debug_info 41815539 41815370 -169 -0.0
.debug_line 5631954 5631938 -16 -0.0
.text 1030760 1030756 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174216 174208 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1223548 1223546 -2 -0.0
(read/write) 1788318 1788310 -8 -0.0
.flash.rodata 257872 257864 -8 -0.0
.flash.text 1223548 1223546 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26837449 26837274 -175 -0.0
.debug_line 3673074 3673065 -9 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26574231 26574055 -176 -0.0
.debug_line 3693791 3693782 -9 -0.0
light cy8ckit_062s2_43012 .debug_info 22037954 22037777 -177 -0.0
.debug_line 3263715 3263706 -9 -0.0
lock cy8ckit_062s2_43012 .debug_info 22271243 22271069 -174 -0.0
.debug_line 3260680 3260671 -9 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 789364 789356 -8 -0.0
text 553134 553132 -2 -0.0
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 4e17011 f5d1b97 change % change
bl602 lighting-app bl602 (read/write) 1389982 1389982 0 0.0
.bss 90745 90745 0 0.0
.data 9928 9928 0 0.0
.text 1069372 1069370 -2 -0.0
bl602+rpc (read/write) 1435198 1435198 0 0.0
.bss 98177 98177 0 0.0
.data 10312 10312 0 0.0
.text 1100720 1100716 -4 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188963 1188947 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67118 67118 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1507059 1507059 0 0.0
.debug_aranges 133144 133144 0 0.0
.debug_frame 486648 486648 0 0.0
.debug_info 37908924 37908754 -170 -0.0
.debug_line 5257423 5257407 -16 -0.0
.debug_loc 3367638 3367638 0 0.0
.debug_ranges 359456 359456 0 0.0
.debug_str 3457927 3457927 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116744 116744 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565127 565127 0 0.0
.symtab 171680 171680 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957314 957308 -6 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284627 1284627 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644604 1644604 0 0.0
.debug_aranges 140648 140648 0 0.0
.debug_frame 512020 512020 0 0.0
.debug_info 41815539 41815370 -169 -0.0
.debug_line 5631954 5631938 -16 -0.0
.debug_loc 3560285 3560285 0 0.0
.debug_ranges 381912 381912 0 0.0
.debug_str 3853897 3853897 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130136 130136 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624300 624300 0 0.0
.symtab 189488 189488 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030760 1030756 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677343 677351 8 0.0
(read/write) 174216 174208 -8 -0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89791 89791 0 0.0
.text 587240 587248 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641599 641599 0 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 78927 78927 0 0.0
.text 562352 562352 0 0.0
lock-ftd LP_CC2652R7 (read only) 675851 675851 0 0.0
(read/write) 172844 172844 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77315 77315 0 0.0
.text 598056 598056 0 0.0
lock-mtd LP_CC2652R7 (read only) 659607 659607 0 0.0
(read/write) 184776 184776 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103135 103135 0 0.0
.text 555992 555992 0 0.0
pump-app LP_CC2652R7 (read only) 688091 688091 0 0.0
(read/write) 161340 161340 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90731 90731 0 0.0
.text 596876 596876 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672423 672423 0 0.0
(read/write) 177104 177104 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86287 86287 0 0.0
.text 585656 585656 0 0.0
shell LP_CC2652R7 (read only) 668374 668374 0 0.0
(read/write) 185504 185504 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86502 86502 0 0.0
.text 581556 581556 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588130 588130 0 0.0
.app_xip_area 464716 464716 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592170 592170 0 0.0
.app_xip_area 463460 463460 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543966 543966 0 0.0
.app_xip_area 425632 425632 0 0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974060 974060 0 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 819516 819516 0 0.0
BRD4161A+rs911x (read/write) 1031208 1031208 0 0.0
.bss 186680 186680 0 0.0
.data 2092 2092 0 0.0
.text 842416 842416 0 0.0
BRD4187C (read/write) 1146116 1146116 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980260 980260 0 0.0
lock-app BRD4161A+wf200 (read/write) 1157008 1157008 0 0.0
.bss 158208 158208 0 0.0
.data 2100 2100 0 0.0
.text 996680 996680 0 0.0
window-app BRD4187C (read/write) 1139336 1139336 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972040 972040 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223548 1223546 -2 -0.0
(read/write) 1788318 1788310 -8 -0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257872 257864 -8 -0.0
.flash.text 1223548 1223546 -2 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233623 1233623 0 0.0
(read/write) 564228 564236 8 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314928 314936 8 0.0
.flash.text 1228239 1228239 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661268 661268 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563012 563012 0 0.0
light k32w0+release (read/write) 671480 671480 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 591852 591852 0 0.0
lock k32w0+release (read/write) 633076 633076 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 552668 552668 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452168 2452168 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1414812 1414812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1183627 1183627 0 0.0
bss 144457 144457 0 0.0
rodata 144396 144396 0 0.0
text 815888 815888 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1162311 1162311 0 0.0
bss 143684 143684 0 0.0
rodata 135968 135968 0 0.0
text 803780 803780 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745420 1745420 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229571 1229571 0 0.0
.debug_aranges 111880 111880 0 0.0
.debug_frame 373556 373556 0 0.0
.debug_info 26837449 26837274 -175 -0.0
.debug_line 3673074 3673065 -9 -0.0
.debug_loc 3590247 3590247 0 0.0
.debug_ranges 339736 339736 0 0.0
.debug_str 3441330 3441330 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569695 569695 0 0.0
.symtab 421232 421232 0 0.0
.text 1545640 1545640 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688004 1688004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221370 1221370 0 0.0
.debug_aranges 111352 111352 0 0.0
.debug_frame 376636 376636 0 0.0
.debug_info 26574231 26574055 -176 -0.0
.debug_line 3693791 3693782 -9 -0.0
.debug_loc 3577884 3577884 0 0.0
.debug_ranges 338352 338352 0 0.0
.debug_str 3430343 3430343 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533784 533784 0 0.0
.symtab 407664 407664 0 0.0
.text 1488960 1488960 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1606572 1606572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055481 1055481 0 0.0
.debug_aranges 103560 103560 0 0.0
.debug_frame 346968 346968 0 0.0
.debug_info 22037954 22037777 -177 -0.0
.debug_line 3263715 3263706 -9 -0.0
.debug_loc 3275846 3275846 0 0.0
.debug_ranges 303656 303656 0 0.0
.debug_str 3235875 3235875 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470161 470161 0 0.0
.symtab 376112 376112 0 0.0
.text 1415712 1415712 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640260 1640260 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1057420 1057420 0 0.0
.debug_aranges 103952 103952 0 0.0
.debug_frame 348824 348824 0 0.0
.debug_info 22271243 22271069 -174 -0.0
.debug_line 3260680 3260671 -9 -0.0
.debug_loc 3303427 3303427 0 0.0
.debug_ranges 305592 305592 0 0.0
.debug_str 3255273 3255273 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472512 472512 0 0.0
.symtab 377728 377728 0 0.0
.text 1444408 1444408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148808 1148808 0 0.0
.bss 110580 110580 0 0.0
.data 832 832 0 0.0
.text 595908 595908 0 0.0
lock-app qpg6105+debug (read/write) 1113696 1113696 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 560792 560792 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 789364 789356 -8 -0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 553134 553132 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 811684 811684 0 0.0
bss 73344 73344 0 0.0
noinit 43520 43520 0 0.0
text 571552 571554 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 819412 819412 0 0.0
bss 74236 74236 0 0.0
noinit 43520 43520 0 0.0
text 577538 577538 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit c279578 into project-chip:master Oct 18, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-session-selection branch October 18, 2022 19:32
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 19, 2022
@bzbarsky-apple
Fix session selection to actually select the most recently active ses…
01670fb 
…sion. (project-chip#23246)

We were actually selecting the least recently active one.
@bzbarsky-apple
Copy link
Contributor Author

Created #23263 to see if we can cherry-pick this to 1.0.

@bzbarsky-apple bzbarsky-apple mentioned this pull request Oct 20, 2022
Closed
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 20, 2022
@bzbarsky-apple
Fix session selection to actually select the most recently active ses…
72f50b1 
…sion. (project-chip#23246)

We were actually selecting the least recently active one.
andy31415 pushed a commit that referenced this pull request Oct 21, 2022
@bzbarsky-apple
Fix session selection to actually select the most recently active ses…
4a3f2d5 
…sion. (#23246) (#23263)

We were actually selecting the least recently active one.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Fix session selection to actually select the most recently active ses…
fcc3480 
…sion. (project-chip#23246)

We were actually selecting the least recently active one.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Fix session selection to actually select the most recently active ses…
81fc9c2 
…sion. (project-chip#23246)

We were actually selecting the least recently active one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple vivien-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @tcarmelveilleux @msandstedt @vivien-apple @andy31415