-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.0 cherrypick] Fix session selection to actually select the most recently active session. (#23246) #23263
Merged
andy31415
merged 1 commit into
project-chip:v1.0-branch
from
bzbarsky-apple:cherry-pick-c279578c5bc37f117335aa96cec6c5552f070cc0-for-1.0
Oct 21, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23263: Size comparison from a0595f4 to 01670fb Increases (3 builds for k32w, telink)
Decreases (7 builds for bl602, bl702, linux, telink)
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, telink)
|
andy31415
approved these changes
Oct 19, 2022
PR #23263: Size comparison from 3c7d78f to 46b3a74 Increases (1 build for qpg)
Decreases (4 builds for bl702, linux)
Full report (6 builds for bl702, linux, qpg)
|
…sion. (project-chip#23246) We were actually selecting the least recently active one.
bzbarsky-apple
force-pushed
the
cherry-pick-c279578c5bc37f117335aa96cec6c5552f070cc0-for-1.0
branch
from
October 20, 2022 15:16
46b3a74
to
72f50b1
Compare
PR #23263: Size comparison from 3c7d78f to 72f50b1 Increases (3 builds for cc13x2_26x2, qpg, telink)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, efr32, linux, nrfconnect, psoc6, qpg)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
deleted the
cherry-pick-c279578c5bc37f117335aa96cec6c5552f070cc0-for-1.0
branch
October 22, 2022 04:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were actually selecting the least recently active one.