-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SED] Fix Commissioning with Long Idle time #23936
[SED] Fix Commissioning with Long Idle time #23936
Conversation
50d7e81
to
630febf
Compare
630febf
to
f568da0
Compare
f568da0
to
93ca4a5
Compare
PR #23936: Size comparison from 8eb6e67 to 93ca4a5 Increases (11 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, k32w, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23936: Size comparison from 8eb6e67 to ce66696 Increases above 0.2%:
Increases (26 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (15 builds for bl702, cc13x2_26x2, efr32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
b312586
to
20025d3
Compare
PR #23936: Size comparison from 29426b4 to 20025d3 Increases (10 builds for bl602, bl702, cc13x2_26x2, k32w, psoc6)
Decreases (4 builds for cc13x2_26x2, esp32, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Just a note: This doesn't quite implement what I think it was aiming to implement. The goal was "stay in active mode while we are commissioning". What actually got implemented is "stay in active mode until commissioning completes or commissioning window closes, whichever happens first". But that second thing can still be while we are in the middle of commissioning. |
Commissioning fails with long Sleep period because device goes into Idle mode prior to completing the commissioning.
Fix that by always enabling Active mode at the start of the commissioning process and always disabling it at the end. Without any condition whatsoever.