-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TI] Factory Reset updates for CC13X2_26X2 #23963
Merged
andy31415
merged 16 commits into
project-chip:master
from
abiradarti:cc13xx_cc26xx_factory_reset
Jan 4, 2023
Merged
[TI] Factory Reset updates for CC13X2_26X2 #23963
andy31415
merged 16 commits into
project-chip:master
from
abiradarti:cc13xx_cc26xx_factory_reset
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 7, 2022 21:50
PR #23963: Size comparison from af8161c to 4f379d3 Increases (6 builds for esp32, psoc6, telink)
Decreases (7 builds for bl602, bl702, efr32, esp32, nrfconnect, qpg)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23963: Size comparison from af8161c to 5bb1c95 Full report (3 builds for nrfconnect)
|
ReneJosefsen
reviewed
Dec 9, 2022
pullapprove
bot
requested review from
ksperling-apple
and removed request for
isiu-apple
December 9, 2022 19:53
andy31415
reviewed
Dec 9, 2022
examples/platform/cc13x2_26x2/CC13X2_26X2DeviceAttestationCreds.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Dec 9, 2022
examples/platform/cc13x2_26x2/CC13X2_26X2DeviceAttestationCreds.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Dec 9, 2022
examples/platform/cc13x2_26x2/CC13X2_26X2DeviceAttestationCreds.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Dec 9, 2022
andy31415
approved these changes
Dec 9, 2022
PR #23963: Size comparison from 506c709 to 84c6e91 Increases (14 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
reviewed
Dec 9, 2022
…onnectedhomeip into cc13xx_cc26xx_factory_reset
ReneJosefsen
approved these changes
Dec 12, 2022
PR #23963: Size comparison from b49c3ed to ce6ee25 Increases (12 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (10 builds for cc13x2_26x2, cyw30739, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* factory reset updates * Restyled by whitespace * Restyled by clang-format * CI fixes * Restyled by clang-format * Restyled by gn * updated 3 keys from factory to counters itemID * Restyled by whitespace * Restyled by clang-format * PR feedback * Restyled by clang-format * removed extern C and log function in DAC file * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Factory Reset functionality on the CC13X2_26X2 needed to be updated so that the correct set of data would be erased upon a factory reset, and so that the function would not exit in the middle of execution. In addition, the Device Attestation Credentials need to be updated for commissioning to be successful. The DAC updates have been made for only the pump-app in this PR, another PR with updates for the rest of the applications will follow shortly.