-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QPG] Remove overrules for OpenThread buffer amount. #23972
Merged
andy31415
merged 1 commit into
project-chip:master
from
tima-q:qpg/openthread_buffers_default
Dec 8, 2022
Merged
[QPG] Remove overrules for OpenThread buffer amount. #23972
andy31415
merged 1 commit into
project-chip:master
from
tima-q:qpg/openthread_buffers_default
Dec 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will use the default 44 from OpenThread the stack
pullapprove
bot
requested review from
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
December 8, 2022 13:01
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
December 8, 2022 13:01
PR #23972: Size comparison from 6ccbb7c to 5857d1d Increases above 0.2%:
Increases (9 builds for cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Dec 8, 2022
andy31415
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenThread buffer configuration was overruled to 22 or 44 buffers according to MTD/FTD role.
22 has proven to be on the edge of a usable system.
To simplify and create consistent behavior a move to 44 buffers is done.
As this 44 is the default of the OpenThread stack, overrule is simply removed.
Tested by profiling buffer use on several certification TC's + interaction with Apple/Google eco-systems