Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "utc" type. #23985

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Remove "utc" type. #23985

merged 1 commit into from
Dec 9, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

It's deprecated in the spec, and is just an alias for epoch_s. And we were not handling it correctly in our code, so using it would break things.

Fixes #23982

@bzbarsky-apple
Remove "utc" type.
18b92c9 
It's deprecated in the spec, and is just an alias for epoch_s.  And we
were not handling it correctly in our code, so using it would break
things.

Fixes project-chip#23982
@github-actions
Copy link

github-actions bot commented Dec 9, 2022 •
edited
Loading

PR #23985: Size comparison from 4cb51b4 to 18b92c9

Increases (5 builds for bl602, linux, psoc6)
platform target config section 4cb51b4 18b92c9 change % change
bl602 lighting-app bl602 (read/write) 1355174 1355182 8 0.0
.text 1037904 1037906 2 0.0
linux chip-tool debug (read only) 11248841 11248873 32 0.0
.rodata 604901 604933 32 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_line 3707324 3707325 1 0.0
.debug_loc 3620989 3621002 13 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_line 3726261 3726262 1 0.0
.debug_loc 3608595 3608608 13 0.0
light cy8ckit_062s2_43012 .debug_line 3293587 3293589 2 0.0
.debug_loc 3306485 3306515 30 0.0
Decreases (13 builds for bl702, esp32, nrfconnect, psoc6, qpg, telink)
platform target config section 4cb51b4 18b92c9 change % change
bl702 lighting-app bl702 .debug_info 39221988 39221958 -30 -0.0
.debug_str 3479647 3479624 -23 -0.0
bl702+rpc .debug_info 43520270 43520234 -36 -0.0
esp32 all-clusters-app c3devkit (read only) 1218896 1218894 -2 -0.0
(read/write) 1790954 1790938 -16 -0.0
.flash.rodata 248312 248296 -16 -0.0
.flash.text 1218896 1218894 -2 -0.0
m5stack (read/write) 564179 564175 -4 -0.0
.flash.rodata 314092 314088 -4 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 790048 790044 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27069401 27069365 -36 -0.0
.debug_str 3449307 3449284 -23 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26806219 26806182 -37 -0.0
.debug_str 3438319 3438296 -23 -0.0
light cy8ckit_062s2_43012 .debug_info 22268887 22268855 -32 -0.0
.debug_str 3243905 3243882 -23 -0.0
lock cy8ckit_062s2_43012 .debug_info 22487081 22487057 -24 -0.0
.debug_line 3293338 3293336 -2 -0.0
.debug_loc 3327912 3327882 -30 -0.0
.debug_str 3259748 3259725 -23 -0.0
qpg lighting-app qpg6105+debug (read/write) 1151252 1151244 -8 -0.0
.text 598352 598344 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 1031092 1031084 -8 -0.0
text 704658 704656 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 952516 952508 -8 -0.0
text 651266 651264 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 1033932 1033924 -8 -0.0
text 719650 719648 -2 -0.0
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 4cb51b4 18b92c9 change % change
bl602 lighting-app bl602 (read/write) 1355174 1355182 8 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037904 1037906 2 0.0
bl602+rpc (read/write) 1400958 1400958 0 0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069326 1069326 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195583 1195583 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67182 67182 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529227 1529227 0 0.0
.debug_aranges 132680 132680 0 0.0
.debug_frame 486788 486788 0 0.0
.debug_info 39221988 39221958 -30 -0.0
.debug_line 5145772 5145772 0 0.0
.debug_loc 3378857 3378857 0 0.0
.debug_ranges 363728 363728 0 0.0
.debug_str 3479647 3479624 -23 -0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116336 116336 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568751 568751 0 0.0
.symtab 172112 172112 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956100 956100 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284011 1284011 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1677341 1677341 0 0.0
.debug_aranges 140824 140824 0 0.0
.debug_frame 514260 514260 0 0.0
.debug_info 43520270 43520234 -36 -0.0
.debug_line 5536787 5536787 0 0.0
.debug_loc 3573902 3573902 0 0.0
.debug_ranges 387296 387296 0 0.0
.debug_str 3882045 3882045 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130048 130048 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628973 628973 0 0.0
.symtab 190288 190288 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030034 1030034 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588438 588438 0 0.0
.app_xip_area 464696 464696 0 0.0
.bss 66200 66200 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592138 592138 0 0.0
.app_xip_area 463100 463100 0 0.0
.bss 71488 71488 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551498 551498 0 0.0
.app_xip_area 433260 433260 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976164 976164 0 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821724 821724 0 0.0
BRD4161A+rs911x (read/write) 1037800 1037800 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 849040 849040 0 0.0
BRD4187C (read/write) 1149228 1149228 0 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983468 983468 0 0.0
lock-app BRD4161A+wf200 (read/write) 1163488 1163488 0 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1003152 1003152 0 0.0
window-app BRD4187C (read/write) 1141744 1141744 0 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974544 974544 0 0.0
esp32 all-clusters-app c3devkit (read only) 1218896 1218894 -2 -0.0
(read/write) 1790954 1790938 -16 -0.0
.dram0.bss 76992 76992 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248312 248296 -16 -0.0
.flash.text 1218896 1218894 -2 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233127 1233127 0 0.0
(read/write) 564179 564175 -4 -0.0
.dram0.bss 82144 82144 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314092 314088 -4 -0.0
.flash.text 1227743 1227743 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662532 662532 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564204 564204 0 0.0
light k32w0+release (read/write) 673112 673112 0 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593420 593420 0 0.0
lock k32w0+release (read/write) 634068 634068 0 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553596 553596 0 0.0
linux all-clusters-app debug (read only) 3111497 3111497 0 0.0
(read/write) 158472 158472 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87144 87144 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281227 281227 0 0.0
.text 2645778 2645778 0 0.0
all-clusters-minimal-app debug (read only) 2935177 2935177 0 0.0
(read/write) 149872 149872 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79512 79512 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280683 280683 0 0.0
.text 2473042 2473042 0 0.0
bridge-app debug (read only) 2427761 2427761 0 0.0
(read/write) 129576 129576 0 0.0
.bss 50976 50976 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68776 68776 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 210848 210848 0 0.0
.text 2049554 2049554 0 0.0
chip-tool debug (read only) 11248841 11248873 32 0.0
(read/write) 659960 659960 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 624736 624736 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 604901 604933 32 0.0
.text 9116708 9116708 0 0.0
chip-tool-ipv6only arm64 (read only) 10625164 10625164 0 0.0
(read/write) 708097 708097 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652392 652392 0 0.0
.dynamic 560 560 0 0.0
.got 13960 13960 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 531628 531628 0 0.0
.text 8434116 8434116 0 0.0
lighting-app debug+rpc (read only) 2661345 2661345 0 0.0
(read/write) 132328 132328 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73896 73896 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227840 227840 0 0.0
.text 2256946 2256946 0 0.0
lock-app debug (read only) 2620425 2620425 0 0.0
(read/write) 127344 127344 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70840 70840 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244104 244104 0 0.0
.text 2204610 2204610 0 0.0
ota-provider-app debug (read only) 2187065 2187065 0 0.0
(read/write) 105480 105480 0 0.0
.bss 46528 46528 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51768 51768 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 194952 194952 0 0.0
.text 1852594 1852594 0 0.0
ota-requestor-app debug (read only) 2355785 2355785 0 0.0
(read/write) 113824 113824 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57128 57128 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202064 202064 0 0.0
.text 2005010 2005010 0 0.0
shell debug (read only) 2643953 2643953 0 0.0
(read/write) 142936 142936 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78040 78040 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239474 239474 0 0.0
.text 2244962 2244962 0 0.0
thermostat-no-ble arm64 (read only) 2422620 2422620 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033808 2033808 0 0.0
tv-app debug (read only) 3283297 3283297 0 0.0
(read/write) 262120 262120 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80384 80384 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268376 268376 0 0.0
.text 2820930 2820930 0 0.0
tv-casting-app debug (read only) 5641641 5641641 0 0.0
(read/write) 162384 162384 0 0.0
.bss 52088 52088 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101760 101760 0 0.0
.dynamic 608 608 0 0.0
.got 4912 4912 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 358841 358841 0 0.0
.text 5005858 5005858 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463424 2463424 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1426068 1426068 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190779 1190779 0 0.0
bss 145285 145285 0 0.0
rodata 144448 144448 0 0.0
text 819880 819880 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360858 1360858 0 0.0
bss 105224 105224 0 0.0
rodata 211552 211552 0 0.0
text 759590 759590 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136423 1136423 0 0.0
bss 144520 144520 0 0.0
rodata 120764 120764 0 0.0
text 790048 790044 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1748580 1748580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238191 1238191 0 0.0
.debug_aranges 110904 110904 0 0.0
.debug_frame 372248 372248 0 0.0
.debug_info 27069401 27069365 -36 -0.0
.debug_line 3707324 3707325 1 0.0
.debug_loc 3620989 3621002 13 0.0
.debug_ranges 345760 345760 0 0.0
.debug_str 3449307 3449284 -23 -0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571607 571607 0 0.0
.symtab 422000 422000 0 0.0
.text 1548824 1548824 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1691108 1691108 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230082 1230082 0 0.0
.debug_aranges 110376 110376 0 0.0
.debug_frame 375304 375304 0 0.0
.debug_info 26806219 26806182 -37 -0.0
.debug_line 3726261 3726262 1 0.0
.debug_loc 3608595 3608608 13 0.0
.debug_ranges 344376 344376 0 0.0
.debug_str 3438319 3438296 -23 -0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535696 535696 0 0.0
.symtab 408432 408432 0 0.0
.text 1492080 1492080 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609300 1609300 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064879 1064879 0 0.0
.debug_aranges 102576 102576 0 0.0
.debug_frame 345640 345640 0 0.0
.debug_info 22268887 22268855 -32 -0.0
.debug_line 3293587 3293589 2 0.0
.debug_loc 3306485 3306515 30 0.0
.debug_ranges 308512 308512 0 0.0
.debug_str 3243905 3243882 -23 -0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472021 472021 0 0.0
.symtab 376800 376800 0 0.0
.text 1418464 1418464 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1642740 1642740 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066795 1066795 0 0.0
.debug_aranges 102960 102960 0 0.0
.debug_frame 347436 347436 0 0.0
.debug_info 22487081 22487057 -24 -0.0
.debug_line 3293338 3293336 -2 -0.0
.debug_loc 3327912 3327882 -30 -0.0
.debug_ranges 310368 310368 0 0.0
.debug_str 3259748 3259725 -23 -0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473683 473683 0 0.0
.symtab 378400 378400 0 0.0
.text 1446912 1446912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151252 1151244 -8 -0.0
.bss 100436 100436 0 0.0
.data 840 840 0 0.0
.text 598352 598344 -8 -0.0
lock-app qpg6105+debug (read/write) 1117284 1117284 0 0.0
.bss 95908 95908 0 0.0
.data 836 836 0 0.0
.text 564380 564380 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1091720 1091720 0 0.0
bss 99808 99808 0 0.0
text 739454 739454 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1031092 1031084 -8 -0.0
bss 99032 99032 0 0.0
text 704658 704656 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952516 952508 -8 -0.0
bss 91272 91272 0 0.0
text 651266 651264 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033932 1033924 -8 -0.0
bss 100420 100420 0 0.0
text 719650 719648 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 966092 966092 0 0.0
bss 92228 92228 0 0.0
text 662510 662510 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 952832 952832 0 0.0
bss 92664 92664 0 0.0
text 649670 649670 0 0.0

@andy31415 andy31415 merged commit d1c9050 into project-chip:master Dec 9, 2022
@bzbarsky-apple bzbarsky-apple deleted the remove-utc-type branch December 9, 2022 17:19
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkq arkq arkq approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved tests
Projects
None yet
Milestone
No milestone
3 participants
@bzbarsky-apple @andy31415 @arkq