-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add PICS checker #24525
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTest_PICSChecker
Jan 21, 2023
Merged
[matter_yamltests] Add PICS checker #24525
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTest_PICSChecker
Jan 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
YamlTest_PICSChecker
branch
from
January 19, 2023 15:44
b07427a
to
ba25811
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 19, 2023 15:44
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
woody-apple and
xylophone21
January 19, 2023 15:44
PR #24525: Size comparison from df07c87 to ba25811 Increases (6 builds for bl702, nrfconnect, psoc6, telink)
Decreases (5 builds for bl602, cyw30739, nrfconnect, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
reviewed
Jan 19, 2023
vivien-apple
force-pushed
the
YamlTest_PICSChecker
branch
2 times, most recently
from
January 20, 2023 15:44
97dfa89
to
3b650b1
Compare
PR #24525: Size comparison from e48fe6a to 3b650b1 Increases (1 build for telink)
Decreases (10 builds for bl602, bl702, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Jan 20, 2023
bzbarsky-apple
approved these changes
Jan 20, 2023
vivien-apple
force-pushed
the
YamlTest_PICSChecker
branch
from
January 21, 2023 09:10
3b650b1
to
b8a5897
Compare
PR #24525: Size comparison from 650b5d7 to b8a5897 Increases (8 builds for bl702, psoc6, qpg, telink)
Decreases (3 builds for bl602, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
YamlTest_PICSChecker
branch
from
January 21, 2023 10:39
b8a5897
to
c631fbb
Compare
PR #24525: Size comparison from 650b5d7 to c631fbb Increases (8 builds for bl602, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This was referenced Jan 23, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
matter_yamltests
does not supportsPICS
code. This PR adds aPICSChecker
class (with tests) that set theis_pics_enabled
attribute on every test step.The test is still part of the list in order to allow different showing to the user which tests are runned/disabled when PICS code are updated.