-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have chip-repl yamltests parser use PICS to determine if test step should run #24626
Merged
tehampson
merged 4 commits into
project-chip:master
from
tehampson:use-pics-in-yaml-runner-0124-newer
Jan 25, 2023
Merged
Have chip-repl yamltests parser use PICS to determine if test step should run #24626
tehampson
merged 4 commits into
project-chip:master
from
tehampson:use-pics-in-yaml-runner-0124-newer
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 24, 2023 19:10
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 24, 2023 19:10
pullapprove
bot
added
review - pending
controller
scripts
and removed
scripts
controller
labels
Jan 24, 2023
PR #24626: Size comparison from bee022b to f1a0557 Increases (7 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 24, 2023
PR #24626: Size comparison from 743b9ca to 8b10f93 Increases (14 builds for bl602, bl702, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for esp32, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 25, 2023
PR #24626: Size comparison from 743b9ca to bdd814e Increases (17 builds for bl602, bl702, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl702, cyw30739, esp32, psoc6)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
commented
Jan 25, 2023
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Jan 25, 2023
andy31415
added a commit
that referenced
this pull request
Jan 27, 2023
…t runner (#24629) * Add ability to list all YAML tests and manually run them from the test runner * Fix typo * Do not try to find chip-tool if not needed * Restyle * Remove flaky tests identified in #24626 ... they seem to block this PR * Properly support dry run * Fix test target --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…ould run (project-chip#24626) * Have chip-repl yamltests parser use PICs * Fix small issue * Remove flaky tests from chip-repl yamltests runner for now
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t runner (project-chip#24629) * Add ability to list all YAML tests and manually run them from the test runner * Fix typo * Do not try to find chip-tool if not needed * Restyle * Remove flaky tests identified in project-chip#24626 ... they seem to block this PR * Properly support dry run * Fix test target --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: chip-repl based python yamltest runner ignores test step PICS code
Solution: This uses recently added PICS support added to parser to determine if test step should be executed