Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[matter_yamltests] Add CommissionerCommands and DiscoveryCommands method definitions #25110

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[matter_yamltests] Add CommissionerCommands and DiscoveryCommands method definitions #25110

merged 2 commits into from
Feb 16, 2023

Conversation

vivien-apple
Copy link
Contributor

Problem

CommissionerCommands and DiscoveryCommands does not have a definition. It makes errors happening at runtime instead of parsing time.

@vivien-apple vivien-apple self-assigned this Feb 16, 2023
@vivien-apple vivien-apple force-pushed the YamlTests_DiscoveryAndCommissionerCommandsDefinitions branch from 27f2320 to dd9499e Compare February 16, 2023 12:14
@github-actions
Copy link

PR #25110: Size comparison from 770e39c to dd9499e

Increases (1 build for qpg)
platform target config section 770e39c dd9499e change % change
qpg lock-app qpg6105+debug (read/write) 1117812 1117820 8 0.0
.text 564908 564916 8 0.0
Decreases (1 build for cc32xx)
platform target config section 770e39c dd9499e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20338086 20338085 -1 -0.0
Full report (4 builds for cc32xx, mbed, qpg)
platform target config section 770e39c dd9499e change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87432 87432 0 0.0
.debug_frame 300120 300120 0 0.0
.debug_info 20338086 20338085 -1 -0.0
.debug_line 2657824 2657824 0 0.0
.debug_loc 2790649 2790649 0 0.0
.debug_ranges 281568 281568 0 0.0
.debug_str 3003658 3003658 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467864 2467864 0 0.0
.bss 215924 215924 0 0.0
.data 5880 5880 0 0.0
.text 1430508 1430508 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150524 1150524 0 0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597624 597624 0 0.0
lock-app qpg6105+debug (read/write) 1117812 1117820 8 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564908 564916 8 0.0

@vivien-apple vivien-apple force-pushed the YamlTests_DiscoveryAndCommissionerCommandsDefinitions branch from dd9499e to fd8583f Compare February 16, 2023 14:49
@github-actions
Copy link

PR #25110: Size comparison from e744367 to fd8583f

Increases (3 builds for bl602, bl702, cc32xx)
platform target config section e744367 fd8583f change % change
bl602 lighting-app bl602+rpc .text 1056042 1056044 2 0.0
bl702 lighting-app bl702+rpc .debug_info 45074209 45074210 1 0.0
.text 1032158 1032160 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20347053 20347054 1 0.0
Decreases (1 build for bl702)
platform target config section e744367 fd8583f change % change
bl702 lighting-app bl702 .debug_info 40664853 40664852 -1 -0.0
.text 954764 954762 -2 -0.0
Full report (9 builds for bl602, bl702, cc32xx, linux, qpg)
platform target config section e744367 fd8583f change % change
bl602 lighting-app bl602 (read/write) 1349102 1349102 0 0.0
.bss 94834 94834 0 0.0
.data 9736 9736 0 0.0
.text 1025364 1025364 0 0.0
bl602+rpc (read/write) 1394270 1394270 0 0.0
.bss 102882 102882 0 0.0
.data 10128 10128 0 0.0
.text 1056042 1056044 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1187451 1187451 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69937 69937 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1552964 1552964 0 0.0
.debug_aranges 134384 134384 0 0.0
.debug_frame 492440 492440 0 0.0
.debug_info 40664853 40664852 -1 -0.0
.debug_line 5282334 5282334 0 0.0
.debug_loc 3414245 3414245 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3575377 3575377 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107552 107552 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574023 574023 0 0.0
.symtab 173584 173584 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 954764 954762 -2 -0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1280607 1280607 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77985 77985 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1701454 1701454 0 0.0
.debug_aranges 142616 142616 0 0.0
.debug_frame 520188 520188 0 0.0
.debug_info 45074209 45074210 1 0.0
.debug_line 5681330 5681330 0 0.0
.debug_loc 3611163 3611163 0 0.0
.debug_ranges 395960 395960 0 0.0
.debug_str 3978881 3978881 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122192 122192 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635082 635082 0 0.0
.symtab 192048 192048 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032158 1032160 2 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 641857 641857 0 0.0
(read/write) 204124 204124 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197528 197528 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 931515 931515 0 0.0
.debug_aranges 87464 87464 0 0.0
.debug_frame 300232 300232 0 0.0
.debug_info 20347053 20347054 1 0.0
.debug_line 2658245 2658245 0 0.0
.debug_loc 2791387 2791387 0 0.0
.debug_ranges 281600 281600 0 0.0
.debug_str 3015122 3015122 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105697 105697 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 376514 376514 0 0.0
.symtab 256016 256016 0 0.0
.text 534036 534036 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12049764 12049764 0 0.0
(read/write) 729208 729208 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671424 671424 0 0.0
.dynamic 560 560 0 0.0
.got 15328 15328 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585044 585044 0 0.0
.text 9734452 9734452 0 0.0
thermostat-no-ble arm64 (read only) 2517076 2517076 0 0.0
(read/write) 145320 145320 0 0.0
.bss 56488 56488 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 77544 77544 0 0.0
.dynamic 560 560 0 0.0
.got 5408 5408 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151232 151232 0 0.0
.text 2103552 2103552 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150556 1150556 0 0.0
.bss 99932 99932 0 0.0
.data 848 848 0 0.0
.text 597656 597656 0 0.0
lock-app qpg6105+debug (read/write) 1117820 1117820 0 0.0
.bss 96428 96428 0 0.0
.data 860 860 0 0.0
.text 564916 564916 0 0.0

@vivien-apple vivien-apple merged commit 9e71067 into project-chip:master Feb 16, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@vivien-apple
[matter_yamltests] Add CommissionerCommands and DiscoveryCommands met…
5d86fd4 
…hod definitions (project-chip#25110)

* [matter_yamltests] Add CommissionerCommands methods definitions

* [matter_yamltests] Add DiscoveryCommands methods definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tehampson tehampson tehampson approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees

@vivien-apple vivien-apple

Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivien-apple @tehampson @bzbarsky-apple