Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow chip-repl to send group commands #25158

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Allow chip-repl to send group commands #25158

merged 5 commits into from
Feb 22, 2023

Conversation

tehampson
Copy link
Contributor

With chip-repl now able to send we have updated the yamltests runner that uses chip-repl to send group commands

Test: Confirmed that group messages are sent when running TestGroupMessaging.yaml with chip-repl based yamltest runner.

@tehampson tehampson force-pushed the add-group-commands-02-14 branch from f5df6be to 92a91ab Compare February 17, 2023 17:10
@tehampson
Allow chip-repl to send group commands
6a1ce38 
With chip-repl now able to send we have updated the yamltests runner
that uses chip-repl to send group commands
@tehampson tehampson force-pushed the add-group-commands-02-14 branch from 92a91ab to 6a1ce38 Compare February 17, 2023 17:13
@github-actions
Copy link

PR #25158: Size comparison from 015ae13 to 6a1ce38

Increases (7 builds for bl602, cc13x2_26x2, cc32xx, k32w, nrfconnect, telink)
platform target config section 015ae13 6a1ce38 change % change
bl602 lighting-app bl602 .text 1025422 1025424 2 0.0
cc13x2_26x2 pump-app LP_CC2652R7 (read only) 689499 689507 8 0.0
.text 598088 598096 8 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20373350 20373351 1 0.0
k32w light k32w0+release (read/write) 669068 669084 16 0.0
.text 570424 570440 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 806528 806532 4 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 648408 648410 2 0.0
ota-requestor-app tlsr9518adk80d text 602884 602886 2 0.0
Decreases (5 builds for cc13x2_26x2, psoc6, telink)
platform target config section 015ae13 6a1ce38 change % change
cc13x2_26x2 pump-app LP_CC2652R7 (read/write) 159772 159764 -8 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27640462 27640460 -2 -0.0
telink contact-sensor-app tlsr9518adk80d text 579034 579032 -2 -0.0
light-switch-app tlsr9518adk80d text 593040 593038 -2 -0.0
lighting-app tlsr9518adk80d text 659104 659102 -2 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 015ae13 6a1ce38 change % change
bl602 lighting-app bl602 (read/write) 1349138 1349138 0 0.0
.bss 94786 94786 0 0.0
.data 9736 9736 0 0.0
.text 1025422 1025424 2 0.0
bl602+rpc (read/write) 1394562 1394562 0 0.0
.bss 102834 102834 0 0.0
.data 10128 10128 0 0.0
.text 1056358 1056358 0 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1187699 1187699 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69889 69889 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4064 4064 0 0.0
.debug_abbrev 1556622 1556622 0 0.0
.debug_aranges 134464 134464 0 0.0
.debug_frame 492812 492812 0 0.0
.debug_info 40714269 40714269 0 0.0
.debug_line 5285904 5285904 0 0.0
.debug_loc 3418026 3418026 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3578290 3578290 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107568 107568 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574175 574175 0 0.0
.symtab 173632 173632 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 955022 955022 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1280847 1280847 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77937 77937 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1704868 1704868 0 0.0
.debug_aranges 142704 142704 0 0.0
.debug_frame 520576 520576 0 0.0
.debug_info 45129695 45129695 0 0.0
.debug_line 5684947 5684947 0 0.0
.debug_loc 3614981 3614981 0 0.0
.debug_ranges 395968 395968 0 0.0
.debug_str 3981827 3981827 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122208 122208 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635239 635239 0 0.0
.symtab 192096 192096 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1032432 1032432 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679959 679959 0 0.0
(read/write) 171224 171224 0 0.0
.bss 80876 80876 0 0.0
.data 3388 3388 0 0.0
.rodata 88319 88319 0 0.0
.text 591324 591324 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643271 643271 0 0.0
(read/write) 157588 157588 0 0.0
.bss 80084 80084 0 0.0
.data 3388 3388 0 0.0
.rodata 78231 78231 0 0.0
.text 564720 564720 0 0.0
lock-ftd LP_CC2652R7 (read only) 676535 676535 0 0.0
(read/write) 172016 172016 0 0.0
.bss 78332 78332 0 0.0
.data 3316 3316 0 0.0
.rodata 76679 76679 0 0.0
.text 599376 599376 0 0.0
lock-mtd LP_CC2652R7 (read only) 663027 663027 0 0.0
(read/write) 180780 180780 0 0.0
.bss 73588 73588 0 0.0
.data 3316 3316 0 0.0
.rodata 103299 103299 0 0.0
.text 559248 559248 0 0.0
pump-app LP_CC2652R7 (read only) 689499 689507 8 0.0
(read/write) 159772 159764 -8 -0.0
.bss 78284 78284 0 0.0
.data 3280 3280 0 0.0
.rodata 90931 90931 0 0.0
.text 598088 598096 8 0.0
pump-controller-app LP_CC2652R7 (read only) 674675 674675 0 0.0
(read/write) 174724 174724 0 0.0
.bss 78412 78412 0 0.0
.data 3304 3304 0 0.0
.rodata 86931 86931 0 0.0
.text 587264 587264 0 0.0
shell LP_CC2652R7 (read only) 671262 671262 0 0.0
(read/write) 181992 181992 0 0.0
.bss 82948 82948 0 0.0
.data 3384 3384 0 0.0
.rodata 85070 85070 0 0.0
.text 585880 585880 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642409 642409 0 0.0
(read/write) 203784 203784 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197184 197184 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 934730 934730 0 0.0
.debug_aranges 87536 87536 0 0.0
.debug_frame 300452 300452 0 0.0
.debug_info 20373350 20373351 1 0.0
.debug_line 2662373 2662373 0 0.0
.debug_loc 2797189 2797189 0 0.0
.debug_ranges 281960 281960 0 0.0
.debug_str 3022022 3022022 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105705 105705 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377926 377926 0 0.0
.symtab 256352 256352 0 0.0
.text 534584 534584 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586282 586282 0 0.0
.app_xip_area 463068 463068 0 0.0
.bss 65656 65656 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590290 590290 0 0.0
.app_xip_area 461772 461772 0 0.0
.bss 70952 70952 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551182 551182 0 0.0
.app_xip_area 433472 433472 0 0.0
.bss 60192 60192 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read/write) 670048 670048 0 0.0
.bss 77636 77636 0 0.0
.data 2204 2204 0 0.0
.text 571096 571096 0 0.0
light k32w0+release (read/write) 669068 669084 16 0.0
.bss 77340 77340 0 0.0
.data 2192 2192 0 0.0
.text 570424 570440 16 0.0
lock k32w0+release (read/write) 625936 625936 0 0.0
.bss 75476 75476 0 0.0
.data 2136 2136 0 0.0
.text 545596 545596 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12053252 12053252 0 0.0
(read/write) 729368 729368 0 0.0
.bss 34264 34264 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 671552 671552 0 0.0
.dynamic 560 560 0 0.0
.got 15344 15344 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 585396 585396 0 0.0
.text 9737252 9737252 0 0.0
thermostat-no-ble arm64 (read only) 2516668 2516668 0 0.0
(read/write) 145240 145240 0 0.0
.bss 56440 56440 0 0.0
.data 1832 1832 0 0.0
.data.rel.ro 77568 77568 0 0.0
.dynamic 560 560 0 0.0
.got 5352 5352 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 151320 151320 0 0.0
.text 2103152 2103152 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466608 2466608 0 0.0
.bss 215900 215900 0 0.0
.data 5880 5880 0 0.0
.text 1429252 1429252 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164372 1164372 0 0.0
bss 143539 143539 0 0.0
rodata 134416 134416 0 0.0
text 806528 806532 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1109776 1109776 0 0.0
bss 142695 142695 0 0.0
rodata 111484 111484 0 0.0
text 775836 775836 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1369684 1369684 0 0.0
bss 106002 106002 0 0.0
rodata 211856 211856 0 0.0
text 766308 766308 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840856 840856 0 0.0
(read/write) 1760612 1760612 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189816 189816 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1258175 1258175 0 0.0
.debug_aranges 111584 111584 0 0.0
.debug_frame 374848 374848 0 0.0
.debug_info 28094366 28094366 0 0.0
.debug_line 3797675 3797675 0 0.0
.debug_loc 3692150 3692150 0 0.0
.debug_ranges 363680 363680 0 0.0
.debug_str 3531104 3531104 0 0.0
.heap 840856 840856 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 580987 580987 0 0.0
.symtab 425488 425488 0 0.0
.text 1559736 1559736 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841664 841664 0 0.0
(read/write) 1701116 1701116 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189008 189008 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1243720 1243720 0 0.0
.debug_aranges 110848 110848 0 0.0
.debug_frame 377284 377284 0 0.0
.debug_info 27640462 27640460 -2 -0.0
.debug_line 3806183 3806183 0 0.0
.debug_loc 3675765 3675765 0 0.0
.debug_ranges 361648 361648 0 0.0
.debug_str 3518367 3518367 0 0.0
.heap 841664 841664 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 540404 540404 0 0.0
.symtab 410496 410496 0 0.0
.text 1501048 1501048 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849984 849984 0 0.0
(read/write) 1614668 1614668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180896 180896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1078792 1078792 0 0.0
.debug_aranges 103048 103048 0 0.0
.debug_frame 347536 347536 0 0.0
.debug_info 22977084 22977084 0 0.0
.debug_line 3357882 3357882 0 0.0
.debug_loc 3351748 3351748 0 0.0
.debug_ranges 320160 320160 0 0.0
.debug_str 3316856 3316856 0 0.0
.heap 849984 849984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476127 476127 0 0.0
.symtab 378336 378336 0 0.0
.text 1422920 1422920 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845000 845000 0 0.0
(read/write) 1648804 1648804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185864 185864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2480 2480 0 0.0
.debug_abbrev 1080823 1080823 0 0.0
.debug_aranges 103496 103496 0 0.0
.debug_frame 349440 349440 0 0.0
.debug_info 23230260 23230260 0 0.0
.debug_line 3360312 3360312 0 0.0
.debug_loc 3376764 3376764 0 0.0
.debug_ranges 322760 322760 0 0.0
.debug_str 3335987 3335987 0 0.0
.heap 845000 845000 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 480142 480142 0 0.0
.symtab 380800 380800 0 0.0
.text 1452072 1452072 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150748 1150748 0 0.0
.bss 99908 99908 0 0.0
.data 852 852 0 0.0
.text 597844 597844 0 0.0
lock-app qpg6105+debug (read/write) 1118284 1118284 0 0.0
.bss 96404 96404 0 0.0
.data 864 864 0 0.0
.text 565384 565384 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015860 1015860 0 0.0
bss 97876 97876 0 0.0
text 686892 686892 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951552 951552 0 0.0
bss 96928 96928 0 0.0
text 648408 648410 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 856164 856164 0 0.0
bss 89056 89056 0 0.0
text 579034 579032 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871884 871884 0 0.0
bss 89140 89140 0 0.0
text 593040 593038 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 949936 949936 0 0.0
bss 97284 97284 0 0.0
text 659104 659102 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883316 883316 0 0.0
bss 90084 90084 0 0.0
text 602884 602886 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875984 875984 0 0.0
bss 90532 90532 0 0.0
text 594462 594462 0 0.0

@pullapprove pullapprove bot requested a review from nivi-apple February 21, 2023 14:17
@andy31415 andy31415 merged commit ec2b5e3 into project-chip:master Feb 22, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@tehampson
Allow chip-repl to send group commands (project-chip#25158)
1d036d7 
* Allow chip-repl to send group commands

With chip-repl now able to send we have updated the yamltests runner
that uses chip-repl to send group commands

* Address PR comments

* Restyle

* Address PR comments

* Restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

Assignees
No one assigned
Labels
controller review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tehampson @tcarmelveilleux @bzbarsky-apple @andy31415