Add M5Stack specific builds for esp32 light #25550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same MCU except screen support -i.e. defaults should work
…TODO for actual integration
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
|
Created #25551 to fix code duplication for M5Stack UIs ... we shold be able to more easily add UIs for examples than copy and paste (and I also see buttons and LEDs diverging quite a bit). |
tcarmelveilleux
approved these changes
Mar 7, 2023
|
PR #25550: Size comparison from c69e90d to 16b1581 Increases (6 builds for bl602, bl702, cc13x2_26x2, cc32xx, psoc6)
Decreases (3 builds for bl602, cc13x2_26x2, efr32)
Full report (34 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
cliffamzn
reviewed
Mar 8, 2023
Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
|
PR #25550: Size comparison from c69e90d to c27cdb0 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
cliffamzn
approved these changes
Mar 8, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Enable builds for m5stack for more apps as m5stack and devkitc are the same MCU except screen support -i.e. defaults should work * start adding some compile options for ESP32 display ... still made a TODO for actual integration * Enable m5stack in Kconfig * Things compile now * Restyle * Remove demo items * Add more config variables to get displays working * Cleanup unused widgets, add callbacks for the wifi one * Make wifi green * Cleanup device with display: no more virtual devices * Restyle * Remove unnedded log * Remove unused variable * Remove useless commment in QRCodeScreen.h * Remove one more useless coment * Update examples/lighting-app/esp32/main/Button.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update examples/lighting-app/esp32/main/DeviceWithDisplay.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update examples/lighting-app/esp32/main/Globals.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update examples/lighting-app/esp32/main/StatusScreen.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update copyright dates and remove a bunch of @file comments * Move ifdefs around * Remove useless button.h comments * Move ifdefs a bit - HAVE_DISPLAY is a result of a header --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
mwswartwout
pushed a commit
to mwswartwout/connectedhomeip
that referenced
this pull request
Mar 27, 2023
* Enable builds for m5stack for more apps as m5stack and devkitc are the same MCU except screen support -i.e. defaults should work * start adding some compile options for ESP32 display ... still made a TODO for actual integration * Enable m5stack in Kconfig * Things compile now * Restyle * Remove demo items * Add more config variables to get displays working * Cleanup unused widgets, add callbacks for the wifi one * Make wifi green * Cleanup device with display: no more virtual devices * Restyle * Remove unnedded log * Remove unused variable * Remove useless commment in QRCodeScreen.h * Remove one more useless coment * Update examples/lighting-app/esp32/main/Button.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update examples/lighting-app/esp32/main/DeviceWithDisplay.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update examples/lighting-app/esp32/main/Globals.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update examples/lighting-app/esp32/main/StatusScreen.cpp Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Update copyright dates and remove a bunch of @file comments * Move ifdefs around * Remove useless button.h comments * Move ifdefs a bit - HAVE_DISPLAY is a result of a header --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the M5Stack display work in case we are building for a m5stack.
A very large chung of this is actually taking existing UIs from all-clusters app and applying to m5stack.
Unfortunately I could see no modularization and created #25551 to fix that. I wanted to have a UI first and then modularize (mainly because I had to go through the entire process of figuring out Kconfig requirements to make all these work ... so now that UI compiles and works, may as well create a PR and not yak shave modularization).
Tested:
./scripts/build/build_examples.py --enable-flashbundle --target esp32-m5stack-light buildand verified display works./scripts/build/build_examples.py --enable-flashbundle --target esp32-devkitc-light buildand flashed on a m5stack (assumed same mcu) and saw it working through logs (tested provision and toggle)