Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: fix compile errors related to screen framwork #25588

Merged
merged 3 commits into from
Mar 10, 2023
Merged

ESP32: fix compile errors related to screen framwork #25588

merged 3 commits into from
Mar 10, 2023

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Mar 9, 2023

Problems

Fixes #25584
#25550 added display components, so may have broke the C3.

Changes

Fixes the errors related to screen framwork

Test

Tested all-clusters-app and lighting-app on ESP32C3-DevKitM and M5Stack

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

PR #25588: Size comparison from a2f83a9 to 2219049

Increases (1 build for cc32xx)
platform target config section a2f83a9 2219049 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20267468 20267469 1 0.0
Full report (1 build for cc32xx)
platform target config section a2f83a9 2219049 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644425 644425 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930235 930235 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300044 300044 0 0.0
.debug_info 20267468 20267469 1 0.0
.debug_line 2659770 2659770 0 0.0
.debug_loc 2802853 2802853 0 0.0
.debug_ranges 282960 282960 0 0.0
.debug_str 3024079 3024079 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536372 536372 0 0.0

@wqx6 wqx6 force-pushed the esp32/fix_screen_errors branch from 1aa251f to 95fe1d4 Compare March 10, 2023 03:12
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 10, 2023
@github-actions
Copy link

PR #25588: Size comparison from 52b1e62 to 95fe1d4

Full report (1 build for cc32xx)
platform target config section 52b1e62 95fe1d4 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300048 300048 0 0.0
.debug_info 20268460 20268460 0 0.0
.debug_line 2659917 2659917 0 0.0
.debug_loc 2802993 2802993 0 0.0
.debug_ranges 282936 282936 0 0.0
.debug_str 3023875 3023875 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536412 536412 0 0.0

@github-actions
Copy link

PR #25588: Size comparison from 52b1e62 to 65c4d67

Full report (1 build for cc32xx)
platform target config section 52b1e62 65c4d67 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300048 300048 0 0.0
.debug_info 20268460 20268460 0 0.0
.debug_line 2659917 2659917 0 0.0
.debug_loc 2802993 2802993 0 0.0
.debug_ranges 282936 282936 0 0.0
.debug_str 3023875 3023875 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536412 536412 0 0.0

@wqx6 wqx6 force-pushed the esp32/fix_screen_errors branch from 65c4d67 to 26580b7 Compare March 10, 2023 04:17
@github-actions
Copy link

PR #25588: Size comparison from 52b1e62 to 26580b7

Decreases (1 build for cc32xx)
platform target config section 52b1e62 26580b7 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20268460 20268459 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 52b1e62 26580b7 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 644465 644465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930280 930280 0 0.0
.debug_aranges 87344 87344 0 0.0
.debug_frame 300048 300048 0 0.0
.debug_info 20268460 20268459 -1 -0.0
.debug_line 2659917 2659917 0 0.0
.debug_loc 2802993 2802993 0 0.0
.debug_ranges 282936 282936 0 0.0
.debug_str 3023875 3023875 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378571 378571 0 0.0
.symtab 256624 256624 0 0.0
.text 536412 536412 0 0.0

@yufengwangca yufengwangca merged commit fca8348 into project-chip:master Mar 10, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@wqx6 @restyled-commits
ESP32: fix compile errors related to screen framwork (project-chip#25588
77d41f9 
)

* ESP32: fix compile errors related to screen framwork

* Restyled by clang-format

* fix errors in all-clusters-minimal-app and use ESP32-H2-MP now

---------

Co-authored-by: Restyled.io <commits@restyled.io>
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this pull request Mar 27, 2023
@wqx6 @restyled-commits @mwswartwout
ESP32: fix compile errors related to screen framwork (project-chip#25588
a5dbb2c 
)

* ESP32: fix compile errors related to screen framwork

* Restyled by clang-format

* fix errors in all-clusters-minimal-app and use ESP32-H2-MP now

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chshu chshu Awaiting requested review from chshu

Assignees
No one assigned
Labels
config documentation Improvements or additions to documentation esp32 examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [lighting-app] cannot build for ESP32-C3-devKitM-1
5 participants
@wqx6 @chshu @bzbarsky-apple @yufengwangca @restyled-commits