-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MigrateClusterReadMapping.java to jinja codegen #25786
Merged
andy31415
merged 9 commits into
project-chip:master
from
andy31415:migrate_cluster_read_interaction
Mar 23, 2023
Merged
MigrateClusterReadMapping.java to jinja codegen #25786
andy31415
merged 9 commits into
project-chip:master
from
andy31415:migrate_cluster_read_interaction
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
March 22, 2023 14:56
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia and
sharadb-amazon
March 22, 2023 14:57
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
March 22, 2023 14:57
PR #25786: Size comparison from 6be032d to 062c4a3 Increases (1 build for cc32xx)
Decreases (1 build for qpg)
Full report (3 builds for cc32xx, qpg)
|
bzbarsky-apple
approved these changes
Mar 22, 2023
tehampson
approved these changes
Mar 23, 2023
PR #25786: Size comparison from 47c3fe9 to cf412e8 Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving more codegen to use matter idl files, to have consistent outputs among java codegen.
Added golden image unit test and since we still check in generated files, we can validate that the generated output is identical (except license blurb and generated by zap comment)