Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrateClusterReadMapping.java to jinja codegen #25786

Merged

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Mar 22, 2023

Moving more codegen to use matter idl files, to have consistent outputs among java codegen.

Added golden image unit test and since we still check in generated files, we can validate that the generated output is identical (except license blurb and generated by zap comment)

@github-actions
Copy link

PR #25786: Size comparison from 6be032d to 062c4a3

Increases (1 build for cc32xx)
platform target config section 6be032d 062c4a3 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20251230 20251231 1 0.0
Decreases (1 build for qpg)
platform target config section 6be032d 062c4a3 change % change
qpg lighting-app qpg6105+debug (read/write) 1152888 1152880 -8 -0.0
.text 599984 599976 -8 -0.0
Full report (3 builds for cc32xx, qpg)
platform target config section 6be032d 062c4a3 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20251230 20251231 1 0.0
.debug_line 2661959 2661959 0 0.0
.debug_loc 2806733 2806733 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027534 3027534 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152888 1152880 -8 -0.0
.bss 96036 96036 0 0.0
.data 852 852 0 0.0
.text 599984 599976 -8 -0.0
lock-app qpg6105+debug (read/write) 1121448 1121448 0 0.0
.bss 91172 91172 0 0.0
.data 856 856 0 0.0
.text 568548 568548 0 0.0

@andy31415 andy31415 enabled auto-merge (squash) March 23, 2023 19:46
@github-actions
Copy link

PR #25786: Size comparison from 47c3fe9 to cf412e8

Full report (1 build for cc32xx)
platform target config section 47c3fe9 cf412e8 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930286 930286 0 0.0
.debug_aranges 87400 87400 0 0.0
.debug_frame 300336 300336 0 0.0
.debug_info 20239634 20239634 0 0.0
.debug_line 2661958 2661958 0 0.0
.debug_loc 2806731 2806731 0 0.0
.debug_ranges 283424 283424 0 0.0
.debug_str 3027815 3027815 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

@andy31415 andy31415 merged commit a4a407b into project-chip:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants