Adding exceptions to if_basic_attribute #975
Conversation
Github: ZAP#898
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
=======================================
Coverage 66.47% 66.48%
=======================================
Files 156 156
Lines 16953 16958 +5
Branches 3682 3686 +4
=======================================
+ Hits 11270 11275 +5
Misses 5683 5683
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -28,6 +28,7 @@ const zclUtil = require(zapPath + 'util/zcl-util.js'); | |||
|
|
|||
| const characterStringTypes = ['CHAR_STRING', 'LONG_CHAR_STRING']; | |||
| const octetStringTypes = ['OCTET_STRING', 'LONG_OCTET_STRING']; | |||
| const basicAttributeExceptionList = ['vendor_id']; | |||
There was a problem hiding this comment.
why is this an exception ... we would want a comment explaining.
I cannot figure out why vendor_id, fabric_idx and group_id are not basic and had to code this into project-chip/connectedhomeip#25786 ....
There was a problem hiding this comment.
I think this is an existing problem may it be jinja or handlebar templates. I believe the list is a lot longer than that. 'ActionId', 'FabricIndex', 'Percent', 'EndpointId', 'GroupId', 'VendorId', 'Percent100ths', 'ClusterId', 'AttributeId', 'FieldId', 'EventId', 'CommandId', 'TransactionId', 'DeviceTypeId', 'StatusCode', 'DataVersion', 'EventNumber', 'FabricId', 'NodeId'
Adding exceptions to if_basic_attribute
Github: ZAP#898