[Darwin]Fix: enable controller to skip complete step #26248

robinmo · 2023-04-25T10:32:39Z

src/darwin/Framework/CHIP/MTRCommissioningParameters.h

…_NEWLY_AVAILABLE annotation

github-actions · 2023-04-25T14:55:18Z

PR #26248: Size comparison from bcf1b80 to e034b52

Increases (1 build for cc32xx)

platform	target	config	section	`bcf1b80`	`e034b52`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19489249	19489250	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`bcf1b80`	`e034b52`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	601114	601114	0
			(read/write)	204132	204132	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197544	197544	0
			.comment	206	206	0
			.data	1468	1468	0
			.debug_abbrev	956756	956756	0
			.debug_aranges	103416	103416	0
			.debug_frame	349704	349704	0
			.debug_info	19489249	19489250	1
			.debug_line	2678035	2678035	0
			.debug_line_str	513	513	0
			.debug_loc	33340	33340	0
			.debug_loclists	1501882	1501882	0
			.debug_ranges	4984	4984	0
			.debug_rnglists	96008	96008	0
			.debug_str	3024877	3024877	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104170	104170	0
			.shstrtab	265	265	0
			.stack	2048	2048	0
			.strtab	477531	477531	0
			.symtab	285936	285936	0
			.text	494824	494824	0

src/darwin/Framework/CHIP/MTRCommissioningParameters.h

src/darwin/Framework/CHIP/MTRDeviceController.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

github-actions · 2023-04-25T15:14:43Z

PR #26248: Size comparison from b206949 to 3a6c88e

Increases (1 build for cc32xx)

platform	target	config	section	`b206949`	`3a6c88e`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19489249	19489250	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`b206949`	`3a6c88e`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	601114	601114	0
			(read/write)	204132	204132	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197544	197544	0
			.comment	206	206	0
			.data	1468	1468	0
			.debug_abbrev	956756	956756	0
			.debug_aranges	103416	103416	0
			.debug_frame	349704	349704	0
			.debug_info	19489249	19489250	1
			.debug_line	2678035	2678035	0
			.debug_line_str	513	513	0
			.debug_loc	33340	33340	0
			.debug_loclists	1501882	1501882	0
			.debug_ranges	4984	4984	0
			.debug_rnglists	96008	96008	0
			.debug_str	3024877	3024877	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104170	104170	0
			.shstrtab	265	265	0
			.stack	2048	2048	0
			.strtab	477531	477531	0
			.symtab	285936	285936	0
			.text	494824	494824	0

github-actions · 2023-04-25T15:27:42Z

PR #26248: Size comparison from 3124f51 to e6e6af2

Full report (1 build for cc32xx)

platform	target	config	section	`3124f51`	`e6e6af2`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	601114	601114
			(read/write)	204132	204132
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197544	197544
			.comment	206	206
			.data	1468	1468
			.debug_abbrev	956756	956756
			.debug_aranges	103416	103416
			.debug_frame	349704	349704
			.debug_info	19489249	19489249
			.debug_line	2678035	2678035
			.debug_line_str	513	513
			.debug_loc	33340	33340
			.debug_loclists	1501882	1501882
			.debug_ranges	4984	4984
			.debug_rnglists	96008	96008
			.debug_str	3024877	3024877
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	104170	104170
			.shstrtab	265	265
			.stack	2048	2048
			.strtab	477531	477531
			.symtab	285936	285936
			.text	494824	494824

github-actions · 2023-04-25T15:43:32Z

PR #26248: Size comparison from 798c266 to e51cfe5

Decreases (1 build for cc32xx)

platform	target	config	section	`798c266`	`e51cfe5`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19489251	19489250	-1	-0.0

Full report (1 build for cc32xx)

platform	target	config	section	`798c266`	`e51cfe5`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	601114	601114	0	0.0
			(read/write)	204132	204132	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197544	197544	0	0.0
			.comment	206	206	0	0.0
			.data	1468	1468	0	0.0
			.debug_abbrev	956756	956756	0	0.0
			.debug_aranges	103416	103416	0	0.0
			.debug_frame	349704	349704	0	0.0
			.debug_info	19489251	19489250	-1	-0.0
			.debug_line	2678035	2678035	0	0.0
			.debug_line_str	513	513	0	0.0
			.debug_loc	33340	33340	0	0.0
			.debug_loclists	1501882	1501882	0	0.0
			.debug_ranges	4984	4984	0	0.0
			.debug_rnglists	96008	96008	0	0.0
			.debug_str	3024877	3024877	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	104170	104170	0	0.0
			.shstrtab	265	265	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	477531	477531	0	0.0
			.symtab	285936	285936	0	0.0
			.text	494824	494824	0	0.0

robinmo · 2023-04-25T16:30:50Z

@bzbarsky-apple
Hi, do you know how to trigger the failed check Darwin/Build Darwin(pull_request), it shows failed now.

bzbarsky-apple · 2023-04-25T17:07:23Z

@robinmo Looks like a random failure on a timing-dependent test... retriggered it.

github-actions · 2023-04-25T23:40:49Z

PR #26248: Size comparison from c2a28c8 to bf40b00

Increases (1 build for cc32xx)

platform	target	config	section	`c2a28c8`	`bf40b00`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19489250	19489251	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	`c2a28c8`	`bf40b00`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	601114	601114	0
			(read/write)	204132	204132	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197544	197544	0
			.comment	206	206	0
			.data	1468	1468	0
			.debug_abbrev	956756	956756	0
			.debug_aranges	103416	103416	0
			.debug_frame	349704	349704	0
			.debug_info	19489250	19489251	1
			.debug_line	2678035	2678035	0
			.debug_line_str	513	513	0
			.debug_loc	33340	33340	0
			.debug_loclists	1501882	1501882	0
			.debug_ranges	4984	4984	0
			.debug_rnglists	96008	96008	0
			.debug_str	3024877	3024877	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104170	104170	0
			.shstrtab	265	265	0
			.stack	2048	2048	0
			.strtab	477531	477531	0
			.symtab	285936	285936	0
			.text	494824	494824	0

github-actions · 2023-04-26T13:25:16Z

PR #26248: Size comparison from 23a8e5a to 4fa9e40

Increases (1 build for cc32xx)

platform	target	config	section	23a8e5ae	`4fa9e40`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	19489249	19489250	1	0.0

Full report (1 build for cc32xx)

platform	target	config	section	23a8e5ae	`4fa9e40`	change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0
			(read only)	601114	601114	0
			(read/write)	204132	204132	0
			.ARM.attributes	44	44	0
			.ARM.exidx	8	8	0
			.bss	197544	197544	0
			.comment	206	206	0
			.data	1468	1468	0
			.debug_abbrev	956756	956756	0
			.debug_aranges	103416	103416	0
			.debug_frame	349704	349704	0
			.debug_info	19489249	19489250	1
			.debug_line	2678035	2678035	0
			.debug_line_str	513	513	0
			.debug_loc	33340	33340	0
			.debug_loclists	1501882	1501882	0
			.debug_ranges	4984	4984	0
			.debug_rnglists	96008	96008	0
			.debug_str	3024877	3024877	0
			.ramVecs	780	780	0
			.resetVecs	64	64	0
			.rodata	104170	104170	0
			.shstrtab	265	265	0
			.stack	2048	2048	0
			.strtab	477531	477531	0
			.symtab	285936	285936	0
			.text	494824	494824	0

[Darwin]Fix: enable controller to skip complete step;

b15814d

github-actions bot added the darwin label Apr 25, 2023

pullapprove bot requested review from younghak-hwang and yunhanw-google April 25, 2023 10:33

pullapprove bot added the review - pending label Apr 25, 2023

bzbarsky-apple reviewed Apr 25, 2023

View reviewed changes

src/darwin/Framework/CHIP/MTRCommissioningParameters.h Outdated Show resolved Hide resolved

src/darwin/Framework/CHIP/MTRCommissioningParameters.h Outdated Show resolved Hide resolved

[Darwin]set skipCommissioningComplete to boolean value and append MTR…

e034b52

…_NEWLY_AVAILABLE annotation

Damian-Nordic approved these changes Apr 25, 2023

View reviewed changes

bzbarsky-apple approved these changes Apr 25, 2023

View reviewed changes

src/darwin/Framework/CHIP/MTRCommissioningParameters.h Outdated Show resolved Hide resolved

src/darwin/Framework/CHIP/MTRDeviceController.mm Outdated Show resolved Hide resolved

pullapprove bot added review - approved and removed review - pending labels Apr 25, 2023

robinmo and others added 3 commits April 25, 2023 22:57

Update src/darwin/Framework/CHIP/MTRCommissioningParameters.h

5a18ac8

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Update src/darwin/Framework/CHIP/MTRDeviceController.mm

97732a9

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Merge branch 'master' into enable_to_skip_complete_step

3a6c88e

andy31415 approved these changes Apr 25, 2023

View reviewed changes

Merge branch 'master' into enable_to_skip_complete_step

e6e6af2

Merge branch 'master' into enable_to_skip_complete_step

e51cfe5

Merge branch 'master' into enable_to_skip_complete_step

bf40b00

Merge branch 'master' into enable_to_skip_complete_step

4fa9e40

robinmo requested a review from bzbarsky-apple April 26, 2023 16:03

andy31415 merged commit 980a1a1 into project-chip:master Apr 26, 2023

robinmo deleted the enable_to_skip_complete_step branch April 26, 2023 16:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Darwin]Fix: enable controller to skip complete step #26248

[Darwin]Fix: enable controller to skip complete step #26248

robinmo commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

robinmo commented Apr 25, 2023

bzbarsky-apple commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 26, 2023

[Darwin]Fix: enable controller to skip complete step #26248

[Darwin]Fix: enable controller to skip complete step #26248

Conversation

robinmo commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

robinmo commented Apr 25, 2023

bzbarsky-apple commented Apr 25, 2023

github-actions bot commented Apr 25, 2023

github-actions bot commented Apr 26, 2023