[TI] Resolve build issues in Example Applications #28508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix application build failures
|
PR #28508: Size comparison from 2946b42 to 105bfef Increases (11 builds for bl602, cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #28508: Size comparison from ca3dbdf to 736c787 Increases (11 builds for bl702, cc32xx, esp32, mbed, telink)
Decreases (10 builds for bl602, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adabreuti
changed the title
|
PR #28508: Size comparison from 7353fd6 to b26f000 Increases (8 builds for bl602, psoc6, telink)
Decreases (10 builds for bl702, cc32xx, efr32, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@andy31415 @bzbarsky-apple We believe all comments have been addressed, would you be able to approve/merge this PR? |
bzbarsky-apple
approved these changes
Aug 12, 2023
|
Note: @andy31415 is on vacation (as am I), and this needs one more approval. Please ping people on Slack. |
wy-hh
approved these changes
Aug 14, 2023
yufengwangca
approved these changes
Aug 15, 2023
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
* Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
* [ESP32] doc:added doc for vs code development * [ReadHandler] Unification of serial "now" timestamp (#28657) * Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments * [TI] Resolve build issues in Example Applications (#28508) * Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ESP32] doc:added doc for vs code development * [ESP32] doc:added doc for vs code development --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: adabreuti <76965454+adabreuti@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* [ESP32] doc:added doc for vs code development * [ReadHandler] Unification of serial "now" timestamp (project-chip#28657) * Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments * [TI] Resolve build issues in Example Applications (project-chip#28508) * Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ESP32] doc:added doc for vs code development * [ESP32] doc:added doc for vs code development --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: adabreuti <76965454+adabreuti@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* [ESP32] doc:added doc for vs code development * [ReadHandler] Unification of serial "now" timestamp (project-chip#28657) * Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments * [TI] Resolve build issues in Example Applications (project-chip#28508) * Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ESP32] doc:added doc for vs code development * [ESP32] doc:added doc for vs code development --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: adabreuti <76965454+adabreuti@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved build issues with certain applications due to updates in python dependencies in the mainline.
Fastforwaded OT-TI Openthread reference to pull in latest code.
Validated that all TI applications build OOB and are able to commission for CC13x2x7 & CC13x4 variants.
This PR also resolve the issue related to #27937