[ReadHandler] Unification of serial "now" timestamp #28657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
LuDuda and
mhazley
pullapprove
bot
requested review from
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
|
PR #28657: Size comparison from bf0b45a to e54654a Increases (4 builds for cc32xx, mbed, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
…nsure that the NOW value used remains the same along each checks
lpbeliveau-silabs
force-pushed
the
bugfix/report_scheduler_unify_now_timestamp
branch
from
e54654a to
c9f1284
Compare
|
PR #28657: Size comparison from bf0b45a to c9f1284 Increases (12 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Decreases (2 builds for linux)
Full report (12 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
|
PR #28657: Size comparison from bf0b45a to 88dea90 Increases (28 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (16 builds for bl702, bl702l, esp32, linux)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
jmartinez-silabs
approved these changes
Aug 11, 2023
|
PR #28657: Size comparison from bf0b45a to e6dfd19 Increases (28 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Decreases (34 builds for bl702, bl702l, esp32, linux, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 12, 2023
|
PR #28657: Size comparison from bf0b45a to e4d5c3d Increases above 0.2%:
Increases (51 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (23 builds for bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
* Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
* [ESP32] doc:added doc for vs code development * [ReadHandler] Unification of serial "now" timestamp (#28657) * Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments * [TI] Resolve build issues in Example Applications (#28508) * Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ESP32] doc:added doc for vs code development * [ESP32] doc:added doc for vs code development --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: adabreuti <76965454+adabreuti@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* [ESP32] doc:added doc for vs code development * [ReadHandler] Unification of serial "now" timestamp (project-chip#28657) * Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments * [TI] Resolve build issues in Example Applications (project-chip#28508) * Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ESP32] doc:added doc for vs code development * [ESP32] doc:added doc for vs code development --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: adabreuti <76965454+adabreuti@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* [ESP32] doc:added doc for vs code development * [ReadHandler] Unification of serial "now" timestamp (project-chip#28657) * Removed multiple calls to GetCurrentMonotonicTimestamp in series to ensure that the NOW value used remains the same along each checks * removed mNow, using stack now timestamps instead * Added missing @param description * Removed un-necessary comments * [TI] Resolve build issues in Example Applications (project-chip#28508) * Update TI Example applications to correctly pull in requirements.txt - Fix application build failures * Adjust return value to properly exit post-commissioning * Resolve run-time failure when using MTD configuration * Update OT TI Configuration * Disable Progress logging on lighting app for size constraints * Restyled by clang-format * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io> * [ESP32] doc:added doc for vs code development * [ESP32] doc:added doc for vs code development --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: adabreuti <76965454+adabreuti@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
lpbeliveau-silabs
deleted the
bugfix/report_scheduler_unify_now_timestamp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralized the "now" timestamp used to schedule reports and validate reportability to a value held in the Report Scheduler that is called at start of each callbacks needing to schedule reports or assess reportability.