-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Update KeyStore for Check-in keys #29260
[ICD] Update KeyStore for Check-in keys #29260
Conversation
d7dc4e1
to
cd0af71
Compare
2057f69
to
ce91af8
Compare
PR #29260: Size comparison from 22a5485 to ce91af8 Increases (1 build for mbed)
Full report (16 builds for bl602, bl702, bl702l, k32w, mbed)
|
ce91af8
to
4b1a171
Compare
PR #29260: Size comparison from cff70e1 to 4b1a171 Increases above 0.2%:
Increases (28 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29260: Size comparison from cff70e1 to 7090a71 Increases above 0.2%:
Increases (2 builds for cc32xx, mbed)
Full report (4 builds for cc32xx, mbed, qpg)
|
PR #29260: Size comparison from cff70e1 to e24079f Increases (7 builds for bl702, bl702l)
Full report (10 builds for bl602, bl702, bl702l)
|
src/app/clusters/icd-management-server/icd-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/icd-management-server/icd-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/icd-management-server/icd-management-server.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to prevent accidental merge, since issues are being resolved without having been addressed yet.
38913f9
to
d200424
Compare
PR #29260: Size comparison from e8f516a to d200424 Increases above 0.2%:
Increases (6 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect)
Full report (19 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
d200424
to
1300305
Compare
PR #29260: Size comparison from 78eb271 to 1300305 Increases above 0.2%:
Increases (28 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (3 builds for efr32, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29260: Size comparison from 78eb271 to d40c24c Increases above 0.2%:
Increases (30 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (58 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #29260: Size comparison from 78eb271 to f7d90a1 Increases above 0.2%:
Increases (36 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Update KeyStore for Check-in keys * fix comments * fix comments
As described in Spec Issue 7519, storing of keys in general in the Matter SDK should be handle by the KeyStore. Update the ICD implementation so that the key is no longer a ByteSpan but a KeyHandle.
This also makes the comparaison of keys impossible if using PSA_CRYPTO since inside the key handle you'll only find a key ID and not the key itself.
This should be considered as a fix to issue 7519 of the spec