-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux tv-casting-app: simplified CastingPlayerDiscovery API #29444
Merged
sharadb-amazon
merged 4 commits into
project-chip:master
from
sharadb-amazon:lin_disc_20230925
Sep 27, 2023
Merged
Linux tv-casting-app: simplified CastingPlayerDiscovery API #29444
sharadb-amazon
merged 4 commits into
project-chip:master
from
sharadb-amazon:lin_disc_20230925
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
September 25, 2023 23:07
pullapprove
bot
requested review from
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 25, 2023 23:07
PR #29444: Size comparison from 6bb0b71 to bc2dc0a Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for linux)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
lin_disc_20230925
branch
from
September 26, 2023 16:47
bc2dc0a
to
9a57416
Compare
PR #29444: Size comparison from 8ace42e to 9a57416 Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for linux)
Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29444: Size comparison from 8ace42e to b18f35a Increases above 0.2%:
Increases (1 build for linux)
Decreases (1 build for linux)
Full report (48 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
chrisdecenzo
approved these changes
Sep 26, 2023
sharadb-amazon
force-pushed
the
lin_disc_20230925
branch
from
September 27, 2023 17:24
b9b202f
to
0a558bd
Compare
PR #29444: Size comparison from 24b1d03 to 1be54e6 Full report (1 build for cc32xx)
|
sharadb-amazon
force-pushed
the
lin_disc_20230925
branch
from
September 27, 2023 17:45
1be54e6
to
2c0ecb8
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 27, 2023
sharadb-amazon
force-pushed
the
lin_disc_20230925
branch
from
September 27, 2023 17:47
2c0ecb8
to
3f86f04
Compare
sharadb-amazon
force-pushed
the
lin_disc_20230925
branch
from
September 27, 2023 17:51
3f86f04
to
ceb80cf
Compare
PR #29444: Size comparison from 24b1d03 to ceb80cf Increases above 0.2%:
Increases (1 build for linux)
Decreases (2 builds for linux, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
hawk248
approved these changes
Sep 27, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…chip#29444) * Linux tv-casting-app: simplified CastingPlayerDiscovery API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
controller
documentation
Improvements or additions to documentation
examples
review - approved
tv-casting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies and decouples the discovery implementation for the CastingApp from the old CastingServer.h/cpp.
Change summary
Testing
Verified and tested locally with Linux TV app