-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app docs: Marked code with triple backticks #29497
Merged
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:codeblocks-20230928
Sep 29, 2023
Merged
tv-casting-app docs: Marked code with triple backticks #29497
sharadb-amazon
merged 1 commit into
project-chip:master
from
sharadb-amazon:codeblocks-20230928
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
requested review from
andy31415,
chrisdecenzo and
bzbarsky-apple
September 28, 2023 21:59
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
September 28, 2023 22:05
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 28, 2023 22:05
PR #29497: Size comparison from 568362a to a4701c9 Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
sharadb-amazon
force-pushed
the
codeblocks-20230928
branch
from
September 28, 2023 22:34
a4701c9
to
96a7b1f
Compare
PR #29497: Size comparison from 475d927 to 96a7b1f Increases (2 builds for bl702, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 29, 2023
andy31415
approved these changes
Sep 29, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the code in the tv-casting-app/APIs.md document (added with #29444) was not marked with triple backticks and that was leading to spellcheck failures (and subsequent addition of code "words" to the .wordlist.txt file).
This PR puts the code in triple backticks and removes most of the unnecessary words added to the .wordlist.txt file.
Tested by running
pyspelling --config .spellcheck.yml
that spellchecker does not complain.