Remove test for provisional attributes in TCCM 1-1 YAML (SVE issue) #29467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test step was expecting OnMode and StartupMode attributes (when no event list). This is not what the spec nor the TP states. These attributes are provisional, and explicitly disallowed by the device type. Seen in SVE, with a manual workaround in place.
|
PR #29467: Size comparison from 7b4df1c to 13ad1ef Full report (3 builds for cc32xx, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #29467: Size comparison from 7b4df1c to 0df3530 Decreases (1 build for telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 27, 2023
| @@ -75,7 +75,7 @@ tests: | |||
| response: | |||
| constraints: | |||
| type: list | |||
| contains: [0, 1, 2, 3, 65528, 65529, 65531, 65532, 65533] | |||
| contains: [0, 1, 65528, 65529, 65531, 65532, 65533] | |||
There was a problem hiding this comment.
Note that this is also part of #29339, but that's blocked on unrelated issues... which is the problem with do-it-all-at-once PRs.
andy31415
approved these changes
Oct 2, 2023
|
Closing because PR already part of #29339 |
|
/rebase |
|
PR #29467: Size comparison from 199b155 to dd99d76 Increases (1 build for bl702l)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test step was expecting OnMode and StartupMode attributes (when no event list). This is not what the spec nor the TP states. These attributes are provisional, and explicitly disallowed by the device type.
Seen in SVE, with a manual workaround in place.
Bug being fixed occurs on all runs of TCCM 1-1 against device type conforming implementations.